From: Richard Copley <rcopley@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 35739@debbugs.gnu.org, Noam Postavsky <npostavs@gmail.com>
Subject: bug#35739: Bad signature from GNU ELPA
Date: Wed, 15 May 2019 08:13:43 +0100 [thread overview]
Message-ID: <CAPM58ogv285nuvuCVBBJWz5qy375ipyGkCk=gBSwDrP4r7-=Fw@mail.gmail.com> (raw)
In-Reply-To: <835zqca15y.fsf@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 804 bytes --]
On Wed, 15 May 2019 at 03:42, Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Richard Copley <rcopley@gmail.com>
> > Date: Tue, 14 May 2019 23:42:31 +0100
> > Cc: 35739@debbugs.gnu.org
> >
> > ... and (apologies) I don't have a copyright assignment on file, so I'll
> have to
> > leave it to Somebody to do TRT.
>
> The change is small enough for us not to be bothered by that.
>
OK, then I have another reason to leave it to someone else: I don't
understand the code in "package.el" and "url.el" well enough to be
confident making changes there.
The attached patch is less stupid, in that it doesn't have the
potential to break all the users of url-retrieve. Still, I'm not
asserting it's a sound or complete fix, or recommending it for
inclusion in Emacs. It does get rid of the error from my recipe.
[-- Attachment #1.2: Type: text/html, Size: 1351 bytes --]
[-- Attachment #2: 35739.patch --]
[-- Type: application/octet-stream, Size: 1006 bytes --]
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 949ad711ae..6b70c5e2a3 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1225,7 +1225,7 @@ package--with-work-buffer
(goto-char (point-min))
(unless (search-forward-regexp "^\r?\n\r?" nil 'noerror)
(error "Error retrieving: %s %S" ,url-sym "incomprehensible buffer")))
- (url-insert-buffer-contents ,b-sym ,url-sym)
+ (url-insert ,b-sym)
(kill-buffer ,b-sym)
(goto-char (point-min)))))
nil
next prev parent reply other threads:[~2019-05-15 7:13 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 21:25 bug#35739: Bad signature from GNU ELPA Richard Copley
2019-05-14 21:37 ` bug#35739: Acknowledgement (Bad signature from GNU ELPA) Richard Copley
2019-05-14 22:04 ` bug#35739: Bad signature from GNU ELPA Noam Postavsky
2019-05-14 22:26 ` Richard Copley
2019-05-14 22:42 ` Richard Copley
2019-05-15 2:42 ` Eli Zaretskii
2019-05-15 7:13 ` Richard Copley [this message]
2019-05-15 14:03 ` Stefan Monnier
2019-05-15 15:03 ` Eli Zaretskii
2019-05-18 22:36 ` Stefan Monnier
2019-05-22 5:19 ` Eli Zaretskii
2019-05-22 16:20 ` Stefan Monnier
2019-05-22 17:09 ` Eli Zaretskii
2019-05-22 19:40 ` Stefan Monnier
2019-05-23 3:50 ` Eli Zaretskii
2019-05-23 4:06 ` Stefan Monnier
2019-05-23 4:52 ` Eli Zaretskii
2019-05-23 12:10 ` Stefan Monnier
2019-05-23 14:15 ` Eli Zaretskii
2019-05-24 14:22 ` Stefan Monnier
2019-05-24 15:00 ` Eli Zaretskii
2019-05-24 19:31 ` Stefan Monnier
2019-05-24 19:43 ` Eli Zaretskii
2019-05-24 19:51 ` Stefan Monnier
2019-05-25 7:36 ` Eli Zaretskii
2019-05-25 18:38 ` Stefan Monnier
2019-05-25 19:13 ` Eli Zaretskii
2019-05-15 2:41 ` Eli Zaretskii
2019-05-15 6:46 ` Richard Copley
2019-05-15 14:40 ` Eli Zaretskii
2019-05-15 15:12 ` Richard Copley
2019-05-29 18:45 ` Stefan Monnier
2019-05-29 19:11 ` Richard Copley
2019-05-29 20:07 ` Stefan Monnier
2019-05-29 20:50 ` Noam Postavsky
2019-05-30 2:35 ` Eli Zaretskii
2019-05-31 4:54 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPM58ogv285nuvuCVBBJWz5qy375ipyGkCk=gBSwDrP4r7-=Fw@mail.gmail.com' \
--to=rcopley@gmail.com \
--cc=35739@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.