bug#35739: Bad signature from GNU ELPA

[Richard Copley <rcopley@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 804 bytes --]

On Wed, 15 May 2019 at 03:42, Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Richard Copley <rcopley@gmail.com>
> > Date: Tue, 14 May 2019 23:42:31 +0100
> > Cc: 35739@debbugs.gnu.org
> >
> > ... and (apologies) I don't have a copyright assignment on file, so I'll
> have to
> > leave it to Somebody to do TRT.
>
> The change is small enough for us not to be bothered by that.
>

OK, then I have another reason to leave it to someone else: I don't
understand the code in "package.el" and "url.el" well enough to be
confident making changes there.

The attached patch is less stupid, in that it doesn't have the
potential to break all the users of url-retrieve. Still, I'm not
asserting it's a sound or complete fix, or recommending it for
inclusion in Emacs. It does get rid of the error from my recipe.

[-- Attachment #1.2: Type: text/html, Size: 1351 bytes --]

[-- Attachment #2: 35739.patch --]
[-- Type: application/octet-stream, Size: 1006 bytes --]

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 949ad711ae..6b70c5e2a3 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1225,7 +1225,7 @@ package--with-work-buffer
                                                                    (goto-char (point-min))
                                                                    (unless (search-forward-regexp "^\r?\n\r?" nil 'noerror)
                                                                      (error "Error retrieving: %s %S" ,url-sym "incomprehensible buffer")))
-                                                                 (url-insert-buffer-contents ,b-sym ,url-sym)
+                                                                 (url-insert ,b-sym)
                                                                  (kill-buffer ,b-sym)
                                                                  (goto-char (point-min)))))
                                                nil