From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.bugs Subject: bug#37957: BibTeX dialect not set if local variables disabled Date: Wed, 30 Oct 2019 16:32:30 +0000 Message-ID: References: <87ftjcaojz.fsf@gnus.org> <39771.36515.154463.23991@gargle.gargle.HOWL> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000ffcfe90596234867" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="133919"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Lars Ingebrigtsen , 37957@debbugs.gnu.org To: Roland Winkler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 30 17:34:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPqvN-000Yh5-M8 for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Oct 2019 17:34:21 +0100 Original-Received: from localhost ([::1]:42536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPqvM-0002bl-5c for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Oct 2019 12:34:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57677) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPqv9-0002VT-Bu for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 12:34:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPqv4-0000LA-Ae for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 12:34:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42544) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iPqv4-0000Kx-5P for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 12:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iPqv3-0005Ic-Vy for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 12:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Richard Copley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Oct 2019 16:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37957 X-GNU-PR-Package: emacs Original-Received: via spool by 37957-submit@debbugs.gnu.org id=B37957.157245318420300 (code B ref 37957); Wed, 30 Oct 2019 16:34:01 +0000 Original-Received: (at 37957) by debbugs.gnu.org; 30 Oct 2019 16:33:04 +0000 Original-Received: from localhost ([127.0.0.1]:51365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPqu8-0005HK-Do for submit@debbugs.gnu.org; Wed, 30 Oct 2019 12:33:04 -0400 Original-Received: from mail-ot1-f45.google.com ([209.85.210.45]:34248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPqu6-0005Gn-5o for 37957@debbugs.gnu.org; Wed, 30 Oct 2019 12:33:03 -0400 Original-Received: by mail-ot1-f45.google.com with SMTP id m19so2706146otp.1 for <37957@debbugs.gnu.org>; Wed, 30 Oct 2019 09:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+ZQCQELtxFeIblNkbmg8Im6UXl0JpoE9JqaJdNBxUlw=; b=ON3lpZAoZgIfzoLwcH7EN5Kr3o7c4eHll0Th5ivpZ9wLTTd/hiRtRCm16rUDbay5mD 6rOpy9SJbwmLIYNcZEAPXYKuTIMnHu1Bo+dQ/b9nu+lAdkDTxz6aYf4e2FCx3RI++ooP o4umjFSeVJRgExX/TSWCUyhfXRgEqpSoGo1O+w0EXNI49hf3wKHUXUnA0RKEc91G9kuI JmIruSnnsP0F9bsjFbj3sg91ud6r4YAV3cxBd/XwngEdOeXX+ZWmrfavuh3XQ9OKbnSa fReGMiM3TEByg6GSMK+heN62BWfneXyt7py9bw9mYFNrPc0l1uFy6VnpYHgzdpAoBKjX lDqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+ZQCQELtxFeIblNkbmg8Im6UXl0JpoE9JqaJdNBxUlw=; b=AeArp6KMC7v69YzTAlsdQSzPNJU7oNyJsyF7WRPsRzAVw4dnnu8HvUH/+EDb3DFiKJ t8I3D3vyOnZa0Hh/cLB8UFEJHdxLwE8PlGFtz76BGpCC3vFylmSSDaJaSEJQWUPaMIK9 L7AhiynpbYgqWI3qJVTr9TTV3Od0O7uJSQcjUmakC612da/gcTuHLf8jNN9EqLKcZSDO MWCkj4fH9lrBV5RwnweJ5zyHrr6uiUyFdF8/yFeqGmydiJgrmsuBNJbmPRjuX0MmQ6U0 mZzv25mpA4DsDiTmfeT0dfxH/N7kLehmBS0z9LJGWyMEsyiUNufmvZjWa+GaIbCCYJJK jkww== X-Gm-Message-State: APjAAAUdkhMknVA7jGLvpjoOS6dQNw//6kR0/MzoRjcdtwrotFl0rSm4 k3ZM2Zt4KzazD0aRZWmF9WvFjOnIexiJ0kW3fEcOtV+8bT8= X-Google-Smtp-Source: APXvYqyoJvA4m5wXjpthhLlNmk+KLxAcINjaot6kRf3qmvEJV24JOI22ctmUADG8HGQJ4SOEhI+qh7sXJ/0fEzxux+Y= X-Received: by 2002:a9d:286:: with SMTP id 6mr665381otl.192.1572453176298; Wed, 30 Oct 2019 09:32:56 -0700 (PDT) In-Reply-To: <39771.36515.154463.23991@gargle.gargle.HOWL> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170429 Archived-At: --000000000000ffcfe90596234867 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 29 Oct 2019 at 01:52, Roland Winkler wrote: > On Mon Oct 28 2019 Lars Ingebrigtsen wrote: > > Do you have an example .bib file that can be used to reproduce this bug= ? > > I can, indeed, reproduce this with `emacs -Q', setting > enable-local-variables to nil and then loading any BibTeX file. > > Yet it is not clear to me what is the proper solution for this. > > Currently, bibtex-mode makes bibtex-set-dialect an element of > hack-local-variables-hook. This hook is called only if > enable-local-variables is non-nil. Of course, bibtex-mode could > call bibtex-set-dialect directly if enable-local-variables is nil. > Yet I guess that enable-local-variables being nil may break more > things if hack-local-variables-hook is not called. Did you have something in mind? I don't see how it might break anything for BibTeX mode. If it breaks something elsewhere, that is a separate bug. > If nothing else, we could mention in the docstring of > hack-local-variables-hook that this hook is not called if > enable-local-variables is nil. Perhaps, but it is clear from the existing docstring ("[...] run after processing a file=E2=80=99s local variables specs"), in my opinion. --000000000000ffcfe90596234867 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, 29 Oct 2019 at 01:52, Roland Winkler <winkler@gnu.org> wrote:
> On Mon O= ct 28 2019 Lars Ingebrigtsen wrote:
> > Do you have an example .bi= b file that can be used to reproduce this bug?
>
> I can, indee= d, reproduce this with `emacs -Q', setting
> enable-local-variabl= es to nil and then loading any BibTeX file.
>
> Yet it is not c= lear to me what is the proper solution for this.
>
> Currently,= bibtex-mode makes bibtex-set-dialect an element of
> hack-local-vari= ables-hook.=C2=A0 This hook is called only if
> enable-local-variable= s is non-nil.=C2=A0 Of course, bibtex-mode could
> call bibtex-set-di= alect directly if enable-local-variables is nil.
> Yet I guess that e= nable-local-variables being nil may break more
> things if hack-local= -variables-hook is not called.

Did you have something in mind? I don= 't see how it might break anything for BibTeX mode. If it breaks someth= ing elsewhere, that is a separate bug.

> If nothing else, we coul= d mention in the docstring of
> hack-local-variables-hook that this h= ook is not called if
> enable-local-variables is nil.

Per= haps, but it is clear from the existing docstring ("[...] run after pr= ocessing a file=E2=80=99s local variables specs"), in my opinion.

--000000000000ffcfe90596234867--