From: Richard Copley <rcopley@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: martin rudalics <rudalics@gmx.at>,
Emacs Development <emacs-devel@gnu.org>
Subject: Re: delete-other-frames
Date: Tue, 23 Aug 2016 18:56:52 +0100 [thread overview]
Message-ID: <CAPM58oghB6HjyPhgbvm03kekdoZQXrb4BVbnU4MFGAABjhzBXw@mail.gmail.com> (raw)
In-Reply-To: <83k2f7fugv.fsf@gnu.org>
On 23 August 2016 at 15:09, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Tue, 23 Aug 2016 10:19:59 +0200
>> From: martin rudalics <rudalics@gmx.at>
>>
>> The problematic code in ‘delete-other-frames’ is this:
>>
>> ;; Delete mon-minibuffer-only frames first, because `delete-frame'
>> ;; signals an error when trying to delete a mini-frame that's
>> ;; still in use by another frame.
>> (dolist (frame frames)
>> (unless (eq (frame-parameter frame 'minibuffer) 'only)
>> (delete-frame frame)))
>>
>> Here we try to delete all frames whose `minibuffer' parameter is not
>> `only'. However, the minibuffer window of a minibuffer-less frame might
>> be on a _normal_ frame as in our example: The minibuffer window of the
>> frame ‘less’ is owned by the initial frame and ‘delete-other-frames’
>> tries to delete that frame before ‘less’, resulting in the error cited
>> above.
>>
>> Should we document the current behavior in the doc-string or should we
>> amend the code?
>
> IMO, amend the code.
>
>> (2) The doc-string says "Delete all frames on the current terminal,
>> except FRAME." IIUC this doesn't make much sense when FRAME is not on
>> the current terminal. In that case, ‘delete-other-frames’ will delete
>> all frames on the current terminal and leave the frames on FRAME's
>> terminal alone. In order to delete all other frames on FRAME's terminal
>> one has to make that terminal current first. If that is the desired
>> behavior, we should mention it in the doc-string. Otherwise, we should
>> delete all other frames on FRAME's terminal.
>
> The latter, I think.
Possibly related: from emacs -Q,
C-x b * RET ;; create and switch to buffer "*"
M-x ediff-buffers RET RET RET ;; ediff buffers "*" and "*scratch*"
;; Now attempt to close the main Emacs frame using the window manager
This gives:
Debugger entered--Lisp error: (error "Attempt to delete a surrogate
minibuffer frame")
delete-frame(#<frame *scratch* 00000004009c5870> t)
handle-delete-frame((delete-frame (#<frame *scratch* 00000004009c5870>)))
funcall-interactively(handle-delete-frame (delete-frame (#<frame
*scratch* 00000004009c5870>)))
call-interactively(handle-delete-frame nil [(delete-frame (#<frame
*scratch* 00000004009c5870>))])
command-execute(handle-delete-frame nil [(delete-frame (#<frame
*scratch* 00000004009c5870>))] t)
read-event(nil t 2)
sit-for(2)
execute-extended-command(nil "toggle-debug-on-error" "t-d-o-e")
funcall-interactively(execute-extended-command nil
"toggle-debug-on-error" "t-d-o-e")
call-interactively(execute-extended-command nil nil)
command-execute(execute-extended-command)
I've never been sure whether this deserves a bug report, or what
should be the expected behaviour. FWIW when this happens my intention
is usually to kill Emacs. In any case the error message isn't very
user friendly.
next prev parent reply other threads:[~2016-08-23 17:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 8:19 delete-other-frames martin rudalics
2016-08-23 14:09 ` delete-other-frames Eli Zaretskii
2016-08-23 17:56 ` Richard Copley [this message]
2016-08-23 18:31 ` delete-other-frames Eli Zaretskii
2016-08-23 19:55 ` delete-other-frames Richard Copley
2016-08-24 9:07 ` delete-other-frames martin rudalics
2016-08-24 9:06 ` delete-other-frames martin rudalics
2016-08-25 9:16 ` delete-other-frames martin rudalics
2016-08-25 14:46 ` delete-other-frames Eli Zaretskii
2016-08-27 1:32 ` delete-other-frames Richard Stallman
2016-08-27 7:40 ` delete-other-frames Eli Zaretskii
[not found] ` <<E1bdSUT-00059T-8W@fencepost.gnu.org>
2016-08-27 6:31 ` delete-other-frames Drew Adams
2016-08-27 7:45 ` delete-other-frames Eli Zaretskii
2016-08-27 13:32 ` delete-other-frames allan gottlieb
2016-08-27 13:40 ` delete-other-frames allan gottlieb
2016-08-27 21:45 ` delete-other-frames Richard Stallman
[not found] ` <<49a2a9c7-8573-4f07-897f-3eb444679d8a@default>
[not found] ` <<E1bdlPn-0005Ch-I4@fencepost.gnu.org>
2016-08-28 0:41 ` delete-other-frames Drew Adams
[not found] <<<57BC072F.9070704@gmx.at>
[not found] <<57BC072F.9070704@gmx.at>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPM58oghB6HjyPhgbvm03kekdoZQXrb4BVbnU4MFGAABjhzBXw@mail.gmail.com \
--to=rcopley@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.