From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.devel Subject: Re: Suspicious warning in W64 build Date: Sat, 16 Sep 2017 09:19:23 +0100 Message-ID: References: <1017454172.910810.1504618695244@mail.libero.it> <83tw0ezgi1.fsf@gnu.org> <1146932094.13821.1504798935795@mail.libero.it> <83mv66z66p.fsf@gnu.org> <102a4c21-c275-c73e-ec53-0d85975dc968@cs.ucla.edu> <83a825znuf.fsf@gnu.org> <831snhzkgw.fsf@gnu.org> <837ex9x7vf.fsf@gnu.org> <83tw0cwcle.fsf@gnu.org> <83h8wcw3td.fsf@gnu.org> <83377vx3d0.fsf@gnu.org> <83ingnq01t.fsf@gnu.org> <83fubrpxsv.fsf@gnu.org> <83r2v9masw.fsf@gnu.org> <83efr8mje5.fsf@gnu.org> <83o9qbkuxm.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1505550003 32008 195.159.176.226 (16 Sep 2017 08:20:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Sep 2017 08:20:03 +0000 (UTC) Cc: Fabrice Popineau , Emacs Development To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 16 10:19:57 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dt8KT-00085x-7t for ged-emacs-devel@m.gmane.org; Sat, 16 Sep 2017 10:19:57 +0200 Original-Received: from localhost ([::1]:56369 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dt8Ka-0000iu-Es for ged-emacs-devel@m.gmane.org; Sat, 16 Sep 2017 04:20:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dt8KT-0000ia-QJ for emacs-devel@gnu.org; Sat, 16 Sep 2017 04:19:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dt8KS-0007Wz-Tw for emacs-devel@gnu.org; Sat, 16 Sep 2017 04:19:57 -0400 Original-Received: from mail-ua0-x233.google.com ([2607:f8b0:400c:c08::233]:43902) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dt8KR-0007Vy-BA; Sat, 16 Sep 2017 04:19:55 -0400 Original-Received: by mail-ua0-x233.google.com with SMTP id g47so2289914uad.0; Sat, 16 Sep 2017 01:19:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=rcNDEoe2O/bpUEL/MZNphvGtF+dI35X8MHTLutLEw2o=; b=OlioiM8klBau/zGcUrf1+mny9bCAtsufK0/TqIO+LpOJjYOgGEDsE7uFDG+ReId41H 1uqKQcYpF/+lHhRfEYzV+CqSusFljlJCOPJr+IkfbwXjpWA6vmks23y10Iqjql79f6G0 gJYQSDgnEiPGqPoGLH6wB9bQXqwy4Srw41vgGevhW2hzGnTbAFiDP9FowrZxrZnVu7em DCX2xLZ/u+5Bct9B1If06ERuyC2YIn+jj+e3KSXYt7JzFTH5FfZTIYPQuITHSIQqYvvY zpbRHB/oweznkEiRUuojqdHPMudh1talcT0wdX3P0IQxWmKkNX8FIF3qZNuPJYTlSIpa h56w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=rcNDEoe2O/bpUEL/MZNphvGtF+dI35X8MHTLutLEw2o=; b=IVs9uMQuy62kOSWMmu2opAPjBquFPyIoFvP8O+KiyUWuHCIkWQj/2ZYCHSGrnq6qwX LvnwnNigxhkP0zMnG1bdfwK73R5E1jl0M/z1Ir8hZcmGCkJWxkzoY8BTwIpoNz2Kne8N 8QKiBF5XS1IEj2MwTvWkqPBkLSeS8miitPdZRke5DSUHgGhy5hk5FFzJ6jtd8Zhp7c3o b5D0fq2PmEmvcpiOeho38jeEMk1pOtzBYQlOsX7sldNE+GPGCovf3wLhNy0rdhwuVrVR Ahkw7voiKQogxgZz0roRDcxrYgoI01nSSIuqB9RfApQSqrmg+TY/PCdKdL346V0BZRpZ Ys9g== X-Gm-Message-State: AHPjjUgfKvxbM46lhNLlbuhJacOFdaVM/kkYnmxXngwUCAotBO6DBdxU /I4z1DLiVosDXXIFShYEdl0t3MjE0eXdIEiA9xc= X-Google-Smtp-Source: ADKCNb5EgJrBx97igUmiziNyZgT3gf4sbtYvpPvG6Y5Cm5fFeavU+kQ+p7q+6VL/m7sVsghIM5m0sO34e0UNp3Oygmc= X-Received: by 10.176.80.249 with SMTP id d54mr23575145uaa.178.1505549994486; Sat, 16 Sep 2017 01:19:54 -0700 (PDT) Original-Received: by 10.159.41.102 with HTTP; Sat, 16 Sep 2017 01:19:23 -0700 (PDT) In-Reply-To: <83o9qbkuxm.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400c:c08::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218347 Archived-At: On 16 September 2017 at 07:40, Eli Zaretskii wrote: >> From: Richard Copley >> Date: Sat, 16 Sep 2017 00:05:44 +0100 >> Cc: Fabrice Popineau , >> Emacs Development >> >> On 15 September 2017 at 09:54, Eli Zaretskii wrote: >> > About this warning: >> > >> > w32.c:7550:1: warning: no previous prototype for 'sys_strerror' [-Wmissing-prototypes] >> > sys_strerror (int error_no) >> > ^~~~~~~~~~~~ >> > >> > What MinGW64 header has the prototype of strerror? I thought it was >> > string.h, like in mingw.org's headers, but evidently that's not true? >> > If the prototype is in string.h, then why is this warning being >> > displayed? >> >> It is in string.h. >> Forgive me if I misunderstood, but isn't it because the warning is >> about a prototype for sys_strerror, not a prototype for strerror? > > If you look at the beginning of w32.c, you will see that we include > string.h before we #undef strerror. The header nt/inc/ms-w32.h > #define's strerror to sys_strerror, so the inclusion of string.h > should have supplied the prototype for sys_strerror. Why doesn't it > do that in MinGW64? Does some system header #undef strerror too > early? I see, thanks. No, there's no #undef. We end up including string.h before ms-w32.h (w32.c includes io.h and io.h unconditionally includes string.h).