From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew De Angelis Newsgroups: gmane.emacs.bugs Subject: bug#60703: Patches to xwidget code Date: Thu, 23 Feb 2023 22:47:41 -0500 Message-ID: References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> <83bkmsmk6g.fsf@gnu.org> <83fsc3lwtg.fsf@gnu.org> <87pmb024d7.fsf@yahoo.com> <83bklowobq.fsf@gnu.org> <838rgpsue3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000074573105f569fe23" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13728"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 24 04:48:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVP4B-0003Kd-BK for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Feb 2023 04:48:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVP3z-0001m7-UV; Thu, 23 Feb 2023 22:48:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVP3y-0001ly-Qd for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 22:48:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVP3y-0001hM-Hp for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 22:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVP3y-0005cU-DQ for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 22:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrew De Angelis Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Feb 2023 03:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60703 X-GNU-PR-Package: emacs Original-Received: via spool by 60703-submit@debbugs.gnu.org id=B60703.167721048121596 (code B ref 60703); Fri, 24 Feb 2023 03:48:02 +0000 Original-Received: (at 60703) by debbugs.gnu.org; 24 Feb 2023 03:48:01 +0000 Original-Received: from localhost ([127.0.0.1]:35745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVP3x-0005c9-3q for submit@debbugs.gnu.org; Thu, 23 Feb 2023 22:48:01 -0500 Original-Received: from mail-vs1-f47.google.com ([209.85.217.47]:36467) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVP3u-0005bK-R0 for 60703@debbugs.gnu.org; Thu, 23 Feb 2023 22:47:59 -0500 Original-Received: by mail-vs1-f47.google.com with SMTP id j14so19504302vse.3 for <60703@debbugs.gnu.org>; Thu, 23 Feb 2023 19:47:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FZ/1Yiz9s1uHu6HDXY20F+HQN2LdVIYvtJTvcZJyNdg=; b=q4DJsT+gSdcpQP7ZKCRGXP6YeCcd+Kw3Pzhq9DfRoJ121cPPav5JFPI5eRC3h1jIQy U/OY+SqPLnWc329sXkJK3x6uxQx6ypmhiElKpT7SFxszlkIOjBUg7WN44HMnmB/KCOKi b4k/hoKar5jwyHukDW8lZro5Jq5SF8xj9Bee7eQQZ8zAjsfHEiUmKbCFl9eBZSvuIJAN 7hmMo7R8XZAIvPI0SpeQZ48NBwJTRQ2L8dcg+ZUwoZd50qZv/08CcuVqjX+pHtWcUN1X JUpTqI5Poa5ozSHr5J5hJlGhGbcrYslUxXusCqvfdnh1T0vgEXSBoPwrFt+AbeIjH99A 5YhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FZ/1Yiz9s1uHu6HDXY20F+HQN2LdVIYvtJTvcZJyNdg=; b=zXQHSPgXrI43+K6RlR0aigPZJXXvo8jQ/b4VbEa710yNNVT+g/O+t1zlC9k//nvmcS WV5EDaZAHl4HuUDxw5fdkTH3HBQRd+Xe0tH2m7aSUDycKJsmBqxtQmVjuKF6tM/xLTt/ aTQ97PksTwM0ajDD1ArZ2/Asy+UesupamPBeIcSLNLH8hBHfHiul25wiRZUroqO/bl23 zy5BgWtF4MxVIQXN7goSMvozy5z4178YMfA8R6Ypb9EJYa3yS/GWp0+mvB65XNViVKnR LCF4bJcrSGRAyPLLCzs65Bjtm8lQgJ0+9kqjgcu5qYtrMbPlpe3J2RX7DWx3Kv2tB732 mAQA== X-Gm-Message-State: AO0yUKXFwnj6TtBgB/YjND37EcfLGKnbTSqNT6tlRU0XnFqKKXFw/dvi 53GT2YLgZf4UDWDpVBqY6VC85VvazayItlXJ0ypP24cs0gc= X-Google-Smtp-Source: AK7set+iAmS1hEmfp1agz5ejW1AByu/atg6/HkdH6zrE7uU03V4TSKH1zDekixOluvEv/33fod2sbYMa4ZQFosfJFiE= X-Received: by 2002:a05:6102:30b3:b0:412:27f7:491b with SMTP id y19-20020a05610230b300b0041227f7491bmr1519671vsd.2.1677210472928; Thu, 23 Feb 2023 19:47:52 -0800 (PST) In-Reply-To: <838rgpsue3.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256540 Archived-At: --00000000000074573105f569fe23 Content-Type: multipart/alternative; boundary="00000000000074573005f569fe21" --00000000000074573005f569fe21 Content-Type: text/plain; charset="UTF-8" Let me know if this ChangeLog is fine or you'd like me to make any changes. The first line of a doc string should be a single complete sentence. > I'm not sure I follow: in this case, isn't this the first line: "Get the estimated load progress of XWIDGET, a WebKit widget."? It renders fine when I run `M-x apropos xwidget-webkit-estimated-load-progress`. But happy to make any additional changes if needed. On Wed, Feb 22, 2023 at 8:26 AM Eli Zaretskii wrote: > > From: Andrew De Angelis > > Date: Tue, 21 Feb 2023 00:24:06 -0500 > > Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org > > > > Done. (git diff forked/emacs-29 > emacs-29-xwidget-patches.patch) > > > > Let me know if there's anything I should do. Thanks! > > Thanks, what is missing now is the commit log message. Please see > CONTRIBUTE and the examples in the Git repository, for how we format > the log messages. > > One minor comment to the code: > > > +DEFUN ("xwidget-webkit-estimated-load-progress", > > + Fxwidget_webkit_estimated_load_progress, > Sxwidget_webkit_estimated_load_progress, > > + 1, 1, 0, doc: /* Get the estimated load progress of XWIDGET, a > WebKit widget. > > +Return a value ranging from 0.0 to 1.0, based on how close XWIDGET > > +is to completely loading its page. */) > > The first line of a doc string should be a single complete sentence. > This is because commands like "M-x apropos" show only the first line. > > (Yes, I'm aware that you just moved existing code, but still: let's > fix this while we are at that.) > --00000000000074573005f569fe21 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Let me know if this ChangeLog is fine or you'd li= ke me to make any changes.

The first line of a doc string should be a singl= e complete sentence.
I'm not sure I follow: in t= his case, isn't=C2=A0 this the first line: "Get the estimated load progress of XWIDGET, a WebKit widget."? It r= enders fine when I run `M-x apropos xwidget-webkit-estimated-load-progress`= . But happy to make any additional changes if needed.
=


On Wed, Feb 22, 2023 at 8:26 AM Eli Zaretskii <= eliz@gnu.org> wrote:
> From: Andrew De Angelis &l= t;bobodeangeli= s@gmail.com>
> Date: Tue, 21 Feb 2023 00:24:06 -0500
> Cc: luangruo@y= ahoo.com, 60= 703@debbugs.gnu.org
>
> Done. (git diff forked/emacs-29 > emacs-29-xwidget-patches.patch) >
> Let me know if there's anything I should do. Thanks!

Thanks, what is missing now is the commit log message.=C2=A0 Please see
CONTRIBUTE and the examples in the Git repository, for how we format
the log messages.

One minor comment to the code:

> +DEFUN ("xwidget-webkit-estimated-load-progress",
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0Fxwidget_webkit_estimated_load_progress, S= xwidget_webkit_estimated_load_progress,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A01, 1, 0, doc: /* Get the estimated load pr= ogress of XWIDGET, a WebKit widget.
> +Return a value ranging from 0.0 to 1.0, based on how close XWIDGET > +is to completely loading its page.=C2=A0 */)

The first line of a doc string should be a single complete sentence.
This is because commands like "M-x apropos" show only the first l= ine.

(Yes, I'm aware that you just moved existing code, but still: let's=
fix this while we are at that.)
--00000000000074573005f569fe21-- --00000000000074573105f569fe23 Content-Type: application/octet-stream; name="ChangeLog.andrewda" Content-Disposition: attachment; filename="ChangeLog.andrewda" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lehzoe5q0 MjAyMy0wMi0yMyAgQW5kcmV3IERlIEFuZ2VsaXMgIDxib2JvZGVhbmdlbGlzQGdtYWlsLmNvbT4K CUltcHJvdmVtZW50cyB0byB4d2lkZ2V0CgoJKiBzcmMvbnN4d2lkZ2V0Lm0gKCkKCShbWHdXZWJW aWV3IGluaXRXaXRoRnJhbWU6Y29uZmlndXJhdGlvbjp4d2lkZ2V0Ol0pCgkobnN4d2lkZ2V0X2lu aXQpOiAgRml4ZWQgbWVtb3J5IGxlYWtzOiB3aGVuIHNlbmRpbmcgYW4gYWxsb2MgbWVzc2FnZSB0 bwoJYW4gb2JqZWN0LCBzZW5kIGFuIGF1dG9yZWxlYXNlIG1lc3NhZ2UgdG8gYW55IG9iamVjdHMg d2Ugd29uJ3QKCWV4cGxpY3RseSByZWxlYXNlCgkoW1h3V2ViVmlldyB3ZWJWaWV3OmRpZEZpbmlz aE5hdmlnYXRpb246XSk6IFNlY29uZCBzdHJpbmcgdG8gc3RvcmUgaW4KCSdzdG9yZV94d2lkZ2V0 X2V2ZW50X3N0cmluZycgaXMgImxvYWQgZmluaXNoZWQiIHJhdGhlciB0aGFuIGVtcHR5IHN0cmlu ZwoJKFtYd1dlYlZpZXcgd2ViVmlldzpkaWRTdGFydFByb3Zpc2lvbmFsTmF2aWdhdGlvbjpdKQoJ KFtYd1dlYlZpZXcgd2ViVmlldzpkaWRSZWNlaXZlU2VydmVyUmVkaXJlY3RGb3JQcm92aXNpb25h bE5hdmlnYXRpb246XSkKCShbWHdXZWJWaWV3IHdlYlZpZXc6ZGlkQ29tbWl0TmF2aWdhdGlvbjpd KTogTmV3IGZ1bmN0aW9ucwoJKG5zeHdpZGdldF93ZWJraXRfZXN0aW1hdGVkX2xvYWRfcHJvZ3Jl c3MpOiBOZXcgZnVuY3Rpb24KCShuc3h3aWRnZXRfd2Via2l0X3N0b3BfbG9hZGluZyk6IE5ldyBm dW5jdGlvbgoJKiBzcmMveHdpZGdldC5jIChGeHdpZGdldF93ZWJraXRfZXN0aW1hdGVkX2xvYWRf cHJvZ3Jlc3MpOiBDYWxsCgknbnN4d2lkZ2V0X3dlYmtpdF9lc3RpbWF0ZWRfbG9hZF9wcm9ncmVz cycgaWYgd2UncmUgb24gTWFjT1MKCShGeHdpZGdldF93ZWJraXRfc3RvcF9sb2FkaW5nKTogQ2Fs bCAnbnN4d2lkZ2V0X3dlYmtpdF9zdG9wX2xvYWRpbmcnIGlmCgl3ZSdyZSBvbiBNYWNPUwoJKHN5 bXNfb2ZfeHdpZGdldCk6IERlZmluZSBzeW1ib2wgZm9yIGZ1bmN0aW9uCgkneHdpZGdldF93ZWJr aXRfZXN0aW1hdGVkX2xvYWRfcHJvZ3Jlc3MnIGlmIHdlJ3JlIG9uIE1hY09TCgkqIHNyYy9uc3h3 aWRnZXQuaDogc2lnbmF0dXJlIGZvciBmdW5jdGlvbnMKCSduc3h3aWRnZXRfd2Via2l0X2VzdGlt YXRlZF9sb2FkX3Byb2dyZXNzJyBhbmQKCSduc3h3aWRnZXRfd2Via2l0X3N0b3BfbG9hZGluZycK CSogbGlzcC94d2lkZ2V0LmVsICh4d2lkZ2V0LXdlYmtpdC1jdXJyZW50LXVybCk6IE1lc3NhZ2Ug VVJMIHJhdGhlciB0aGFuCglyZXR1cm4gdmFsdWUgb2YgJ2tpbGwtbmV3JyAod2hpY2ggaXMgYWx3 YXlzIG5pbCkK --00000000000074573105f569fe23--