From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew De Angelis Newsgroups: gmane.emacs.devel Subject: Re: Volunteering to help on etc/TODO item: Improved xwidgets support Date: Wed, 19 Oct 2022 00:55:52 -0400 Message-ID: References: <87k04wa97f.fsf@yahoo.com> <87bkq8a0ag.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000973a0305eb5c0631" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33337"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Qiantan Hong To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 19 12:54:09 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ol6i9-0008XK-Lq for ged-emacs-devel@m.gmane-mx.org; Wed, 19 Oct 2022 12:54:09 +0200 Original-Received: from localhost ([::1]:52404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ol6i7-0008S3-Rh for ged-emacs-devel@m.gmane-mx.org; Wed, 19 Oct 2022 06:54:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ol17f-0004dv-TJ for emacs-devel@gnu.org; Wed, 19 Oct 2022 00:56:07 -0400 Original-Received: from mail-vs1-xe34.google.com ([2607:f8b0:4864:20::e34]:36677) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ol17c-0003Qy-QM for emacs-devel@gnu.org; Wed, 19 Oct 2022 00:56:07 -0400 Original-Received: by mail-vs1-xe34.google.com with SMTP id x66so8026176vsb.3 for ; Tue, 18 Oct 2022 21:56:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=aynOUVbGf1lhDwGJwvoXQv1RHfkvY3eIY+TuszUTmeU=; b=jPShftZSCcFqh0HkQxf5Y7ta/ArYYnNMk4jCtanxgKIEEl7iLrA8Xrtmj4zkSd0ppZ o7jof2BBjEfvdM3gHrsH9S+sibV6bZkAkt+wSLMrxovxKD5zm42mUL+aTM3K/EalrOvJ sgLPP5SLUQTw1Xy3dS4K6Zr1aRPb/dXgpjfQJxECRtS30BgPOZsjn9IS7dvx1cw/DDqV LrXH5l0oqbM0D/0AXykVYw0u3jX7joNKwCEQwn14+WLxO+cDl8Toe4KvFwWQ2uGakTPW 8B7QPFftYzb8Sa+WCOx4fx2PF9pfJ7u+dkZ6FyyQJX14Mt62eLi5XWEgOE/iAsf1JY/q HW5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aynOUVbGf1lhDwGJwvoXQv1RHfkvY3eIY+TuszUTmeU=; b=ImA7XBs1ioJWyAqVqtJcAe+Cs5osL4Y67ZddU54mOtzw6yC/Vnaid/u8ePZ46MFbn1 tNdD6Gl0Npt1aE23f/4WmdafTFNXJmvGr/ja2gdGTab1PvZOc5Nvq42gzaaqSA/K1Eln ivKLcqxsRCDN5f+scv0vIHxuZaLgF0/95wJ1ZZNcsnfYKDyU9jXYMCiztwKnshSLhe8E RMpxApMUF51+an2SBXYT5aCdbLy9f9X1XUcSQjiQJQxVZGAV6U3r+HUhbtTLsefnUMVI tQWWVGJjDL3xUNS/j9wf6g1xLR5SlxvdzIGrZhn9+YB72m2qDnak5xaZBKh1P5Igcs7m 5Nag== X-Gm-Message-State: ACrzQf2+i0bVerCZxqQGbuLzYTDJfkyWoKycLg7RIQGa1wc1oNH1D+r8 a+FEj23TkJnOO+X7/dv6w6EskXQa9HdhjcDXhmY= X-Google-Smtp-Source: AMsMyM6gXWn2nGlJZ4gndr5+3zya28BxlZBjFZjIH+qp9oRKohJba0AHHKaeFQprLhpm3qKda5vs5KzJGf57yVXSvik= X-Received: by 2002:a05:6102:38c9:b0:3a9:7206:b99e with SMTP id k9-20020a05610238c900b003a97206b99emr3257037vst.65.1666155363644; Tue, 18 Oct 2022 21:56:03 -0700 (PDT) In-Reply-To: <87bkq8a0ag.fsf@yahoo.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::e34; envelope-from=bobodeangelis@gmail.com; helo=mail-vs1-xe34.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 19 Oct 2022 06:52:08 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:298109 Archived-At: --000000000000973a0305eb5c0631 Content-Type: text/plain; charset="UTF-8" > > It should never print "nil"; it's a command that is not supposed to be > called by Lisp or return anything. > Sorry, I misspoke: the issue is that it *prints* nil: if I have a widget open, and press 'w' or call `xwidget-webkit-current-url', the message I see in the minibuffer is always "URL: nil". This happens even though (xwidget-webkit-uri (xwidget-webkit-current- session)) does return the current url. Therefore, I think the problem is in how the function uses `kill-new'. On Wed, Oct 19, 2022 at 12:46 AM Po Lu wrote: > Andrew De Angelis writes: > > > Yeah, that's a tight deadline. I am going to try to fix the biggest > > issues by then, but we'll probably have to wait until the next release > > to have this included > > Thanks. > > > I think the timer stops by itself, the variable is not all that > > important. > > > > This is probably another NS-specific issue, but the timer doesn't > > always stop in my build. The issue starts in > > `xwidget-webkit-callback'; it looks like the "load-finished" event > > sometimes (most of the times) doesn't happen or is not received. I > > will add this to the list of things to fix. > > Yeah, that sounds like an NS specific bug. > > > One other possible Lisp bug: currently, `xwidget-webkit-current-url' > > always returns "URL: nil" for me. This shouldn't depend on other > > xwidget code: the issue is caused by the fact that `kill-new' doesn't > > return the string it just added to the kill-ring. (If it does work in > > your builds let me know, as I'd have to investigate what's causing > > such different behavior.) This is my fix for this: > > It should never print "nil"; it's a command that is not supposed to be > called by Lisp or return anything. > --000000000000973a0305eb5c0631 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
It shoul= d never print "nil"; it's a command that is not supposed to b= e
called by Lisp or return anything.
Sorry, I missp= oke: the issue is that it prints=C2=A0nil: if I have a widget open, = and press 'w' or call `xwidget-webkit-current-url', the message= I see in the minibuffer is always "URL: nil".=C2=A0
Th= is happens even though=C2=A0(xwidget-webkit-uri (xwidget-webkit-current-session))=C2=A0=C2=A0does return the cu= rrent url. Therefore, I think the problem is in how the function uses `kill= -new'.

On Wed, Oct 19, 2022 at 12:46 AM Po Lu <luangruo@yahoo.com> wrote:
Andrew De Angelis <bobodeangelis@gmail.com= > writes:

> Yeah, that's a tight deadline. I am going to try to fix the bigges= t
> issues by then, but we'll probably have to wait until the next rel= ease
> to have this included

Thanks.

>=C2=A0 I think the timer stops by itself, the variable is not all that<= br> >=C2=A0 important.
>
> This is probably another NS-specific issue, but the timer doesn't<= br> > always stop in my build. The issue starts in
> `xwidget-webkit-callback'; it looks like the "load-finished&q= uot; event
> sometimes (most of the times) doesn't happen or is not received. I=
> will add this to the list of things to fix.

Yeah, that sounds like an NS specific bug.

> One other possible Lisp bug: currently, `xwidget-webkit-current-url= 9;
> always returns "URL: nil" for me. This shouldn't depend = on other
> xwidget code: the issue is caused by the fact that `kill-new' does= n't
> return the string it just added to the kill-ring. (If it does work in<= br> > your builds let me know, as I'd have to investigate what's cau= sing
> such different behavior.)=C2=A0 This is my fix for this:

It should never print "nil"; it's a command that is not suppo= sed to be
called by Lisp or return anything.
--000000000000973a0305eb5c0631--