Thank you again for the feedback. Attached is the updated patch. @Po Lu , you were right about the dealloc method: I removed it since it was unnecessary. I think I fixed all the issues you pointed out, but let me know if there's any other changes needed. About the copyright assignment, I sent the attached email to assign@gnu.org ten days ago, but haven't gotten a reply yet. Just want to make sure I'm going about it the right way: do I need to do anything else to get this done? It's my first contribution so I may be missing something. On Tue, Jan 10, 2023 at 8:15 PM Po Lu wrote: > Eli Zaretskii writes: > > > I don't have an opinion, so if it's OK in your opinion, I'm fine with > > adding this. Are we sure this will not affect any important aspects > > of the build, except where we already have problems? (I don't see any > > description of the problems and their solution in the commit log or > > the comments.) > > Yes, these are fixes to a piece of code that is normally off by default, > and did not work prior to those changes. > > > I don't see copyright assignment for Andrew, so this should be settled > > before accepting the contribution of this magnitude. > > Right, thanks for bringing that up. >