From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew De Angelis Newsgroups: gmane.emacs.bugs Subject: bug#60703: Patches to xwidget code Date: Sat, 4 Mar 2023 18:00:03 -0500 Message-ID: References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> <83bkmsmk6g.fsf@gnu.org> <83fsc3lwtg.fsf@gnu.org> <87pmb024d7.fsf@yahoo.com> <83bklowobq.fsf@gnu.org> <838rgpsue3.fsf@gnu.org> <83fsane7yl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005d9c9505f61b0681" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4796"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 60703-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 05 00:01:33 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYasf-00014y-A0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Mar 2023 00:01:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYasG-0007H6-Qu; Sat, 04 Mar 2023 18:01:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYasB-0007Fj-3J for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 18:01:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYasA-0001Gx-JZ for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 18:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pYasA-0008AW-FS for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 18:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrew De Angelis Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Mar 2023 23:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60703 X-GNU-PR-Package: emacs Original-Received: via spool by 60703-done@debbugs.gnu.org id=D60703.167797082331322 (code D ref 60703); Sat, 04 Mar 2023 23:01:02 +0000 Original-Received: (at 60703-done) by debbugs.gnu.org; 4 Mar 2023 23:00:23 +0000 Original-Received: from localhost ([127.0.0.1]:37988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYarW-000898-R6 for submit@debbugs.gnu.org; Sat, 04 Mar 2023 18:00:23 -0500 Original-Received: from mail-ua1-f45.google.com ([209.85.222.45]:34655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYarU-00088h-EF for 60703-done@debbugs.gnu.org; Sat, 04 Mar 2023 18:00:21 -0500 Original-Received: by mail-ua1-f45.google.com with SMTP id p2so4089886uap.1 for <60703-done@debbugs.gnu.org>; Sat, 04 Mar 2023 15:00:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677970815; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+BrZl9ftj0aXq1nH39orxqGjIw8m0GP5lataLbgkuaw=; b=lq90WBmneiy927Ozk3hiCrY5ph6Nh18W/z38hkBNVjEf/zG+lRbxAFvEw25cLf3Dz3 9jBr2o1grxCjZkywbbGJnUtKJDERI2fvmBiL579Jnqp3URwf3OLm9sb2Sszihu2+zYvA 4YBLvNPW/SbxVd+muTG4RF2J1FwCUa7LbsP+V+cmg3r8gzm0Oe7qugC2fmDVpgdEwDm2 hngt22t4koBNsESUw/l8wu39vvA0euVXNAC0KoKkYYaOcbZDZ4vEwEtJR1ovJRIL4Tb7 SpjLNud68HDRTE2hzId6OQZ63lQe0uMyliDIv/cpeu90JmtzpzhFqHdsK0uUFp9Gp5Ul h6jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677970815; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+BrZl9ftj0aXq1nH39orxqGjIw8m0GP5lataLbgkuaw=; b=Xb3s/OP8GZAWSm7wrkGuDpTItfQe0buIov4k0Bs+seBDZ4PnmEzOKjZg2TGIXV1qH8 HXTljrpzuxcZsapwYYs7cbnXrtKh7uK6o5YvR+mHTYhQBr9dDEX8b2KpHBedaBRbgnI7 q6kgistq4Y8iTdC6sp0m9MBidIucfqeb/Odwg0H7rMOwjuqzKUe+kLTZxTEkoWQkJ+T3 +Y7ZmCGCtvkE/2GHXg9W4xadHLniE1MmNqEhR7YY9BmIQIR/RR7kJXhq12xsoPcsKbax PiRiH4SgD77fPMtYwvvUIgmZ8ATbIr7OImgYPls+NI8zIP7s+ktpSoC5B8abg/DLR6JY GTTw== X-Gm-Message-State: AO0yUKWHFLJKQRxgiFq4pfddhv3eWU6sfUFcNNcawcSaj6E2ETbWla9d YvuseCUePug5kluBETrEPhG3UVhiRHCSsLY3ASY= X-Google-Smtp-Source: AK7set9HKQc0TfniPlRPWXPzvxu7YKflyEppjMzORGE20ubUCd27BZXVzAgY9hQnG8LXAR6gBrKCB7nrn8DfiLeJzQI= X-Received: by 2002:a1f:1752:0:b0:401:f65:99c2 with SMTP id 79-20020a1f1752000000b004010f6599c2mr4180790vkx.3.1677970814900; Sat, 04 Mar 2023 15:00:14 -0800 (PST) In-Reply-To: <83fsane7yl.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257321 Archived-At: --0000000000005d9c9505f61b0681 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Awesome, thank you so much! Will keep all your suggestions in mind for my future contributions. Small question: what are the criteria to be added to `etc/AUTHORS`? Just wondering if/how my contribution could be mentioned there. On Thu, Mar 2, 2023 at 5:58=E2=80=AFAM Eli Zaretskii wrote: > > From: Andrew De Angelis > > Date: Thu, 23 Feb 2023 22:47:41 -0500 > > Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org > > > > Let me know if this ChangeLog is fine or you'd like me to make any > changes. > > Thanks, installed on the emacs-29 branch, and closing the bug. > > > The first line of a doc string should be a single complete sentence. > > > > I'm not sure I follow: in this case, isn't this the first line: "Get > the estimated load progress of XWIDGET, a > > WebKit widget."? It renders fine when I run `M-x apropos > xwidget-webkit-estimated-load-progress`. But > > happy to make any additional changes if needed. > > Please ignore that part: I was confused. > > Please in the future always accompany the changes with a > ChangeLog-style commit log message, and mention the bug number there > if you know it. Also, use of "git format-patch" is encouraged. These > measures make the job of installing your changes much easier. > --0000000000005d9c9505f61b0681 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Awesome, thank you so much! Will keep all your sugges= tions in mind for my future contributions.

Small q= uestion: what are the criteria to be added to `etc/AUTHORS`? Just wondering= if/how my contribution could be mentioned there.

On Thu, Mar 2, 2= 023 at 5:58=E2=80=AFAM Eli Zaretskii <el= iz@gnu.org> wrote:
> From: Andrew De Angelis <bobodeangelis@gmail.com>
> Date: Thu, 23 Feb 2023 22:47:41 -0500
> Cc: luangruo@y= ahoo.com, 60= 703@debbugs.gnu.org
>
> Let me know if this ChangeLog is fine or you'd like me to make any= changes.

Thanks, installed on the emacs-29 branch, and closing the bug.

>=C2=A0 The first line of a doc string should be a single complete sente= nce.
>
> I'm not sure I follow: in this case, isn't=C2=A0 this the firs= t line: "Get the estimated load progress of XWIDGET, a
> WebKit widget."? It renders fine when I run `M-x apropos xwidget-= webkit-estimated-load-progress`. But
> happy to make any additional changes if needed.

Please ignore that part: I was confused.

Please in the future always accompany the changes with a
ChangeLog-style commit log message, and mention the bug number there
if you know it.=C2=A0 Also, use of "git format-patch" is encourag= ed.=C2=A0 These
measures make the job of installing your changes much easier.
--0000000000005d9c9505f61b0681--