all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andrew De Angelis <bobodeangelis@gmail.com>
To: 74295@debbugs.gnu.org
Subject: bug#74295: Update TODO -> NeXTstep port -> Improved xwidgets support
Date: Sun, 10 Nov 2024 10:13:17 -0500	[thread overview]
Message-ID: <CAP5CrM0disoeKu+27u5b_ES2U2tVV97h8d+yjQw_mnUmzcdw6A@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 861 bytes --]

Hello everyone.

I have a question and a possible patch to contribute.
For context: the most glaring issues with xwidget support of NS have been
fixed: I contributed a patch to get rid of memory leaks a while ago, under:
"bug#60703 Patches to xwidget code".

I've just noticed that I forgot to update the TODO file, so it still
mentions crashes:
> trying to display a xwidget in the "killed" state will make Emacs crash.

I've used the xwidget feature extensively and in my experience, xwidgets do
not crash Emacs anymore.

Question:
 - Could someone clarify what we mean by displaying a xwidget in the
"killed" state? I want to make sure I understand the problem and it's fixed

Possible patch (if the problem is indeed fixed):
Attached. Remove the mention of crashes, and clarify which features are
still missing from the NS port.


Thanks for all your work!

[-- Attachment #1.2: Type: text/html, Size: 1142 bytes --]

[-- Attachment #2: update-todo-for-xwidget-ns.patch --]
[-- Type: application/octet-stream, Size: 1011 bytes --]

diff --git a/etc/TODO b/etc/TODO
index f9918fede38..fa19d9f96d9 100644
--- a/etc/TODO
+++ b/etc/TODO
@@ -955,13 +955,13 @@ This sections contains features found in other official Emacs ports.
 Emacs 25 has support for xwidgets, a system to include WebKit widgets
 into an Emacs buffer.
 
-They work on NS, but not very well.  For example, trying to display a
-xwidget in the "killed" state will make Emacs crash.  This is because
-the NS code has not been updated to keep with recent changes to the
-X11 and GTK code.
+They work on NS, but not very well.  This is because the NS code has
+not been updated to keep with recent changes to the X11 and GTK code.
 
-Many features such as xwidget-webkit-edit-mode do not work correctly
-on NS either.
+Many features do not work correctly on NS, such as:
+ - xwidget-webkit-edit-mode
+ - xwidget-webkit-isearch-mode
+ - xwidget-webkit-browse-history.
 
 **** Respect 'frame-inhibit-implied-resize'
 When the variable 'frame-inhibit-implied-resize' is non-nil, frames

             reply	other threads:[~2024-11-10 15:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-10 15:13 Andrew De Angelis [this message]
2024-11-14  8:22 ` bug#74295: Update TODO -> NeXTstep port -> Improved xwidgets support Eli Zaretskii
2024-11-30  9:46   ` Eli Zaretskii
2024-12-14  9:32     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP5CrM0disoeKu+27u5b_ES2U2tVV97h8d+yjQw_mnUmzcdw6A@mail.gmail.com \
    --to=bobodeangelis@gmail.com \
    --cc=74295@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.