From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chris Feng Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/xelb 0330657: Fix the reply/error sequence number overflow issue Date: Fri, 6 Nov 2015 13:45:07 +0800 Message-ID: References: <20151105070219.26719.57321@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1446788731 28024 80.91.229.3 (6 Nov 2015 05:45:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 6 Nov 2015 05:45:31 +0000 (UTC) Cc: emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 06 06:45:23 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZuZpz-0007Bj-1L for ged-emacs-devel@m.gmane.org; Fri, 06 Nov 2015 06:45:23 +0100 Original-Received: from localhost ([::1]:36728 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuZpy-0002Yl-EE for ged-emacs-devel@m.gmane.org; Fri, 06 Nov 2015 00:45:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuZpl-0002WM-4E for emacs-devel@gnu.org; Fri, 06 Nov 2015 00:45:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuZpk-0000t0-Bg for emacs-devel@gnu.org; Fri, 06 Nov 2015 00:45:09 -0500 Original-Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:34688) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuZpk-0000sX-6n for emacs-devel@gnu.org; Fri, 06 Nov 2015 00:45:08 -0500 Original-Received: by wikq8 with SMTP id q8so23561200wik.1 for ; Thu, 05 Nov 2015 21:45:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=n0aXf977lMNinxLdcfM6XNl4YAB5ZK8lZ55CQhDpHco=; b=GroV0RdLp38mLxtZHgAwVVHVcFpVdoleJq3OfRtH6FqW1SURDPa3e9cDATWaszNLco s7/VUC2YIe0OZTohbQ3ECm7KzHulzaNJedi8S2UlTMJ3iUJXaKjrqPcTMS03iF8gzQSY vLqrqtPTQxGPScR9mx9ocW3d0LY5dsGLko0mvlEHKdyXE7+EqbmYv8gcRzder0PVf5cy PxzagNQiRIw4Uprdz/Z5DyaJ/e7igidQ2PF0hbURJ/6fIf22oT0ON3gZvBiajQXnBn3W 75OlM88DoVm8FSvjSeNW7lxaHimF0mB2dfb5XaWqJ+fl5RcyxPKB5gCvgewpeEamZGvr 3/qQ== X-Received: by 10.194.205.130 with SMTP id lg2mr12628635wjc.9.1446788707121; Thu, 05 Nov 2015 21:45:07 -0800 (PST) Original-Received: by 10.194.87.136 with HTTP; Thu, 5 Nov 2015 21:45:07 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193375 Archived-At: >> + (if (< #x7FFF (abs (- sequence1 sequence2))) >> + ;; Overflowed >> + (if (< sequence1 sequence2) 1 -1) >> + (if (> sequence1 sequence2) 1 -1)))) > > Aka > > (if (if (< #x7FFF (abs (- sequence1 sequence2))) > ;; Overflowed > (< sequence1 sequence2) > (> sequence1 sequence2)) > 1 -1)))) > > Or even > > (if (funcall (if (< #x7FFF (abs (- sequence1 sequence2))) #'< #'>) > sequence1 sequence2) > 1 -1)))) > > > -- Stefan "in redundancy-killing-mode" Thanks, Stefan. I've made the function return the difference of sequence numbers instead, which should be cleaner.