all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chris Feng <chris.w.feng@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [elpa] externals/xelb 0330657: Fix the reply/error sequence number overflow issue
Date: Fri, 6 Nov 2015 13:45:07 +0800	[thread overview]
Message-ID: <CAP4=87HiVJ_5jqxphtcBB3F+ETTXX17cxKNtggsAvP7MMLmTjQ@mail.gmail.com> (raw)
In-Reply-To: <jwvh9l0ikii.fsf-monnier+emacsdiffs@gnu.org>

>> +    (if (< #x7FFF (abs (- sequence1 sequence2)))
>> +        ;; Overflowed
>> +        (if (< sequence1 sequence2) 1 -1)
>> +      (if (> sequence1 sequence2) 1 -1))))
>
> Aka
>
>        (if (if (< #x7FFF (abs (- sequence1 sequence2)))
>                ;; Overflowed
>                (< sequence1 sequence2)
>              (> sequence1 sequence2))
>            1 -1))))
>
> Or even
>
>        (if (funcall (if (< #x7FFF (abs (- sequence1 sequence2))) #'< #'>)
>                     sequence1 sequence2)
>            1 -1))))
>
>
> -- Stefan "in redundancy-killing-mode"

Thanks, Stefan.  I've made the function return the difference of
sequence numbers instead, which should be cleaner.



      reply	other threads:[~2015-11-06  5:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20151105070219.26719.57321@vcs.savannah.gnu.org>
     [not found] ` <E1ZuEYu-00070O-SO@vcs.savannah.gnu.org>
2015-11-05 14:35   ` [elpa] externals/xelb 0330657: Fix the reply/error sequence number overflow issue Stefan Monnier
2015-11-06  5:45     ` Chris Feng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP4=87HiVJ_5jqxphtcBB3F+ETTXX17cxKNtggsAvP7MMLmTjQ@mail.gmail.com' \
    --to=chris.w.feng@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.