From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chris Feng Newsgroups: gmane.emacs.bugs Subject: bug#22817: Fwd: bug#22817: 25.0.91; [PATCH] Include versioned preloaded libraries in `package--builtin-versions' Date: Tue, 12 Jul 2016 22:28:23 +0800 Message-ID: References: <86r3fzy7ea.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1468333771 31744 80.91.229.3 (12 Jul 2016 14:29:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Jul 2016 14:29:31 +0000 (UTC) To: 22817@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 12 16:29:22 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bMygc-0007Mg-DR for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jul 2016 16:29:22 +0200 Original-Received: from localhost ([::1]:40853 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMygb-0002Tg-Px for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jul 2016 10:29:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMygS-0002Ta-D9 for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 10:29:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMygL-000195-Ky for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 10:29:11 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMygL-00017O-GZ for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 10:29:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bMygH-0004yH-Np for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 10:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chris Feng Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2016 14:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22817 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22817-submit@debbugs.gnu.org id=B22817.146833372319078 (code B ref 22817); Tue, 12 Jul 2016 14:29:01 +0000 Original-Received: (at 22817) by debbugs.gnu.org; 12 Jul 2016 14:28:43 +0000 Original-Received: from localhost ([127.0.0.1]:48466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMyft-0004xZ-50 for submit@debbugs.gnu.org; Tue, 12 Jul 2016 10:28:43 -0400 Original-Received: from mail-wm0-f49.google.com ([74.125.82.49]:37507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMyfm-0004xF-C5 for 22817@debbugs.gnu.org; Tue, 12 Jul 2016 10:28:36 -0400 Original-Received: by mail-wm0-f49.google.com with SMTP id i5so27769952wmg.0 for <22817@debbugs.gnu.org>; Tue, 12 Jul 2016 07:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=a+YMJr+l+TxH/N/0ekPJ1fmfjODBh5VvSARPfDYtfC0=; b=tpcvfQjWThsa6hSFyaza1jH94NlrceIPtIgCo/aSx/ZcsSxSRjKVJPK2c4PR8/cq/S cc2XoJY6Ten49M2/G/UQ+nzuRpirmDFSQU7t6EgEjUaB9doJmAsW4VtdNn8qnFtIiAEl tiogdbpV5jhN3marBNTmzXg8k6BLBq7wxIQPhvVTA+/xDnItlMpwspzlCJNsJg+esm1f Jmr+R4vrkRSxOit8TaaNOXWnkef1j1UYPcs/j0HK3j+FDsWJs6O/HWYqlMZRzqXO+2qO /N5/SyQvQ45sZvkYhxJb90Fr2v16EY9MxCUE3kT+B2gwzM09u+mCuceRV7ehoVYzz7dB jRQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=a+YMJr+l+TxH/N/0ekPJ1fmfjODBh5VvSARPfDYtfC0=; b=YlL8vjiFg9L533ECbMyWFpYQ0e8CvGnkAmFFRdKTmachMu3xSNH1HAqN+iFCk6CvN4 0XS0Smff0eAHEDA75hx8KqYM2qO2y5QYq+ssI7hXLM5fz+05tCT57Vw/7OZcsWqQ+JL+ hAv/UpXGiGs58Mh7ZIr06cuzl9zW2YnHY3iUmvzFmBI+gew54wS8GA6nm5UNFkAAW1rZ RqwQl6AW33EPF6fXA2Jn4hSfvYW7LslY2O3D8DqKIYCt54H7jkJlGhHwSK7YkNN1YG1g 3vHtvVAFeWRK89iPAWtKBkXoB/aq8oljsu7L4jv3Ap8Gst65HYgQbv696Y3WAQegAk94 RWXg== X-Gm-Message-State: ALyK8tJxap+l0bXPDIP28Jy23/sn1FDt2I/sNN45oWTXTflCEZbP//k6d9Vig+si1sj5KhqBs1YRqjoXsCDBDw== X-Received: by 10.28.199.205 with SMTP id x196mr3743747wmf.96.1468333703535; Tue, 12 Jul 2016 07:28:23 -0700 (PDT) Original-Received: by 10.194.97.20 with HTTP; Tue, 12 Jul 2016 07:28:23 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120912 Archived-At: >> Also, since `package--builtin-versions' is now complete, should we remove the >> version info in `package--builtins'? > > Not sure what you mean nor what would be the benefit. I just noticed you wrote this in finder.el: ;; FIXME: Now that we have package--builtin-versions, package--builtins is ;; only needed to get the list of unversioned packages and to get the ;; summary description of each package. >> I forgot to mention that the bug can be reproduced by installing a >> package having a preloaded lib as a dependency, e.g.: >> >> M-x package-install RET xelb RET >> >> Then cl-generic 0.2 will get installed. > > A more direct way is to check (assq 'cl-generic package--builtin-versions) > which should not return nil (but does :-( ). > > I haven't looked in detail at your patch, but it'd be good to do > something along these lines. > > It's probably too late to use your approach for emacs-25, but I think we > need to install some fix for this problem in emacs-25, since otherwise > Emacs-25.1 will end up insisting on installing cl-generic from GNU ELPA > every occasion it gets. > > How 'bout you install your patch into master and we install the patch > below into emacs-25? That'd be okay. Chris