From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chris Feng Newsgroups: gmane.emacs.bugs Subject: bug#22787: [PATCH] Allocate glyph matrices for the initial frame Date: Thu, 25 Feb 2016 09:38:58 +0800 Message-ID: References: <8337sihvfm.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1456364421 20430 80.91.229.3 (25 Feb 2016 01:40:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 25 Feb 2016 01:40:21 +0000 (UTC) Cc: 22787@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 25 02:40:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aYkuY-0007F8-UD for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Feb 2016 02:40:11 +0100 Original-Received: from localhost ([::1]:39465 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYkuY-0003ep-9w for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Feb 2016 20:40:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYkuU-0003cs-2g for bug-gnu-emacs@gnu.org; Wed, 24 Feb 2016 20:40:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYkuQ-0006zp-3A for bug-gnu-emacs@gnu.org; Wed, 24 Feb 2016 20:40:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYkuQ-0006zg-0L for bug-gnu-emacs@gnu.org; Wed, 24 Feb 2016 20:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aYkuP-00070c-OJ for bug-gnu-emacs@gnu.org; Wed, 24 Feb 2016 20:40:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Chris Feng Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Feb 2016 01:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22787 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22787-submit@debbugs.gnu.org id=B22787.145636434526874 (code B ref 22787); Thu, 25 Feb 2016 01:40:01 +0000 Original-Received: (at 22787) by debbugs.gnu.org; 25 Feb 2016 01:39:05 +0000 Original-Received: from localhost ([127.0.0.1]:44471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYktU-0006zO-SE for submit@debbugs.gnu.org; Wed, 24 Feb 2016 20:39:05 -0500 Original-Received: from mail-wm0-f53.google.com ([74.125.82.53]:37506) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYktT-0006ys-L5 for 22787@debbugs.gnu.org; Wed, 24 Feb 2016 20:39:03 -0500 Original-Received: by mail-wm0-f53.google.com with SMTP id g62so7370463wme.0 for <22787@debbugs.gnu.org>; Wed, 24 Feb 2016 17:39:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=lD0rAtIoJaQcvrAqZXROxFpO9+Y0Y1m9GPXJ9pomago=; b=SwGsgbIIXNm66QT6eq/Ckimomq3BjWcv14xnKgXTjO5uvqhFgoCJvOfGjdQGlURVLB wA1h3Q8AhiSBDXc6HbMgL2h8ifmhwR2Gg+TWdI9/7nVJvXReFr96JLUh/GZgt2+fob+a 2V6Q011uGJpZ8gSzurrxMDnTU+orXgkqmMhFHLAkjRBfjTmmQMDreU/oCMEwyIeex3rs NLzFadFstRaDILEw9pXqIEfYnArPg3q2uIRYUB84k7+puj6j20JfMBWXYkXBYQQx9WzN aZDtj8iu+d4ISITkAP5vygf+y6ZJhPqsHdK4wFnnbpIgkS59tRYFjsLAh/SV7xt/L0ti NcTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=lD0rAtIoJaQcvrAqZXROxFpO9+Y0Y1m9GPXJ9pomago=; b=ij5LwC+toRgNPKiE/XEd8jYoBMrLsjdfzenDk4gHPpWAys9RwnMGzhYEnLCzn4SD+t sJXNHws8CGpMN2eVVI/QtNZEclHXMf7wKd7ZuXHtOeK61OA58q07y0M2fKtOZN/zjR+X UJDpOesGTPAkqrRsx7kPC4vVHWM9EDr4sfZm+iP6gyAHT+mXnKad21vn+VuDQJF+WYFv fBJs7Yb+XFeWX52OqB4cSzkHZ+UIDbcegRScpftXvRgAnIGUPqrk0azFRYyuT02XrWAT Z5aXJtbRTj3/SwbjMkjXr5tMvnxUQDxGb975Z9WPME6j6ZTLYZdBScptQIdQvUkOxiN8 4IaQ== X-Gm-Message-State: AG10YOR4WyCLfm68nDQXZfgW7+IRXY3eO+UQgCJy8B3XYNAXmBgXMPKbtb+XDiKfiKGeRjFzWzizBM43n3zhCg== X-Received: by 10.28.102.68 with SMTP id a65mr581346wmc.12.1456364338060; Wed, 24 Feb 2016 17:38:58 -0800 (PST) Original-Received: by 10.194.190.104 with HTTP; Wed, 24 Feb 2016 17:38:58 -0800 (PST) In-Reply-To: <8337sihvfm.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113764 Archived-At: >> After bd4de70f the initial frame is created without the glyph matrices >> allocated. As a result Emacs in batch/daemon mode would crash when evaluating >> certain functions (e.g. line-pixel-height, window-text-pixel-size). > > Thanks, but can you explain this part: > >> clear_glyph_matrix_rows (struct glyph_matrix *matrix, int start, int end) >> { >> eassert (start <= end); >> - eassert (start >= 0 && start < matrix->nrows); >> + eassert (start >= 0 && start <= matrix->nrows); > > If this is for the case that both start and matrix->nrows are zero, > please test that case separately. Thanks. I've just pushed a commit to fix this.