From: Chris Feng <chris.w.feng@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 22787@debbugs.gnu.org
Subject: bug#22787: [PATCH] Allocate glyph matrices for the initial frame
Date: Thu, 25 Feb 2016 09:38:58 +0800 [thread overview]
Message-ID: <CAP4=87FgCbFKSBS-EwZC=eO02GtDPNE29FBPJ4KT6d5i8ptTQA@mail.gmail.com> (raw)
In-Reply-To: <8337sihvfm.fsf@gnu.org>
>> After bd4de70f the initial frame is created without the glyph matrices
>> allocated. As a result Emacs in batch/daemon mode would crash when evaluating
>> certain functions (e.g. line-pixel-height, window-text-pixel-size).
>
> Thanks, but can you explain this part:
>
>> clear_glyph_matrix_rows (struct glyph_matrix *matrix, int start, int end)
>> {
>> eassert (start <= end);
>> - eassert (start >= 0 && start < matrix->nrows);
>> + eassert (start >= 0 && start <= matrix->nrows);
>
> If this is for the case that both start and matrix->nrows are zero,
> please test that case separately.
Thanks. I've just pushed a commit to fix this.
prev parent reply other threads:[~2016-02-25 1:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 6:32 bug#22787: [PATCH] Allocate glyph matrices for the initial frame Chris Feng
2016-02-24 8:04 ` martin rudalics
2016-02-24 17:25 ` Eli Zaretskii
2016-02-25 1:38 ` Chris Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP4=87FgCbFKSBS-EwZC=eO02GtDPNE29FBPJ4KT6d5i8ptTQA@mail.gmail.com' \
--to=chris.w.feng@gmail.com \
--cc=22787@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.