From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: "unescaped character literals detected" Date: Fri, 05 May 2017 20:04:15 +0000 Message-ID: References: <834lx0hekg.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c0b9ba277b2b1054ecc6574 X-Trace: blaine.gmane.org 1494014722 15316 195.159.176.226 (5 May 2017 20:05:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 5 May 2017 20:05:22 +0000 (UTC) To: Kaushal Modi , Eli Zaretskii , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 05 22:05:17 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6jTW-0003re-S7 for ged-emacs-devel@m.gmane.org; Fri, 05 May 2017 22:05:15 +0200 Original-Received: from localhost ([::1]:48785 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6jTc-0007qP-G2 for ged-emacs-devel@m.gmane.org; Fri, 05 May 2017 16:05:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6jSm-0007q2-9U for emacs-devel@gnu.org; Fri, 05 May 2017 16:04:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6jSl-0007IT-17 for emacs-devel@gnu.org; Fri, 05 May 2017 16:04:28 -0400 Original-Received: from mail-qk0-x235.google.com ([2607:f8b0:400d:c09::235]:33368) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d6jSk-0007HW-Sn for emacs-devel@gnu.org; Fri, 05 May 2017 16:04:26 -0400 Original-Received: by mail-qk0-x235.google.com with SMTP id n4so14522097qkc.0 for ; Fri, 05 May 2017 13:04:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=6HJY+J0lRYFS6LIC2E0uhb4xj68F1zYc/vE5K6jYCKE=; b=k4Nvw5D0F1AJw54X213tp7WzQY/ic8e1FEGRh/BXAHLZ7K5oXoThd4NyaU6EhldezI TDIqViGtZ2q9Y60ND8x9xTs5Zn6OjoZzdnyCcwqpQUlVQrz8naBB8K4mdMJ5qzus7Gjq tFikvADs4+LYRmDoaI4lGOfq26ZDiNvxcmCsN7bQlnpexu1leOBzmmMO68QORPiJ/PYH RkGtzw+GJFRYCgIS+5XeHKqXIdnJgu44ZxF/6yb0tdIImk5cDXLpz0WoEzeRhyM4qvxq imPv0x7TmHxYg0ROuJ8MMsz2DtTYCXTFjhy2bZLDx2pfubd+q7oFmLCtdnxAlAF9tLXS dD1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=6HJY+J0lRYFS6LIC2E0uhb4xj68F1zYc/vE5K6jYCKE=; b=jrSaJwnNv0jvvHqqsyjzLmkpvOiTllE1rvf5DwARyS4E1cwC1OHhy4QYNVg2HlgR2U KKwZs23Z9V33qBvq8s4+2ZwKS35JZ7CmRlX9NFIBLriU8gMY/ok9ha7/4HMW0ANI01kh iS12sxgLAJ23qnnn4sl6LGI2zlLExaiShbjz16nZ3pyrqIocN8JGDo+SlcZ8H3JrHpnH Exv5Ajz5GNJ2xWjTLb9JGzZH4U02KUdrBXnT2GSHnt/Zsgj4T6K/VkauBkegLkzBjSt8 171Qj+7OO1PQmCarxHoFsChCof0ULdUCRethhuskDzG+kOYNM6ttg2dFXq6t25v7D/1g 1g0g== X-Gm-Message-State: AODbwcCkDLa7k+lkBAb2s9SrqcJCIO4kDqIV5f1qD2BfboUiOIT5IYk5 9AxZNgq+VmlkXXaXkRAlbSuSKlZjLT/R X-Received: by 10.55.8.2 with SMTP id 2mr14014924qki.269.1494014666151; Fri, 05 May 2017 13:04:26 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214586 Archived-At: --94eb2c0b9ba277b2b1054ecc6574 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Kaushal Modi schrieb am Fr., 5. Mai 2017, 21:49: > On Thu, May 4, 2017 at 10:39 AM Eli Zaretskii wrote: > >> Compiling the Lisp files in the current master produces quite a few of >> these new warnings, see below. I hope someone is looking into >> eliminating them, otherwise we introduced a safety feature that does >> nothing except annoying us. >> >> Also, there seem to be several instances of the same warning, only one >> of which points out the line number where the problem happens. Is it >> possible to output only that final warning? The rest of them, those >> without a line number, are useless, as there's no practical way of >> finding the offending code unless you know exactly what to look for >> (and the wording isn't specific enough to allow the latter). >> > > +1 > > Now when I load verilog-mode.el (autoloaded when I open the SystemVerilog > files), I get: > > Loading =E2=80=98verilog-mode=E2=80=99: unescaped character literals ; de= tected! > > verilog-mode.el has 14.5k lines. It would be very helpful to print the > line number where unescapted character literals are detected so that I ca= n > attempt to fix it. > > Thanks. > > PS: This was added in > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3Dc2bbdc3316487e34e= ba1470dd059c0c290431e00, > so copying Philipp. > Yes, I'll fix all those over the weekend. Generally you can mechanically replace ?( with ?\( etc. Kaushal Modi > --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Matthew Scott Sucherman, Paul Terence Manicle Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und l=C3=B6schen Sie die E-Mail und alle Anh=C3=A4nge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks. --94eb2c0b9ba277b2b1054ecc6574 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Kaushal Modi <kaushal.modi@gmail.com> schrieb = am Fr., 5. Mai 2017, 21:49:
On Thu, May 4, 2017 a= t 10:39 AM Eli Zaretskii <eliz@gnu.org> wrote:
Com= piling the Lisp files in the current master produces quite a few of
these new warnings, see below.=C2=A0 I hope someone is looking into
eliminating them, otherwise we introduced a safety feature that does
nothing except annoying us.

Also, there seem to be several instances of the same warning, only one
of which points out the line number where the problem happens.=C2=A0 Is it<= br> possible to output only that final warning?=C2=A0 The rest of them, those without a line number, are useless, as there's no practical way of
finding the offending code unless you know exactly what to look for
(and the wording isn't specific enough to allow the latter).

+1

Now when I load veril= og-mode.el (autoloaded when I open the SystemVerilog files), I get:

Loading =E2=80=98verilog-mode=E2=80=99: unescaped charact= er literals ; detected!=C2=A0

verilog-mode.el has = 14.5k lines. It would be very helpful to print the line number where unesca= pted character literals are detected so that I can attempt to fix it.
=

Thanks.


=

Yes, I'll fix all those over the weekend. Gen= erally you can mechanically replace ?( with ?\( etc.

Kaushal Modi

--

Google Germany GmbH
Erika-Mann-Stra=C3=9Fe 33
80636 M=C3=BCnchen

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Gesch=C3=A4ftsf=C3=BChrer: Matthew Scott Sucherman, Paul Terence Manicle

Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Ad= ressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absen= der und l=C3=B6schen Sie die E-Mail und alle Anh=C3=A4nge. Vielen Dank.

This e-mail is confidential. If you are not the right addres= see please do not forward it, please inform the sender, and please erase th= is e-mail including any attachments. Thanks.

--94eb2c0b9ba277b2b1054ecc6574--