From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 d4e1549: Guard terminal parameter in XTerm mouse mode Date: Thu, 24 Nov 2016 08:58:28 +0000 Message-ID: References: <20161122204222.29398.86534@vcs.savannah.gnu.org> <20161122204222.DBE712201C5@vcs.savannah.gnu.org> <83bmx66vkg.fsf@gnu.org> <83r3625cwc.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a114036902386c005420836ef X-Trace: blaine.gmane.org 1479977942 5972 195.159.176.226 (24 Nov 2016 08:59:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 24 Nov 2016 08:59:02 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 24 09:58:54 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9prl-0008FS-4C for ged-emacs-devel@m.gmane.org; Thu, 24 Nov 2016 09:58:49 +0100 Original-Received: from localhost ([::1]:38649 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9pro-0005ab-DG for ged-emacs-devel@m.gmane.org; Thu, 24 Nov 2016 03:58:52 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9pre-0005aW-Ho for emacs-devel@gnu.org; Thu, 24 Nov 2016 03:58:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9prd-0001Ht-Cg for emacs-devel@gnu.org; Thu, 24 Nov 2016 03:58:42 -0500 Original-Received: from mail-lf0-x229.google.com ([2a00:1450:4010:c07::229]:34192) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c9prd-0001H9-05 for emacs-devel@gnu.org; Thu, 24 Nov 2016 03:58:41 -0500 Original-Received: by mail-lf0-x229.google.com with SMTP id o141so23276457lff.1 for ; Thu, 24 Nov 2016 00:58:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9m2peERYLN3nCv3wC3pZHLDploYRjIBhd3tFwdpw0eg=; b=Vq/LXli/MgRrg0PNOPv3tT16wL6rVVkR5FC82VtD7qEk5rpmFI/NRtsRv3EVXFoU3c rp1s+iaWgHVYErS3kGfHhTrFRF7sh1tmnObzYDaqPBb78b2EhbXgn4Yi1bLgiZANccSm Kqpf01i7xu8VN3mOarg8PshDPfXtBxC+1dYUfFkBr3SbgKuz16T6k0i/jZ+gsEm2L8kR zwqTrnT6x/N1ggZK2FHMuGkrO7pMQCPWakUTJq3nWqOXZMxwanc6fEzZBMYoAx7OEP4F jfBVrfW3fJ94uFsxTzLB4bPxflZHA/DHC6jbfC3lawrJsd3ElIz+kDxWXZETjVrDMPlJ sDdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9m2peERYLN3nCv3wC3pZHLDploYRjIBhd3tFwdpw0eg=; b=jcuDrwSFsak4y94duOIhss2+ZoDpkyh4Kz0zhv8B/2utXEY+aOPBera1xfVQM8ELrL 0mlACW2dL56NTA2oWzm++WAPi7y9cstN3X7JwMKO25gl/mz11w5GKkNfVQy3uvMDMNKL XflOdC8t7u4hGo6uGUYCMjrJZ1BRCThYI5OnQEwRffnubmdnY9p9Bijq1cXFM/03YS4t B04XeIUKG2uU+8WqyOA5PDAS1v1Ud3T8J83ecJ5hhk8yz3wMjaU/QsHIxGtsuAHOq2j/ 0a1jUmfiK3IlAPO7Pe8qZksLJnnisA3eI3iWW2VF9IUsSfmFqWJ5Z0EO/Gk/u/LFbooz 6wzg== X-Gm-Message-State: AKaTC02A5JAo1JMEs5uQK2KBLnd7kZIVQiiKtWDlscTMOSyXRkuVVeh5eq9B2YW6IdiJxeGGiDHxvM6H6UEOmPYJ X-Received: by 10.25.31.136 with SMTP id f130mr503245lff.135.1479977918991; Thu, 24 Nov 2016 00:58:38 -0800 (PST) In-Reply-To: <83r3625cwc.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209575 Archived-At: --001a114036902386c005420836ef Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii schrieb am Mi., 23. Nov. 2016 um 18:23 Uhr: > > From: Philipp Stephani > > Date: Wed, 23 Nov 2016 17:09:30 +0000 > > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org > > > > Does this have to be applied to the release branch? If so, can you > > tell why? > > > > It's a very annoying and highly visible bug, and the fix is trivial and > cannot possibly break anything. > > It wasn't reported until now, was it? So I guess it's only visible > under some conditions that don't happen very often. > It happens always when selecting text with the mouse in HTerm, I think that happens very often. Perhaps people just ignore the error message most of the time. > > Can you tell since when do we have this bug? If it exists long > enough, I don't think we should do this on the release branch, it goes > against the criteria for bug fixes there. > What are the criteria? CONTRIBUTE states "Release branches [=E2=80=A6] are mainly intended for more-conservative changes such as bug fixes. [=E2=80=A6] If you are fixing a bug that exists in the current release, be sure to commit it to the release branch; [=E2=80=A6]" For me this makes it clear that bug fixes are always appropriate on the release branches. If the actual policy is different, please document it in CONTRIBUTE. I've seen some talk about bugfix-only releases, but I think the policy should be clearer and better documented to avoid such discussions. --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Matthew Scott Sucherman, Paul Terence Manicle Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und l=C3=B6schen Sie die E-Mail und alle Anh=C3=A4nge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks. --001a114036902386c005420836ef Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Mi., 23. Nov. 2016 um 18:23=C2=A0Uhr:
> From: Philipp Stephani <phst@google.com>
> Date: Wed, 23 Nov 2016 17:09:30 +0000
> Cc: monnier@iro.umontreal.ca, emacs-devel@g= nu.org
>
>=C2=A0 Does this have to be applied to the release branch? If so, can y= ou
>=C2=A0 tell why?
>
> It's a very annoying and highly visible bug, and the fix is trivia= l and cannot possibly break anything.

It wasn't reported until now, was it?=C2=A0 So I guess it's only vi= sible
under some conditions that don't happen very often.

It happens always when selecting text = with the mouse in HTerm, I think that happens very often. Perhaps people ju= st ignore the error message most of the time.
=C2=A0

Can you tell since when do we have this bug?=C2=A0 If it exists long
enough, I don't think we should do this on the release branch, it goes<= br class=3D"gmail_msg"> against the criteria for bug fixes there.

What are the criteria? CONTRIBUTE states
&= quot;Release branches [=E2=80=A6] are mainly
intended for more-co= nservative changes such as bug fixes. [=E2=80=A6]
If you are fixi= ng a bug that exists in the current release, be sure to
commit it= to the release branch; [=E2=80=A6]"
For me this makes it cl= ear that bug fixes are always appropriate on the release branches. If the a= ctual policy is different, please document it in CONTRIBUTE.
I= 9;ve seen some talk about bugfix-only releases, but I think the policy shou= ld be clearer and better documented to avoid such discussions.
<= /div>
--
=

Google Germany GmbH
Erika-Mann-Stra=C3=9Fe 33
80636 M=C3=BCnchen

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Gesch=C3=A4ftsf=C3=BChrer: Matthew Scott Sucherman, Paul Terence Manicle

Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Ad= ressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absen= der und l=C3=B6schen Sie die E-Mail und alle Anh=C3=A4nge. Vielen Dank.

This e-mail is confidential. If you are not the right addres= see please do not forward it, please inform the sender, and please erase th= is e-mail including any attachments. Thanks.

--001a114036902386c005420836ef--