From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#23101: Date: Thu, 24 Mar 2016 18:37:34 +0000 Message-ID: References: <83wpor21hu.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e01182fd8f8b417052ecfbd15 X-Trace: ger.gmane.org 1458844703 19091 80.91.229.3 (24 Mar 2016 18:38:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Mar 2016 18:38:23 +0000 (UTC) Cc: 23101@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 24 19:38:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ajA97-0002Ak-Tg for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Mar 2016 19:38:14 +0100 Original-Received: from localhost ([::1]:52268 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajA93-0007w9-Lu for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Mar 2016 14:38:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajA8z-0007un-KV for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2016 14:38:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ajA8w-0005kF-Ed for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2016 14:38:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajA8w-0005kB-Bu for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2016 14:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ajA8w-0007HA-76 for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2016 14:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Mar 2016 18:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23101-submit@debbugs.gnu.org id=B23101.145884467227953 (code B ref 23101); Thu, 24 Mar 2016 18:38:02 +0000 Original-Received: (at 23101) by debbugs.gnu.org; 24 Mar 2016 18:37:52 +0000 Original-Received: from localhost ([127.0.0.1]:36453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ajA8m-0007Gm-3t for submit@debbugs.gnu.org; Thu, 24 Mar 2016 14:37:52 -0400 Original-Received: from mail-lb0-f175.google.com ([209.85.217.175]:35171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ajA8k-0007Ga-2t for 23101@debbugs.gnu.org; Thu, 24 Mar 2016 14:37:50 -0400 Original-Received: by mail-lb0-f175.google.com with SMTP id bc4so36648250lbc.2 for <23101@debbugs.gnu.org>; Thu, 24 Mar 2016 11:37:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ymceYM54fwsq64ncw7lImQG7KBW36OwY+c4wm4lOLAA=; b=jwuzTaE1pbx6pT6mqSqFXtbUiu/9TI0U3Q5lA/VUt8ZU1JDbBxM566C5vYxTm5FMyZ edZ1ofNQ9zd9wWRR0kzdebLQBbPRshxbfPhXI6cRg6hRpy2ZxrfycSPCwxcYw1WYfOKd vexuSdvqMYFVvlSFL7mk+KFVat8JsP6LT8zyyx8hTHXn8WKsnU2fQsWB4fJqtdC822yk s5AWiyinCBMnLqAsNN0g9bAMW0TcFyeQhTbRV9tX/866IG0kXuCz1hMeuXkQdHYJY24U UuZRlVJSg1BFw2gL1Kx4+MiV/FmiajS/SdSONwB7lTM7NNUo7XRRfaPW7sbG0Yk8qGH+ X41Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ymceYM54fwsq64ncw7lImQG7KBW36OwY+c4wm4lOLAA=; b=AVul7bmZxfBvPbPICPLlMp+xbWc54945Y0vzWAdv0sgI04iSBRa2jzrnPcXCfGgvVO NNMixFN0AdtyOeMhubkY4P+jkixoRmnsMGp4/FQJoReOLqLggdzzDuq6jnZ/dgirDNf2 SSx2rQDjWdw3KfLOTyIxPIV08owRuCyfHtFR5EPDWZCAAB3+E1wglT4qZqE4j/YSsohr wxMBgLG5wpX8VtebZyRgThb1q7cEtpKkzoJDXBP+7ligNum7Oc6tp59e0DJ+1Jfxyx8k joL0EVPlWY8rDP2xNPk421Km4syE7s2U0Qu6a11uKw6fTsZbPT5ojbscBljrwIfDP+Nc M8iw== X-Gm-Message-State: AD7BkJJxfsvhZJ36DpeBcR5Ksdoh+jByJFLteWQeMQ7m5BaT6V2UJiKZz8PIb5WdKMXGSAHQMZQBjQhUvcwxC+rB X-Received: by 10.112.139.1 with SMTP id qu1mr3219929lbb.143.1458844663826; Thu, 24 Mar 2016 11:37:43 -0700 (PDT) In-Reply-To: <83wpor21hu.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115452 Archived-At: --089e01182fd8f8b417052ecfbd15 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, Mar 24, 2016 at 7:08 PM Eli Zaretskii wrote: > > From: Philipp Stephani > > Date: Thu, 24 Mar 2016 09:45:33 +0000 > > > > Minimal reproduction: > > > > (with-temp-buffer > > (let ((last-nonmenu-event nil) > > (use-dialog-box t) > > (oldbuf (current-buffer))) > > (yes-or-no-p "") > > (cl-assert (equal oldbuf (current-buffer))))) > > > > Seems that yes-or-no-p switches buffers when the dialog box is used. > > Thanks, I think I fixed this on the emacs-25 branch. > Thanks for fixing, but please note that your fix relies on make_save_ptr_ptr, which is conditionally defined: #if ! (defined USE_X_TOOLKIT || defined USE_GTK) Lisp_Object make_save_ptr_ptr (void *a, void *b) Most likely that #if should just be removed. --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Matthew Scott Sucherman, Paul Terence Manicle Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und l=C3=B6schen Sie die E-Mail und alle Anh=C3=A4nge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks. --089e01182fd8f8b417052ecfbd15 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Thu= , Mar 24, 2016 at 7:08 PM Eli Zaretskii <eliz@gnu.org> wrote:
> F= rom: Philipp Stephani <phst@google.com>
> Date: Thu, 24 Mar 2016 09:45:33 +0000
>
> Minimal reproduction:
>
> (with-temp-buffer
>=C2=A0 =C2=A0(let ((last-nonmenu-event nil)
> (use-dialog-box t)
> (oldbuf (current-buffer)))
>=C2=A0 =C2=A0 =C2=A0(yes-or-no-p "")
>=C2=A0 =C2=A0 =C2=A0(cl-assert (equal oldbuf (current-buffer)))))
>
> Seems that yes-or-no-p switches buffers when the dialog box is used.
Thanks, I think I fixed this on the emacs-25 branch.
<= br>
Thanks for fixing, but please note that your fix relies on ma= ke_save_ptr_ptr, which is conditionally defined:

#= if ! (defined USE_X_TOOLKIT || defined USE_GTK)
Lisp_Object
=
make_save_ptr_ptr (void *a, void *b)

Most lik= ely that #if should just be removed.=C2=A0
--

Google Germany GmbH
Erika-Mann-Stra=C3=9Fe 33
80636 M=C3=BCnchen

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Gesch=C3=A4ftsf=C3=BChrer: Matthew Scott Sucherman, Paul Terence Manicle

Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Ad= ressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absen= der und l=C3=B6schen Sie die E-Mail und alle Anh=C3=A4nge. Vielen Dank.

This e-mail is confidential. If you are not the right addres= see please do not forward it, please inform the sender, and please erase th= is e-mail including any attachments. Thanks.

--089e01182fd8f8b417052ecfbd15--