From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: master a08320f: * lisp/disp-table.el (make-glyph-code): Remove obsolete comment. Date: Mon, 9 Nov 2020 20:46:55 +0100 Message-ID: References: <20201109171613.6680.13417@vcs0.savannah.gnu.org> <20201109171614.766A220A27@vcs0.savannah.gnu.org> <831rh248xu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7862"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philipp Stephani , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 09 20:48:24 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kcD9L-0001u2-Oc for ged-emacs-devel@m.gmane-mx.org; Mon, 09 Nov 2020 20:48:23 +0100 Original-Received: from localhost ([::1]:48396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcD9K-0006Dq-P7 for ged-emacs-devel@m.gmane-mx.org; Mon, 09 Nov 2020 14:48:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcD8D-0004zZ-07 for emacs-devel@gnu.org; Mon, 09 Nov 2020 14:47:13 -0500 Original-Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]:39829) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kcD8A-0001u6-UT for emacs-devel@gnu.org; Mon, 09 Nov 2020 14:47:12 -0500 Original-Received: by mail-lf1-x129.google.com with SMTP id j205so6763779lfj.6 for ; Mon, 09 Nov 2020 11:47:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=HCPFJXW7OB22zb/bAXNySAPq+p7/bvL6mCS9NSTumkU=; b=KgWaQGQ5RuKxaJoF2uVgKdCDV3B/ooQFZxqqvoluezQ+qJz4xR5FzRECVOWM4ZO+V3 9ZBd9eiDKfgoVUUhmO6ISNq3eEMmNJntfS1uoHax64nEXaxuFaiqZge6P8ZJrjhaH/H6 fksuUlZ/IiJGtgN+k7jeOjzbp9lg67SgTQBWosozDdvCXo9w6x/K162MrQ9y60b5qzrF s3FRpasalnJezdaWuzRWKmcZHsi8KgHHK5pgOXwB5aaV/kfY789uabdLY1qkkGKuD/eW fBhdHK7Mt19ckowBPLXBcEARrybVVvDDGaK9vreExUghS90T6dRoRErbOMyjqkArv4V1 TjeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=HCPFJXW7OB22zb/bAXNySAPq+p7/bvL6mCS9NSTumkU=; b=mjmBp1VtIVHgJbQF/g8SzKPWrXThbxXF9lssyiBohL918zn5CVTs06Wpv2h6+cj6PN ejplLagz5ww5yO+70Y7//v6o93p4yy3mmkt2KtCX2L1URSyUwcNoKFk4hKAqo7z8oWvj LqgxfJ/KmxHu2NroYJwGaYRl9nEUOrpao486x+s5gLGplnjCUBJvjQ8aOAj5+MxIytt2 KJNSIrv7qZ3c/mSh0iCNvNaTy6+m9eYRlOy1S/dFRTxNKqG4xP+8/riL1cVYkA6a0kxi +du6kKa1glIGNLgEuHm2Y+0RnzYEO5rlYNxpAwS7IkpGL5WM9q0PHhwJ9RMrk7kOmrMf dkuA== X-Gm-Message-State: AOAM530ZJjLGM1RyXO254vzWlRpGmf4oeKiZ0sWq5JIV4ISdVHoGIjJe NlZFzFdcmStC/z+xl+0ZO6MdoG/Lh0Tb1bXwasCWSw== X-Google-Smtp-Source: ABdhPJwYa1tSezEdtIEpv2fCyLtnLZtDeGBWlZPgX76q3+h3hPVv6bAlBLDxaVVgHeMkApY9Bg6ONvKhExWvv+cQ+Wo= X-Received: by 2002:ac2:4888:: with SMTP id x8mr5970340lfc.248.1604951227440; Mon, 09 Nov 2020 11:47:07 -0800 (PST) In-Reply-To: <831rh248xu.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::129; envelope-from=phst@google.com; helo=mail-lf1-x129.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258955 Archived-At: Am Mo., 9. Nov. 2020 um 20:38 Uhr schrieb Eli Zaretskii : > > > Auto-Submitted: auto-generated > > Date: Mon, 9 Nov 2020 12:16:14 -0500 (EST) > > From: p.stephani2@gmail.com (Philipp Stephani) > > > > branch: master > > commit a08320f7234685cd84a18040556fd3f7eaacaf45 > > Author: Philipp Stephani > > Commit: Philipp Stephani > > > > * lisp/disp-table.el (make-glyph-code): Remove obsolete comment. > > --- > > lisp/disp-table.el | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/lisp/disp-table.el b/lisp/disp-table.el > > index 2e88d35..70343a3 100644 > > --- a/lisp/disp-table.el > > +++ b/lisp/disp-table.el > > @@ -220,8 +220,6 @@ for a graphical frame." > > ;;;###autoload > > (defun make-glyph-code (char &optional face) > > "Return a glyph code representing char CHAR with face FACE." > > - ;; Due to limitations on Emacs integer values, faces with > > - ;; face id greater than 512 are silently ignored. > > (if (not face) > > char > > (let ((fid (face-id face))) > > Is this comment really obsolete? We still need to be able to pack a > face ID and a 22-bit character codepoint into a single fixnum, which > could be a 32-bit data type. See GLYPH_CODE_CHAR, GLYPH_CODE_FACE, > and SET_GLYPH_FROM_GLYPH_CODE on dispextern.h. It definitely worked for me with a face ID over 800. Also there's the second codepath with a glyph code that is a cons, supporting all fixnums as face IDs. --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls Sie diese f=C3=A4lschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, l=C3=B6schen Sie alle Kopien und Anh=C3=A4nge davon und lassen Sie = mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don=E2=80=99t forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.