From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Iurie Marian Newsgroups: gmane.emacs.bugs Subject: bug#71709: Fix recent change in tramp-sh-handle-make-process Date: Fri, 21 Jun 2024 23:09:07 +0200 Message-ID: References: <87msneqeyn.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17829"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71709@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 22 09:11:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKuuC-0004Pd-OG for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Jun 2024 09:11:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKuts-0007Gl-Ud; Sat, 22 Jun 2024 03:11:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKutr-0007G8-Or for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 03:11:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sKutr-0006tc-An for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 03:11:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sKutq-0005qY-UV for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 03:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Iurie Marian Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jun 2024 07:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71709 X-GNU-PR-Package: emacs Original-Received: via spool by 71709-submit@debbugs.gnu.org id=B71709.171904025922445 (code B ref 71709); Sat, 22 Jun 2024 07:11:02 +0000 Original-Received: (at 71709) by debbugs.gnu.org; 22 Jun 2024 07:10:59 +0000 Original-Received: from localhost ([127.0.0.1]:44193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKutm-0005pv-H4 for submit@debbugs.gnu.org; Sat, 22 Jun 2024 03:10:59 -0400 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:46440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKlWZ-0005WC-VM for 71709@debbugs.gnu.org; Fri, 21 Jun 2024 17:10:24 -0400 Original-Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-364a39824baso1819393f8f.1 for <71709@debbugs.gnu.org>; Fri, 21 Jun 2024 14:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719004158; x=1719608958; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=mFF+tZLqt/oYIwwTnkvFnb0bcxITH6vN1nuKwvweNls=; b=kWJ+l5YYv83Xnzf1g1DZydXhWHViTmZtygR3OZjEnhZvT1VyhkBLv3wE0YMqWG0ddB ckczYYQ+NWgZcJ7bXIXLwzR5F8rtJc+t/YYttBz2jOfU0oROZbE+akrWGKR+oR9+aBBL 37qIvyVoZoHmbg2zotJCd2TofAy/lrHie9m/fa5Y6Skmfvp4M1oeUkz4Gs8ry+9zA0db ZK8lMYvbeljtybT8g+EWl84WOvX6nLZxAwPwLrZ5wmBtqfRYyo11yHCwbQqJdbnwrThV Nl2Mc/PLOG74DaS1fqntnkEkJw9T6sS368D4pUs0D7MUtIRNEh9ZTH+c4nXOgR5RXILZ D6rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719004158; x=1719608958; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mFF+tZLqt/oYIwwTnkvFnb0bcxITH6vN1nuKwvweNls=; b=QKmbkqQWTXSr50Q9rgzPrlpmSAulAQUUWJtAyrzB2KHcIvTz414bL/w8+X5BTWclXG SPhD50JLawFOPpDILS/w+mpgtdhb+gTsIGE3fhqcKShVr2L1BPdYXu7yhXtXdFCAiswi NutOLxsoURh+bDOZwi4vFcUJIrMg3eYQvhE5SEcJ6U9vTQlMidh42ZTGfUpQvyqrms3N KXPJhYnQcuoFXUO9LQHo0A/SVMNg9pc6DCfN/c7fX3KEfdq0JrLvO6kACQdWCyiMhCKG CLGKZ+t8G8YqRtjBGuRlG9tDxTorRDFCh3zawTgTkGFKOC3crGqiYnH/HDGFyhsyuzot PU/A== X-Gm-Message-State: AOJu0Yw3U4wPtjPblV106BcrtdqfjZelC8z9Q9bhSn9H7BiOdqhRkc5v f5pQgjj+HTeld6huTmpLx4htlzglSpTLksej0s0KPfTvvOcWFps63zWJrf7QPKDqTZNkEoAH0uG 7F+ggqq1GklTEE5Vy4FBq0mq/leg= X-Google-Smtp-Source: AGHT+IFDo3mryK7NkCofIibRLVyLLXvx8sRYLJOWoTDp35vR+5vkrTSs/BaZT+s/sPjeg+tGqwnE8gUzHEqjEhRfAcU= X-Received: by 2002:a05:600c:1d08:b0:422:4fcd:d4b3 with SMTP id 5b1f17b1804b1-4247529f03cmr69097595e9.37.1719004158423; Fri, 21 Jun 2024 14:09:18 -0700 (PDT) In-Reply-To: <87msneqeyn.fsf@gmx.de> X-Mailman-Approved-At: Sat, 22 Jun 2024 03:10:57 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287657 Archived-At: Hello Michael, Yes, you are right, of course :) Okay, I didn't notice that `stderr' is extracted earlier. ----- After updating emacs today I got strange errors while running consult-find in a remote container, for example: ``` /usr/bin/cat: /tmp/tramp.gBbQP1: No such file or directory /usr/bin/cat: /tmp/tramp.SWKx2Y: No such file or directory ``` I checked the consult-find (which also points out to a "tramp bug"), then I checked the tramp's latest changes and applied that one-line from the patch, which fixed my issue. (In fact that line `(stderr (plist-get args :stderr))' actually nullifies the `stderr', so probably that's why it worked and I had a feeling that it is a solution) Please see below: * consult-find: https://github.com/minad/consult/blob/main/consult.el#L4965 * consult--async-process: https://github.com/minad/consult/blob/main/consult.el#L2287C1-L2296C69 I guess, to reproduce the issue, it's enough to invoke `make-process' on a remote location and with a non-nil `:stderr' argument (a buffer in `consult-find''s case). Kind Regards, Iurie On Fri, 21 Jun 2024 at 21:21, Michael Albinus wrote: > > Iurie Marian writes: > > Hi, > > > tramp-sh-handle-make-process is failing when `:stderr' argument is > > used. > > > > In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version > > 3.24.41, cairo version 1.18.0) of 2024-06-21 built on rrouwprlc0222 > > Repository revision: e7123edfe7f7abc9043429dfb3f84941f83d6565 > > Repository branch: master > > System Description: Ubuntu 24.04 LTS > > > > diff --git a/lisp/net/tramp-sh.el b/lisp/net/tramp-sh.el > > index bce7c323dad..68018298b68 100644 > > --- a/lisp/net/tramp-sh.el > > +++ b/lisp/net/tramp-sh.el > > @@ -2969,6 +2969,7 @@ tramp-sh-handle-make-process > > (let* ((program (car command)) > > (args (cdr command)) > > ;; STDERR can also be a file name. > > + (stderr (plist-get args :stderr)) > > (tmpstderr > > (and stderr > > (tramp-unquote-file-local-name > > Why that? stderr is extracted from args in tramp-skeleton-make-process. > > Do you get an error which shows the problem? > > Best regards, Michael.