From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Igor Saprykin Newsgroups: gmane.emacs.devel Subject: [PATCH] * ftfont.c (ftfont_lookup_cache): Eliminate unnecessary variable. Date: Thu, 23 Apr 2020 13:24:00 -0700 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000000472ac05a3fb0902" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="63784"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 23 22:34:42 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jRiYU-000GTg-0M for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Apr 2020 22:34:42 +0200 Original-Received: from localhost ([::1]:40765 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRiYT-0000g8-2P for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Apr 2020 16:34:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55756) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRiOc-00030m-Pz for emacs-devel@gnu.org; Thu, 23 Apr 2020 16:24:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRiOc-00068G-6J for emacs-devel@gnu.org; Thu, 23 Apr 2020 16:24:30 -0400 Original-Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:44088) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jRiOb-00061f-Pc for emacs-devel@gnu.org; Thu, 23 Apr 2020 16:24:29 -0400 Original-Received: by mail-lf1-x130.google.com with SMTP id 131so5804931lfh.11 for ; Thu, 23 Apr 2020 13:24:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=xS3V5XJabISXKVryULk65/CFCtVhz103UKhviBLpSOk=; b=nWX4vDMct+Rm2XhbM/dljneC2VmCizZOmtax51hAICe6GVYIHl+o3vHFXy4AVfygqy CS9sVoZDYM5qNRo99L0rUDwzZhPqdjgnNGqj+H28Az3Y9dKLtwT7jYF0fbbhCrsXyQKe iMi4rmyEa10e66Bap3QxHKcmO6KgomATB8xvv3shvRALpuE6WEk6QYxrtQwprhYvVaD9 fVEJyBN00tWJr2FlzmYCKx6EkpfOV6gvBrgK5ey1wTQdy+YUat9f7S820QWP8yIWZpSP NOktJOuLRbBGwzkx4cS5kcfQ+EtDA+nnhPjfxm/71EbXSXVdkeRGh5wKvoCp3obotvLz cSLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=xS3V5XJabISXKVryULk65/CFCtVhz103UKhviBLpSOk=; b=FtFlBvSOMc6fvIFxbGuG8j7Dm+po17i8S/6+IcML+o3XScnNIgH+1+8Hetrh3+613X dlpUJt4twLQbTwibAfJiqWO5IPtrEYJ+atW2i+1oxQHOIvM7TxEkaQhmyRgaagDz/wze efPJy5WiBPwdXd2HQK6tmmz7S+ym66zEslMurat9ONIwI2tfIA7X6n7ggwyac4ERAIvN LrWR8gQuDHLkLaUb6VoXmRQbeVNEAZuZ17nONmHXPwt2F/xSGCBbGzzahve+6xXpFEQc w76OCzXONjXT9hXgTOO8pyoTFDAJhxQ8soj8KvsZ1DOcNUlNNLcK8teNVblZs99JngkZ Nzjg== X-Gm-Message-State: AGi0PuZ6/3zufM8Fsus5/gJDSN4xYdLeST1AfwWSS+6+QMratd6+Sza0 1iRQcN9fkRnaw9FYiPNKUZ9a15J6ieYPiC8ifLM4TNEJ X-Google-Smtp-Source: APiQypKrc3uUScFGQnjTpOq69WyWrt8fWnjVpv4kJpuMZGsKrXTGv+/0CvyqYrcEHuw3e3OuqwdTzj14RzRFGRGgOjE= X-Received: by 2002:ac2:5395:: with SMTP id g21mr3555836lfh.61.1587673466947; Thu, 23 Apr 2020 13:24:26 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::130; envelope-from=sheleztt@gmail.com; helo=mail-lf1-x130.google.com X-detected-operating-system: by eggs.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67 X-Received-From: 2a00:1450:4864:20::130 X-Mailman-Approved-At: Thu, 23 Apr 2020 16:33:58 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247630 Archived-At: --0000000000000472ac05a3fb0902 Content-Type: text/plain; charset="UTF-8" Hello! I noticed some unnecessary code when browsing through the sources. It is generally good to remove it. I believe the attached patch cleans it up. I tested by doing `make clean`. I also read through the CONTRIBUTE file and the appropriate commit message seems to be the one-liner. Thanks! Best, Igor Saprykin --0000000000000472ac05a3fb0902 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-ftfont.c-ftfont_lookup_cache-Eliminate-unnecessary-v.patch" Content-Disposition: attachment; filename="0001-ftfont.c-ftfont_lookup_cache-Eliminate-unnecessary-v.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k9d7r4350 RnJvbSAzMmM4Yzc1MzkxMGZiNDE3ZTVlNWViNmI5N2M3ZDBhYWI2M2I1YWY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBJZ29yIFNhcHJ5a2luIDxzaGVsZXp0dEBnbWFpbC5jb20+CkRh dGU6IFRodSwgMjMgQXByIDIwMjAgMTM6MDA6MjYgLTA3MDAKU3ViamVjdDogW1BBVENIXSAqIGZ0 Zm9udC5jIChmdGZvbnRfbG9va3VwX2NhY2hlKTogRWxpbWluYXRlIHVubmVjZXNzYXJ5CiB2YXJp YWJsZS4KCkNvcHlyaWdodC1wYXBlcndvcmstZXhlbXB0OiB5ZXMKLS0tCiBzcmMvZnRmb250LmMg fCA3ICsrLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2Z0Zm9udC5jIGIvc3JjL2Z0Zm9udC5jCmluZGV4IDZiNTQ5 YzNkZGYuLjY5NmY1ZTY1MzQgMTAwNjQ0Ci0tLSBhL3NyYy9mdGZvbnQuYworKysgYi9zcmMvZnRm b250LmMKQEAgLTM0NiwxOCArMzQ2LDE1IEBAIGZ0Zm9udF9yZXNvbHZlX2dlbmVyaWNfZmFtaWx5 IChMaXNwX09iamVjdCBmYW1pbHksIEZjUGF0dGVybiAqcGF0dGVybikKIHN0YXRpYyBMaXNwX09i amVjdAogZnRmb250X2xvb2t1cF9jYWNoZSAoTGlzcF9PYmplY3Qga2V5LCBlbnVtIGZ0Zm9udF9j YWNoZV9mb3IgY2FjaGVfZm9yKQogewotICBMaXNwX09iamVjdCBjYWNoZSwgdmFsLCBlbnRpdHk7 CisgIExpc3BfT2JqZWN0IGNhY2hlLCB2YWw7CiAgIHN0cnVjdCBmdGZvbnRfY2FjaGVfZGF0YSAq Y2FjaGVfZGF0YTsKIAogICBpZiAoRk9OVF9FTlRJVFlfUCAoa2V5KSkKICAgICB7Ci0gICAgICBl bnRpdHkgPSBrZXk7Ci0gICAgICB2YWwgPSBhc3NxX25vX3F1aXQgKFFDZm9udF9lbnRpdHksIEFS RUYgKGVudGl0eSwgRk9OVF9FWFRSQV9JTkRFWCkpOworICAgICAgdmFsID0gYXNzcV9ub19xdWl0 IChRQ2ZvbnRfZW50aXR5LCBBUkVGIChrZXksIEZPTlRfRVhUUkFfSU5ERVgpKTsKICAgICAgIGVh c3NlcnQgKENPTlNQICh2YWwpKTsKICAgICAgIGtleSA9IFhDRFIgKHZhbCk7CiAgICAgfQotICBl bHNlCi0gICAgZW50aXR5ID0gUW5pbDsKIAogICBpZiAoTklMUCAoZnRfZmFjZV9jYWNoZSkpCiAg ICAgY2FjaGUgPSBRbmlsOwotLSAKMi4yMC4xCgo= --0000000000000472ac05a3fb0902--