From: Pip Cet <pipcet@gmail.com>
To: eggert@cs.ucla.edu
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master f18af6c: Audit use of lsh and fix glitches
Date: Sat, 25 Aug 2018 15:02:56 +0000 [thread overview]
Message-ID: <CAOqdjBfr9Qk18nwAkm_SMpizNibezPXL6gJCzGauH-Ba_Y-8Ow@mail.gmail.com> (raw)
In-Reply-To: <4c677990-0d1c-acdb-596c-2bce02756a61@cs.ucla.edu>
On Fri, Aug 24, 2018 at 8:55 PM Paul Eggert <eggert@cs.ucla.edu> wrote:
> On my to-do list of things to try is to use 4 adjacent type codes for fixnums,
> bignums, immediate floats and indirect floats, so that INTEGERP, BIGNUMP,
> FIXNUMP, FLOATP, and NUMBERP can each be done by a single mask-and-compare.
I'm already using a separate tag value for bignums, though it might
help to use tag value 0 instead of a nonzero one (but then Qnil
couldn't be all-zeroes in memory).
I've discovered that the sequence gcc (trunk) emits for a mask-and-compare is:
mov %rax, %rbx
and $7, %rbx
cmp $7, %rbx
where I would use
lea 1(%rax), %ebx
test $7, %bl
I can force the latter by testing ((char)((int)(XLI (x) + 8 -
Lisp_String)) & 7) == 0 rather than the (equivalent, AFAICS) (XLI (x)
& 7) == Lisp_String (sometimes gcc uses a longer sequence, though). At
this point, I think gcc should be emitting the shorter two-insn
sequence for both C expressions.
With this "improvement", the code size difference is 13184 bytes. I'm
unable to measure a performance difference, since it is lost in the
noise.
I've benchmarked the hash-cons approach, though the implementation I
used was rather trivial, and simple bignum calculations appear to be
about 20-50% slower. Again, I expect that number to increase once the
extra copy in make_number is removed. (For floats, the slowdown is
worse.)
I still think there are problems with collisions, accidental or
intentional, and with shrinking the hash table again after a
calculation is finished. And I think those problems would be worse if
strings ever become immutable but eq-when-equal.
next prev parent reply other threads:[~2018-08-25 15:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180821204437.16880.99611@vcs0.savannah.gnu.org>
[not found] ` <20180821204439.62390209A6@vcs0.savannah.gnu.org>
2018-08-22 12:36 ` [Emacs-diffs] master f18af6c: Audit use of lsh and fix glitches Pip Cet
2018-08-22 13:35 ` Ken Brown
2018-08-22 13:44 ` Paul Eggert
2018-08-22 15:50 ` Pip Cet
2018-08-22 17:27 ` Paul Eggert
2018-08-22 20:05 ` Pip Cet
2018-08-22 21:53 ` Paul Eggert
2018-08-22 20:45 ` Stefan Monnier
2018-08-23 14:55 ` Pip Cet
2018-08-23 15:56 ` Stefan Monnier
2018-08-24 18:00 ` Pip Cet
2018-08-24 20:55 ` Paul Eggert
2018-08-25 15:02 ` Pip Cet [this message]
2018-08-25 18:02 ` Stefan Monnier
2018-08-25 21:24 ` Paul Eggert
2018-08-28 14:08 ` hash-consing bignums and eq==eql Stefan Monnier
2018-08-29 13:32 ` Pip Cet
2018-08-29 19:23 ` Stefan Monnier
2018-08-29 19:31 ` Paul Eggert
2018-08-29 20:50 ` Stefan Monnier
2018-09-09 3:09 ` Stefan Monnier
2018-09-09 6:26 ` Paul Eggert
2018-08-22 13:49 ` [Emacs-diffs] master f18af6c: Audit use of lsh and fix glitches Pip Cet
2018-08-22 14:52 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOqdjBfr9Qk18nwAkm_SMpizNibezPXL6gJCzGauH-Ba_Y-8Ow@mail.gmail.com \
--to=pipcet@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.