From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#21333: 25.0.50; window-size-change-functions not called after mini-window resize Date: Sun, 23 Aug 2015 22:06:45 +0000 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=047d7bd753707f1e2a051e01b78d X-Trace: ger.gmane.org 1440367645 27332 80.91.229.3 (23 Aug 2015 22:07:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 23 Aug 2015 22:07:25 +0000 (UTC) To: 21333@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 24 00:07:16 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZTdQ3-0000x4-M0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Aug 2015 00:07:15 +0200 Original-Received: from localhost ([::1]:36930 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTdQ2-0000zI-Nc for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Aug 2015 18:07:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTdPs-0000uc-Ha for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2015 18:07:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTdPq-0005lM-Vu for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2015 18:07:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTdPq-0005lG-T5 for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2015 18:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZTdPq-0005vB-IM for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2015 18:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Aug 2015 22:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21333 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.144036761422745 (code B ref -1); Sun, 23 Aug 2015 22:07:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Aug 2015 22:06:54 +0000 Original-Received: from localhost ([127.0.0.1]:36268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZTdPh-0005um-KH for submit@debbugs.gnu.org; Sun, 23 Aug 2015 18:06:54 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47272) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZTdPf-0005uc-J8 for submit@debbugs.gnu.org; Sun, 23 Aug 2015 18:06:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTdPd-0005hV-Sg for submit@debbugs.gnu.org; Sun, 23 Aug 2015 18:06:51 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:52604) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTdPd-0005hR-QP for submit@debbugs.gnu.org; Sun, 23 Aug 2015 18:06:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTdPc-0000c6-Ct for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2015 18:06:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTdPa-0005eq-Tu for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2015 18:06:48 -0400 Original-Received: from mail-ig0-x235.google.com ([2607:f8b0:4001:c05::235]:35714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTdPa-0005ea-Mj for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2015 18:06:46 -0400 Original-Received: by igbjg10 with SMTP id jg10so48073793igb.0 for ; Sun, 23 Aug 2015 15:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=CzHsJZ/8yuaEM0OSZEKqqnhWpBcfGx2ODr9lwGzPFWA=; b=tnzRIRO0hFZ9e5r+1R3cS6MHiZKaOmkkvq6tO7+KtLsXjrZ+YaxHdZ/9s3wtAXOEVw dDfAGJ/8u0KpVYTzZL0b7J+b6DXQ+fYIFE9eHQwYRcECPDX1+mRxSWvjvCBa3D6J0913 6Lez8NYknGxxCyIK06wXKPaZP0U1SjqK+tQpdZ6NGTXG8kYclO05lB1DmZBP5YyLm8vN UOIT/Z7KqufqCSIfDASPbDHEIcleibH1MopjhA6P8hUIEbmi60yFWByrTGxu2PsJuheU Ng4I73MI1/LDA0tJIe/ZwJX/6bto06ZWRkPlk69Jjos4SRx0F3dqqooaixuOt91OTnBA mjNw== X-Received: by 10.50.62.193 with SMTP id a1mr11378495igs.61.1440367605900; Sun, 23 Aug 2015 15:06:45 -0700 (PDT) Original-Received: by 10.79.78.66 with HTTP; Sun, 23 Aug 2015 15:06:45 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105746 Archived-At: --047d7bd753707f1e2a051e01b78d Content-Type: text/plain; charset=UTF-8 This is possibly only a documentation issue. Recipe: eval (progn (push (lambda (&rest args) (message "window size changed")) window-size-change-functions) (message (make-string 3000 ?*))) Expected result: a "window size changed" message. Actual result: no such message. The symptom is that the window size change function is not run after a mini-window size change. So far, I can produce this behavior only when the minibuffer or echo area grows to several lines; when it shrinks afterwards, my window size change function is called. I cannot reproduce the behavior with other windows. Is this a bug? The documentation says: [...] to be called if the size of any window changes for any reason. Please correct me if I'm wrong, but when the minibuffer/echo area gets resized (and the windows on top of it, too), that counts as a change of size, I would say. If this is merely a documentation issue, the exception should be noted in the manual. Analysis: First, some warnings: - `window_resize_apply' and `Fwindow_resize_apply' (aka `window-resize-apply') are two different functions - `resize-mini-window' and `resize-mini-window-internal' are called only when the mini-window is explicitly resized by a Lisp call of `resize-mini-window'. Implicit resizes as a consequence of having too much text in the echo area do not appear to call it. The problem is that FRAME_WINDOW_SIZES_CHANGED (f) is not set to true after a mini-window resize. Fwindow_resize_apply would set this flag, but window_resize_apply does not. If this behavior is deliberate, I believe it is inconsistent to set FRAME_WINDOW_SIZES_CHANGED (f) in `resize-mini-window-internal'. Suggested solution: Trivial. Add FRAME_WINDOW_SIZES_CHANGED (f) = true to all callers of window_resize_apply. In GNU Emacs 25.0.50.51 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.6) of 2015-08-23 on ... Repository revision: bfb06826feac9151877069590d5dc91b60337b6b Windowing system distributor `The X.Org Foundation', version 11.0.11702000 System Description: Debian GNU/Linux unstable (sid) Configured using: `configure 'CFLAGS=-O0 -g3'' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND DBUS GCONF GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message dired format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu cl-loaddefs pcase cl-lib mail-prsvr mail-utils misearch multi-isearch time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 81668 9633) (symbols 48 19040 0) (miscs 40 42 136) (strings 32 13288 4444) (string-bytes 1 380166) (vectors 16 11279) (vector-slots 8 414205 3702) (floats 8 131 186) (intervals 56 190 0) (buffers 976 11) (heap 1024 18666 1015)) --047d7bd753707f1e2a051e01b78d Content-Type: text/x-patch; charset=US-ASCII; name="0001-Call-window-size-change-functions-after-mini-window-.patch" Content-Disposition: attachment; filename="0001-Call-window-size-change-functions-after-mini-window-.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_idp1mnsv0 RnJvbSAyNDNiZTcwMDU5MTk3OTU1NGU2MWJiZGZmMGYwMGYzMGNjMzg2ZjdiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXAgPHBpcGNldEBnbWFpbC5jb20+CkRhdGU6IFN1biwg MjMgQXVnIDIwMTUgMjE6NDY6NDIgKzAwMDAKU3ViamVjdDogW1BBVENIXSBDYWxsIGB3aW5kb3ct c2l6ZS1jaGFuZ2UtZnVuY3Rpb25zJyBhZnRlciBtaW5pLXdpbmRvdyBzaXplCiBjaGFuZ2VzLgoK CSogd2luZG93LmMgKHJlc2l6ZV9mcmFtZV93aW5kb3dzKTogU2V0CglGUkFNRV9XSU5ET1dfU0la RVNfQ0hBTkdFRCBmbGFnLiAgKGdyb3dfbWluaV93aW5kb3cpOgoJTGlrZXdpc2UuICAoc2hyaW5r X21pbmlfd2luZG93KTogTGlrZXdpc2UuCi0tLQogc3JjL3dpbmRvdy5jIHwgMyArKysKIDEgZmls ZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9zcmMvd2luZG93LmMgYi9z cmMvd2luZG93LmMKaW5kZXggODYzYTc5Mi4uNjhiYzllNSAxMDA2NDQKLS0tIGEvc3JjL3dpbmRv dy5jCisrKyBiL3NyYy93aW5kb3cuYwpAQCAtNDA5NCw2ICs0MDk0LDcgQEAgcmVzaXplX2ZyYW1l X3dpbmRvd3MgKHN0cnVjdCBmcmFtZSAqZiwgaW50IHNpemUsIGJvb2wgaG9yZmxhZywgYm9vbCBw aXhlbHdpc2UpCiAgICAgfQogCiAgIGZzZXRfcmVkaXNwbGF5IChmKTsKKyAgRlJBTUVfV0lORE9X X1NJWkVTX0NIQU5HRUQgKGYpID0gdHJ1ZTsKIH0KIAogCkBAIC00NTMxLDYgKzQ1MzIsNyBAQCBn cm93X21pbmlfd2luZG93IChzdHJ1Y3Qgd2luZG93ICp3LCBpbnQgZGVsdGEsIGJvb2wgcGl4ZWx3 aXNlKQogCSAgLyogRW5mb3JjZSBmdWxsIHJlZGlzcGxheSBvZiB0aGUgZnJhbWUuICAqLwogCSAg LyogRklYTUU6IFNob3VsZG4ndCB3aW5kb3ctLXJlc2l6ZS1yb290LXdpbmRvdy12ZXJ0aWNhbGx5 IGRvIGl0PyAgKi8KIAkgIGZzZXRfcmVkaXNwbGF5IChmKTsKKwkgIEZSQU1FX1dJTkRPV19TSVpF U19DSEFOR0VEIChmKSA9IHRydWU7CiAJICBhZGp1c3RfZnJhbWVfZ2x5cGhzIChmKTsKIAkgIHVu YmxvY2tfaW5wdXQgKCk7CiAJfQpAQCAtNDU3MCw2ICs0NTcyLDcgQEAgc2hyaW5rX21pbmlfd2lu ZG93IChzdHJ1Y3Qgd2luZG93ICp3LCBib29sIHBpeGVsd2lzZSkKIAkgIC8qIEVuZm9yY2UgZnVs bCByZWRpc3BsYXkgb2YgdGhlIGZyYW1lLiAgKi8KIAkgIC8qIEZJWE1FOiBTaG91bGRuJ3Qgd2lu ZG93LS1yZXNpemUtcm9vdC13aW5kb3ctdmVydGljYWxseSBkbyBpdD8gICovCiAJICBmc2V0X3Jl ZGlzcGxheSAoZik7CisJICBGUkFNRV9XSU5ET1dfU0laRVNfQ0hBTkdFRCAoZikgPSB0cnVlOwog CSAgYWRqdXN0X2ZyYW1lX2dseXBocyAoZik7CiAJICB1bmJsb2NrX2lucHV0ICgpOwogCX0KLS0g CjIuNS4wCgo= --047d7bd753707f1e2a051e01b78d--