From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Fri, 19 Feb 2021 14:23:05 +0000 Message-ID: References: <87wny8xwcc.fsf@gnus.org> <83im9sqk1b.fsf@gnu.org> <83v9drp8va.fsf@gnu.org> <831rdjd95w.fsf@gnu.org> <83im6o2n67.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31246"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 43725@debbugs.gnu.org, Stefan Monnier To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 19 15:24:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lD6hX-0007zN-Ge for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Feb 2021 15:24:11 +0100 Original-Received: from localhost ([::1]:33334 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD6hW-00072w-17 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Feb 2021 09:24:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD6hO-00072i-SA for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 09:24:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37474) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lD6hO-0002Au-L4 for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 09:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lD6hO-0002gJ-HV for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 09:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Feb 2021 14:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.161374463310292 (code B ref 43725); Fri, 19 Feb 2021 14:24:02 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 19 Feb 2021 14:23:53 +0000 Original-Received: from localhost ([127.0.0.1]:49020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lD6hF-0002fw-51 for submit@debbugs.gnu.org; Fri, 19 Feb 2021 09:23:53 -0500 Original-Received: from mail-ot1-f54.google.com ([209.85.210.54]:35688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lD6h9-0002fg-V6 for 43725@debbugs.gnu.org; Fri, 19 Feb 2021 09:23:51 -0500 Original-Received: by mail-ot1-f54.google.com with SMTP id 80so5220576oty.2 for <43725@debbugs.gnu.org>; Fri, 19 Feb 2021 06:23:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ZOw6kF5mK13x1B6ADx+dSPtTcA8w5A8FiWI5S0T+BBk=; b=etlxs1Nk7GYkDlaL5PmXozBby16ZBZvUh3oL12PEdB+BMRQRGoP7dNvy6RnbYaTAtH WTnNN6rY86Wq+JRX2X63/yisOnqql8EL9QakQdgq7SOJVI4rlzoRBHFPiwr8sPKQbaYo lB3dmjKvXa8IxEmNGnULcO8/HYBlPk72Bpi7hyHlydy4GiTLs+wsjNLoLTusUZL8gTnr 5bL/SD97cY/XefDfJM8ggtivTzRAfS1zQuIogcr+I5Nq11U8XcFYCUd098xx/2BDg2Pc N7ViUomRrgu7UuK9SE/3x13Ld2PiD+D61Q9EhK8idJ+d9wnbsB3Z3QQboTduwG4l4u7S T69A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZOw6kF5mK13x1B6ADx+dSPtTcA8w5A8FiWI5S0T+BBk=; b=W69K1ZWYzBDtvNg4d4gwtbx0hVvaGdLIkuVCxnrk4LIw8yBG8uC3PVFZsNbwA3/ZaE psJolSHMYDl7GlbDzwWCEiwJrVij417UZu2yXl6VDlvhmfTBA1PaWSZyvhfsDQvStvbs Owl37CQ0MFXp1E59lMrAagQCIuQXy7yP1kWrIJfa3riqDm2UDrFND5jPnmrk7YmuyX2P rLzqRHjvDzlUsviiHfvfVBVkxK8oIbiPlh3PCa0K3oGgFeDLRQ+oNkq0IeLnZvrg+b1v DoFk9zW9ppfdTdT/rk6GT74oSPqna6bd0EIHbiKci5qC5g864FxTXt4aRmPBqQbeAyqm FW5g== X-Gm-Message-State: AOAM5326wYCiPdBb7Aw2t16PHe+CzYBvIpz5glDDJmMV5Jw629usrZMx MTWhFvZaSWMMoKcdZV8T9I8ndFWTHl+wIYkhL3A= X-Google-Smtp-Source: ABdhPJym1MY2a0Os+z1Hj/1viKHuO6YCjwftiqbvGX275ktrrErvAGuQMrVcbhAO8N2TClbO5uleU/U3JuoclCwho1o= X-Received: by 2002:a05:6830:1605:: with SMTP id g5mr7040130otr.292.1613744622441; Fri, 19 Feb 2021 06:23:42 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200338 Archived-At: On Fri, Feb 19, 2021 at 2:16 PM Andrea Corallo wrote: > >> > comp.c:1174:22: warning: logical =E2=80=98or=E2=80=99 of collectivel= y exhaustive tests is always true [-Wlogical-op] > >> > 1174 | if (val > LONG_MAX || val < LONG_MIN) > >> > | ^~ > >> > > >> > Not sure what's the best way to silence it or if we want to revert t= o > >> > the previous formulation. > >> > >> Maybe it's me, but I had a hard time parsing that warning. IIUC, the > >> tests are both trivially false? And oring two trivially false > >> conditions shouldn't trigger a warning, should it? > > > > No, I think it tries to say that val is always either greater than > > LONG_MAX or smaller than LONG_MIN. > > Exactly, the warning is about the fact that all the other conditions > will never be evaluated. The phrasing is admittedly quite cryptic tho. I thought you said this was a setup where the argument _does_ fit a long?