From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#38912: 27.0.60; PDumper meets segmentation fault when evil is loaded Date: Mon, 6 Jan 2020 17:13:40 +0000 Message-ID: References: <333553AC-68DE-4F1C-9586-5A13248AD6DD@icloud.com> <83ftgvh96l.fsf@gnu.org> <83a771g2tc.fsf@gnu.org> <83o8vgee85.fsf@gnu.org> <8b2e879676c6ecc1371d50e033164424.squirrel@dancol.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="153629"; mail-complaints-to="usenet@blaine.gmane.org" Cc: niwtrx@icloud.com, 38912@debbugs.gnu.org To: Daniel Colascione , emacs-devel@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 06 18:15:35 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ioVyX-000dqH-Gq for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Jan 2020 18:15:33 +0100 Original-Received: from localhost ([::1]:55444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioVyV-0008K1-7B for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Jan 2020 12:15:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49004) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioVy4-0008Hu-5B for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2020 12:15:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ioVy3-0007XI-24 for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2020 12:15:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40632) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ioVy2-0007X5-VK for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2020 12:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ioVy2-0000H7-Po for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2020 12:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jan 2020 17:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38912 X-GNU-PR-Package: emacs Original-Received: via spool by 38912-submit@debbugs.gnu.org id=B38912.1578330863972 (code B ref 38912); Mon, 06 Jan 2020 17:15:02 +0000 Original-Received: (at 38912) by debbugs.gnu.org; 6 Jan 2020 17:14:23 +0000 Original-Received: from localhost ([127.0.0.1]:46602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioVxP-0000Fb-Jp for submit@debbugs.gnu.org; Mon, 06 Jan 2020 12:14:23 -0500 Original-Received: from mail-ot1-f54.google.com ([209.85.210.54]:45121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioVxO-0000FJ-4Z for 38912@debbugs.gnu.org; Mon, 06 Jan 2020 12:14:22 -0500 Original-Received: by mail-ot1-f54.google.com with SMTP id 59so72554234otp.12 for <38912@debbugs.gnu.org>; Mon, 06 Jan 2020 09:14:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vmpaOjiRhtTPvrWge/yTbwEpuaWt5vkGpsc5UDVWaLs=; b=n+7tv8D2/LH38YOCeN5Rr4okMOBExG+D4fbCvJD5rFzWeibCF6zroffr/ObVkFqju4 4f5I+bkdNotienpSNl4vPrKcVyXpcACGEHo0hjKH+F33U1ItL2aMigrsJidj9pCqsotw 2gwvjzLPTqllUvk2sn6xhqRH5JkMNMVTDJUt8TKPbvo+nVUvIOFEVUaeq2HDowPIDS26 s1OorU+zdETOA/6kk3oQJF1LigE2sqvE0GBXWRsivHYv8h+kQo31kHsKvY8U4mqFbHl0 A0DRNVrjB4LhidiYFGxyT0HAK4wHnHdu1EFGYq+wLRRSNNP0/5/rSp35gaT7BemuDd+c d4HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vmpaOjiRhtTPvrWge/yTbwEpuaWt5vkGpsc5UDVWaLs=; b=YSDOvVOVbCEyEShPSPyujGPCNYIi+MmKwU2WXFFkEghufvlWWPMan+kSo8G4Gi1lGX cgi2n/olosWEDQAyg9DrY+Jf53aD3YpsNCIQmpr//LGhfCsVJTRdqote6aEfcgYt+myW c6jELDzIkGiobeGAEe9PLQfUNgk5bjKltgjVg1e1zojy1S+asLSggY0aDbOGqvzTuhPW cxYmcaC5lF3n7KBr1B2cHePYiezyr1IJJUtLiy8zXQppBhiOcA+PfrVOPpcswJufsbax bPfdfZOv1+VtGIx+lvMe4hHAs8QvgkFHNYhP1jFXzKaiQsXRCC+cC+BYxlVmn4/Yx9+n KMWA== X-Gm-Message-State: APjAAAU06E0hVLdJme2QAj1aIWbIG38MTDfwLT1P/4+GSAnLBh3D2G5G svBsAAbxpn7gVxiWDxPkzNaEFPuI1zY9p1tez/0= X-Google-Smtp-Source: APXvYqyUE2ucRJnx19JUStEZqTIyiZNLRKu0s4p8d0DdXWbinOC0o1UQvGdHOMSMYFxpWeXQDu8MOVIPDf9cWIAZBVc= X-Received: by 2002:a9d:68cb:: with SMTP id i11mr111575295oto.210.1578330856573; Mon, 06 Jan 2020 09:14:16 -0800 (PST) In-Reply-To: <8b2e879676c6ecc1371d50e033164424.squirrel@dancol.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:174246 Archived-At: Summary, since I'm CCing emacs-devel: For bytecode objects, equal-equality does not imply sxhash-equality. That led to an assertion failure in the pdumper code, even though the pdumper code itself is apparently correct; it simply does not allow for paradoxical behavior of hash tables with bytecode keys. (The muffled sound you hear in the background is my trying not to point out that eq-vs-eql leads to similar paradoxes). On Mon, Jan 6, 2020 at 5:01 PM Daniel Colascione wrote: > >> Again, I doubt this is related to the original bug. That `equal' > >> behaves weirdly like this is a problem I've mentioned before (when > >> (equal a b) signals but (equal b a) succeeds), but the consensus then > >> was not to change it, so it's possible this is only the rehashing > >> check needing to be more careful. > This consensus is wrong. We need to make equality imply sxhash equality or > very odd things (like this) will happen. I agree absolutely, of course, and maybe there's a consensus for fixing equal for bytecodes but leaving it unfixed for cases in which (equal a b) signals but (equal b a) does not. > C++ and Java both require this > relationship between hash code equality and object equality, and we should > too. We do document it, we just don't obey our documented API. > Can we just fix the bytecode sxhash bug? Is it too late to fix this for Emacs 27? If the answer is no, would a good fix be to make equal=eq for bytecode objects? That should come close to the old behavior, and we can fix things properly (by fixing sxhash to hash byte code objects) on master.