From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#39962: 27.0.90; Crash in Emacs 27.0.90 Date: Sun, 15 Mar 2020 12:09:43 +0000 Message-ID: References: <24162.58107.725366.668639@cochabamba.vanoostrum.org> <837dzqaieq.fsf@gnu.org> <834kuuadod.fsf@gnu.org> <83blp1siku.fsf@gnu.org> <83o8t08ufp.fsf@gnu.org> <831rpw8bf3.fsf@gnu.org> <17a7a496-d142-55d4-3cc9-f4f86fdaeaa8@cs.ucla.edu> <8336aadgca.fsf@gnu.org> <62ae1ea8-93d1-aa4e-dfb6-4dbd2d88e581@cs.ucla.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000001c2be905a0e396c1" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="95396"; mail-complaints-to="usenet@ciao.gmane.io" Cc: pieter-l@vanoostrum.org, 39962@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 15 13:11:25 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jDS72-000OjW-GB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 Mar 2020 13:11:24 +0100 Original-Received: from localhost ([::1]:53500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDS71-0005TS-Ff for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 Mar 2020 08:11:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54937) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDS6i-0005Qz-18 for bug-gnu-emacs@gnu.org; Sun, 15 Mar 2020 08:11:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDS6g-0005FH-Rx for bug-gnu-emacs@gnu.org; Sun, 15 Mar 2020 08:11:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56556) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jDS6g-0005EG-OY for bug-gnu-emacs@gnu.org; Sun, 15 Mar 2020 08:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jDS6g-0002IK-J4 for bug-gnu-emacs@gnu.org; Sun, 15 Mar 2020 08:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Mar 2020 12:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39962 X-GNU-PR-Package: emacs Original-Received: via spool by 39962-submit@debbugs.gnu.org id=B39962.15842742268775 (code B ref 39962); Sun, 15 Mar 2020 12:11:02 +0000 Original-Received: (at 39962) by debbugs.gnu.org; 15 Mar 2020 12:10:26 +0000 Original-Received: from localhost ([127.0.0.1]:34296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDS66-0002HT-FB for submit@debbugs.gnu.org; Sun, 15 Mar 2020 08:10:26 -0400 Original-Received: from mail-ot1-f53.google.com ([209.85.210.53]:41447) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDS65-0002HG-Jx for 39962@debbugs.gnu.org; Sun, 15 Mar 2020 08:10:26 -0400 Original-Received: by mail-ot1-f53.google.com with SMTP id s15so14956670otq.8 for <39962@debbugs.gnu.org>; Sun, 15 Mar 2020 05:10:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MdiLad9hSevv2yaMxFC303yLGEPRCZ/YXOcRPmuhhm8=; b=kShHDGn5fT0FFPH2UVZ6oJDfXMbkLr5fZ6IEBiSNcqG3wJzIlELBoL9CCVbGE6JugS d4UibQkjTh/zhiIQkljDCkNEt6VYe0EMXEbHTYFimdXWadTF/9ZolowHb4fA/AQu2xIV DMY9YSeyNSvdkkAU9huHv7DwQvpQYxV7wQGmf6O4IY2NwPOFKUW7tct+esaa2VguhQ4V 0EXyg8FUDKe0PCopEKYj0VoRSPePRWDQXYBy9DoO9mA9tjVjHpoyjPVlcDRb81GlvVhs WAFniR43+h8VNRzyDorI2ML8mTtDir1oPp4/HBZNtqCvAoBJJHL/uveWhKWcvC/qUcQO QItg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MdiLad9hSevv2yaMxFC303yLGEPRCZ/YXOcRPmuhhm8=; b=ROjiEOX6lPHj25kszik6BZ+DP8rm1n5PAr3bdT5cKejiHxE0vtwDjrB6wKHIQoxeB0 G7ININo9muOLo8DVOyjiZD+rbUwH/XYVfqZjxHfWcSyli6DZX1GZInAOMfeFfl1BIeQo 2TRFhKg6TeT9HGsrTyHgQFlRZ1RxdBAICitj8+kP8SmlRUj4Ueg53v+nQZ8g0UFSGGBR G8wv4RcNqimdoQ82ZwwW1MbbmveBLM/kctHBvUMrIJ6oBp/71Xkbcsqys+9CMN/Swdx5 u7HD9BfI7Q9l8WmASJqNpgn4IYZu54u8sptZFUbFuta49NqvEGAma/FUrXBT8CBUK56H 6GMg== X-Gm-Message-State: ANhLgQ35Zoud1innHhNWNIdzfxFockxeUTPZJlvJoe+/KLgWAweA4I0g +4SLEyNy5srgf7GOXLOSQeTMLrGyK4NxFUFur4Q= X-Google-Smtp-Source: ADFU+vsSCgeBPalnYFOV/wByEwFfw/DgygLHVyFxfNjOXIwL/QYxQPiR2kxDlMNVfAOq1HqMdpwIpEUw6BEs8j4/ir8= X-Received: by 2002:a05:6830:11:: with SMTP id c17mr18381779otp.292.1584274219994; Sun, 15 Mar 2020 05:10:19 -0700 (PDT) In-Reply-To: <62ae1ea8-93d1-aa4e-dfb6-4dbd2d88e581@cs.ucla.edu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177375 Archived-At: --0000000000001c2be905a0e396c1 Content-Type: text/plain; charset="UTF-8" On Sat, Mar 14, 2020 at 7:09 PM Paul Eggert wrote: > On 3/14/20 11:34 AM, Pip Cet wrote: > > > + if (0 <= offset && offset < sizeof *b && > > + (all_buffers || !NILP (b->name_))) > > The "&&" should go at the start of the second line, not the end of the first. Oops, sorry. Fixed patch attached. > This patch is for emacs-27, right? I'd intended it for emacs-27, yes. In master we should get rid of the live_buffer_p function entirely, I think. > Thanks again. Thank you! --0000000000001c2be905a0e396c1 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Don-t-collect-reachable-killed-buffers-during-GC.patch" Content-Disposition: attachment; filename="0001-Don-t-collect-reachable-killed-buffers-during-GC.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k7szxfzo0 RnJvbSBiMTAwZDVlNzBjZWQ1ZWQ1MGM3Y2JjYjQ3ZDNhNTViZWUzYTFmYzljIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBTYXQs IDE0IE1hciAyMDIwIDE4OjI2OjMzICswMDAwClN1YmplY3Q6IFtQQVRDSF0gRG9uJ3QgY29sbGVj dCByZWFjaGFibGUga2lsbGVkIGJ1ZmZlcnMgZHVyaW5nIEdDCgoqIHNyYy9hbGxvYy5jIChsaXZl X2J1ZmZlcl9ob2xkaW5nKTogQWRkIGBhbGxfYnVmZmVycycgYXJndW1lbnQgZm9yCnJldHVybmlu ZyBraWxsZWQgYnVmZmVycy4KKG1hcmtfbWF5YmVfb2JqZWN0LCBtYXJrX21heWJlX3BvaW50ZXIp OiBVc2UgaXQuCi0tLQogc3JjL2FsbG9jLmMgfCAxOCArKysrKysrKysrLS0tLS0tLS0KIDEgZmls ZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L3NyYy9hbGxvYy5jIGIvc3JjL2FsbG9jLmMKaW5kZXggMWM2YjY2NGIyMi4uOTMwMDM4MGZlMiAx MDA2NDQKLS0tIGEvc3JjL2FsbG9jLmMKKysrIGIvc3JjL2FsbG9jLmMKQEAgLTQ0ODIsMjAgKzQ0 ODIsMjIgQEAgbGl2ZV92ZWN0b3JfcCAoc3RydWN0IG1lbV9ub2RlICptLCB2b2lkICpwKQogfQog CiAvKiBJZiBQIGlzIGEgcG9pbnRlciBpbnRvIGEgbGl2ZSBidWZmZXIsIHJldHVybiB0aGUgYnVm ZmVyLgotICAgT3RoZXJ3aXNlLCByZXR1cm4gbmlsLiAgTSBpcyBhIHBvaW50ZXIgdG8gdGhlIG1l bV9ibG9jayBmb3IgUC4gICovCisgICBPdGhlcndpc2UsIHJldHVybiBuaWwuICBNIGlzIGEgcG9p bnRlciB0byB0aGUgbWVtX2Jsb2NrIGZvciBQLgorICAgQWxzbyByZXR1cm4ga2lsbGVkIGJ1ZmZl cnMgaWYgQUxMLUJVRkZFUlMgaXMgdHJ1ZS4gICovCiAKIHN0YXRpYyBMaXNwX09iamVjdAotbGl2 ZV9idWZmZXJfaG9sZGluZyAoc3RydWN0IG1lbV9ub2RlICptLCB2b2lkICpwKQorbGl2ZV9idWZm ZXJfaG9sZGluZyAoc3RydWN0IG1lbV9ub2RlICptLCB2b2lkICpwLCBib29sIGFsbF9idWZmZXJz KQogewotICAvKiBQIG11c3QgcG9pbnQgaW50byB0aGUgYmxvY2ssIGFuZCB0aGUgYnVmZmVyCi0g ICAgIG11c3Qgbm90IGhhdmUgYmVlbiBraWxsZWQuICAqLworICAvKiBQIG11c3QgcG9pbnQgaW50 byB0aGUgYmxvY2ssIGFuZCB0aGUgYnVmZmVyIG11c3Qgbm90CisgICAgIGhhdmUgYmVlbiBraWxs ZWQgdW5sZXNzIEFMTC1CVUZGRVJTIGlzIHRydWUuICAqLwogICBpZiAobS0+dHlwZSA9PSBNRU1f VFlQRV9CVUZGRVIpCiAgICAgewogICAgICAgc3RydWN0IGJ1ZmZlciAqYiA9IG0tPnN0YXJ0Owog ICAgICAgY2hhciAqY2IgPSBtLT5zdGFydDsKICAgICAgIGNoYXIgKmNwID0gcDsKICAgICAgIHB0 cmRpZmZfdCBvZmZzZXQgPSBjcCAtIGNiOwotICAgICAgaWYgKDAgPD0gb2Zmc2V0ICYmIG9mZnNl dCA8IHNpemVvZiAqYiAmJiAhTklMUCAoYi0+bmFtZV8pKQorICAgICAgaWYgKDAgPD0gb2Zmc2V0 ICYmIG9mZnNldCA8IHNpemVvZiAqYgorCSAgJiYgKGFsbF9idWZmZXJzIHx8ICFOSUxQIChiLT5u YW1lXykpKQogCXsKIAkgIExpc3BfT2JqZWN0IG9iajsKIAkgIFhTRVRCVUZGRVIgKG9iaiwgYik7 CkBAIC00NTA4LDcgKzQ1MTAsNyBAQCBsaXZlX2J1ZmZlcl9ob2xkaW5nIChzdHJ1Y3QgbWVtX25v ZGUgKm0sIHZvaWQgKnApCiBzdGF0aWMgYm9vbAogbGl2ZV9idWZmZXJfcCAoc3RydWN0IG1lbV9u b2RlICptLCB2b2lkICpwKQogewotICByZXR1cm4gIU5JTFAgKGxpdmVfYnVmZmVyX2hvbGRpbmcg KG0sIHApKTsKKyAgcmV0dXJuICFOSUxQIChsaXZlX2J1ZmZlcl9ob2xkaW5nIChtLCBwLCBmYWxz ZSkpOwogfQogCiAvKiBNYXJrIE9CSiBpZiB3ZSBjYW4gcHJvdmUgaXQncyBhIExpc3BfT2JqZWN0 LiAgKi8KQEAgLTQ1NjYsNyArNDU2OCw3IEBAIG1hcmtfbWF5YmVfb2JqZWN0IChMaXNwX09iamVj dCBvYmopCiAKIAljYXNlIExpc3BfVmVjdG9ybGlrZToKIAkgIG1hcmtfcCA9IChFUSAob2JqLCBs aXZlX3ZlY3Rvcl9ob2xkaW5nIChtLCBwbykpCi0JCSAgICB8fCBFUSAob2JqLCBsaXZlX2J1ZmZl cl9ob2xkaW5nIChtLCBwbykpKTsKKwkJICAgIHx8IEVRIChvYmosIGxpdmVfYnVmZmVyX2hvbGRp bmcgKG0sIHBvLCB0cnVlKSkpOwogCSAgYnJlYWs7CiAKIAlkZWZhdWx0OgpAQCAtNDYzNiw3ICs0 NjM4LDcgQEAgbWFya19tYXliZV9wb2ludGVyICh2b2lkICpwKQogCSAgYnJlYWs7CiAKIAljYXNl IE1FTV9UWVBFX0JVRkZFUjoKLQkgIG9iaiA9IGxpdmVfYnVmZmVyX2hvbGRpbmcgKG0sIHApOwor CSAgb2JqID0gbGl2ZV9idWZmZXJfaG9sZGluZyAobSwgcCwgdHJ1ZSk7CiAJICBicmVhazsKIAog CWNhc2UgTUVNX1RZUEVfQ09OUzoKLS0gCjIuMjUuMQoK --0000000000001c2be905a0e396c1--