From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#36773: 27.0.50; Accessing a cached SVG with eww can cause Emacs to crash Date: Wed, 24 Jul 2019 13:24:46 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000d0539f058e6d3d2e" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="104453"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36773@debbugs.gnu.org To: Adam Plaice Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 24 15:26:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hqHHV-000QxL-3G for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Jul 2019 15:26:09 +0200 Original-Received: from localhost ([::1]:51728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqHHU-00063P-5p for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Jul 2019 09:26:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39582) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqHHQ-0005zC-GO for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2019 09:26:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqHHO-0007Ml-Nd for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2019 09:26:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55516) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hqHHO-0007MR-IW for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2019 09:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hqHHO-0005FE-DC for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2019 09:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2019 13:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36773 X-GNU-PR-Package: emacs Original-Received: via spool by 36773-submit@debbugs.gnu.org id=B36773.156397473220122 (code B ref 36773); Wed, 24 Jul 2019 13:26:02 +0000 Original-Received: (at 36773) by debbugs.gnu.org; 24 Jul 2019 13:25:32 +0000 Original-Received: from localhost ([127.0.0.1]:36104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqHGt-0005ET-59 for submit@debbugs.gnu.org; Wed, 24 Jul 2019 09:25:31 -0400 Original-Received: from mail-ot1-f52.google.com ([209.85.210.52]:40298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqHGq-0005EE-Oy for 36773@debbugs.gnu.org; Wed, 24 Jul 2019 09:25:29 -0400 Original-Received: by mail-ot1-f52.google.com with SMTP id s7so1711959oth.7 for <36773@debbugs.gnu.org>; Wed, 24 Jul 2019 06:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i0pPTHz5+96wWwpvJMY76Wkoz1AWcD/bI3fZMM3n3EE=; b=Q80N0p6fzpCuiczr53MeYX/gfYjhCRAVvyS8GQdfNzWhmG/b90Jq8uUseR9PR4vexz Vw5mLQALzh1ijagvY3qpS1gs4Y/RtDHDPWFbM64vbF819UffKB1RI0uSedII1lv0E1PL Q7Sc7Pw0Vt+so6o/xbR/MqOZ7rx+YkCi3JKvBsyP65LQwMdqPqMRoD1/KC7s771L9N9L ocMWm0c3Zv0+5DBgwK+lCAinrrYRDAcTwGForfJtefm6k3ZDxaTk02kOAHbNtYwKAqUV OarqruCfEDFf9K0zjx/nP6VnIjHhFvHaTMtOvYa08CaoBOwdIGOa9n/S9vyJF0sm5vP/ 7Xag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i0pPTHz5+96wWwpvJMY76Wkoz1AWcD/bI3fZMM3n3EE=; b=Poq44VvTvUKzMx4DMAUAC1UQvk6o7b0/DRx6uFMYyulmGFCFLaSxyWKTsMZzn3uh7g wz5tcOv64rzOBnOpIrpKl3EsKsTB3khPI58HEHz3vlfgVmD+vh/loTOcLbEKMyX10dTq 5EJmuVVKFsImdGNojFhqKnsn+9dJ5H3qtEEG92OFs/p2JXN1KI8avtWRY20O9fyMJfqC g5diJnnGYwWR1fgsoelCNqo+ADYpHlxKj2d2I3NwMeEtbbBa/vaGvccw/0DPlGxr+QUb 0HkhxbW8nnHn2OU8DRIYXQ9o/nK3uLsYIutboRKEqS1bb/OcQMMYfTzK/RfxABpt4UwD wBwQ== X-Gm-Message-State: APjAAAUHDWhyr6YU7D95eQcYUU9reZohW/HSJBqXuhAusqYqcEQFwhNh KvoSZs8TKgtswKsztOHbrahpZkQo7jVseK5gWfM= X-Google-Smtp-Source: APXvYqzhYQ0e9fcWn3RzUd0kLsdDp9m9XmEWzPlPcvj1XScsmluQS/aI19Uhbbe8P8RRcKJYPt7w2TtuwRKhsiwBito= X-Received: by 2002:a9d:744f:: with SMTP id p15mr39314471otk.287.1563974723182; Wed, 24 Jul 2019 06:25:23 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163662 Archived-At: --000000000000d0539f058e6d3d2e Content-Type: text/plain; charset="UTF-8" On Tue, Jul 23, 2019 at 9:14 PM Adam Plaice wrote: > > I've attached the backtrace. Thanks. This seems like a librsvg bug, since it returned a NULL handle but no error. As for the other bug, it's a little tricky: shr calls url-store-in-cache after url-http-parse-headers has decompressed the file, while url-http-parse-headers itself would (correctly) cache the uncompressed file if it were configured to do so. It's not quite clear who's at fault here. IOW, there's probably a conflict in existing cache directories: some of them will store the compressed data, which won't work if it's images; some will store the uncompressed data, which won't work for HTML data. I'm attaching a patch to fix the rsvg segfault, and another patch which works around the url-http issue. However, I'm not sure how the latter should be fixed properly. --000000000000d0539f058e6d3d2e Content-Type: text/x-patch; charset="US-ASCII"; name="0002-Cache-HTTP-responses-as-uncompressed-data.patch" Content-Disposition: attachment; filename="0002-Cache-HTTP-responses-as-uncompressed-data.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jyha4sih1 RnJvbSA0MjA2YzFmN2E4MzNhNTRlMTNkYWIzMThhYmQzMzJhNGZiMzVkMDY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBXZWQs IDI0IEp1bCAyMDE5IDEzOjIzOjUwICswMDAwClN1YmplY3Q6IFtQQVRDSCAyLzJdIENhY2hlIEhU VFAgcmVzcG9uc2VzIGFzIHVuY29tcHJlc3NlZCBkYXRhLgoKKiBsaXNwL3VybC91cmwtaHR0cC5l bCAodXJsLWh0dHAtcGFyc2UtaGVhZGVycyk6IERlY29tcHJlc3MgYmVmb3JlCnN0b3JpbmcgVVJM IGJ1ZmZlcnMgaW4gdGhlIGNhY2hlLgotLS0KIGxpc3AvdXJsL3VybC1odHRwLmVsIHwgMTMgKysr KysrKysrLS0tLQogMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9saXNwL3VybC91cmwtaHR0cC5lbCBiL2xpc3AvdXJsL3VybC1odHRw LmVsCmluZGV4IDUyNzc2MDExOGQuLmQyODJiMTY2ZTkgMTAwNjQ0Ci0tLSBhL2xpc3AvdXJsL3Vy bC1odHRwLmVsCisrKyBiL2xpc3AvdXJsL3VybC1odHRwLmVsCkBAIC01ODksNiArNTg5LDcgQEAg dXJsLWh0dHAtcGFyc2UtaGVhZGVycwogICAobGV0KiAoKGJ1ZmZlciAoY3VycmVudC1idWZmZXIp KQogICAgICAgICAgKGNsYXNzICgvIHVybC1odHRwLXJlc3BvbnNlLXN0YXR1cyAxMDApKQogICAg ICAgICAgKHN1Y2Nlc3MgbmlsKQorICAgICAgICAgKG5vZGVjb21wcmVzcyBuaWwpCiAgICAgICAg ICA7OyBvdGhlciBzdGF0dXMgc3ltYm9sczogamV3ZWxyeSBhbmQgbHV4dXJ5IGNhcnMKICAgICAg ICAgIChzdGF0dXMtc3ltYm9sIChjYWRyIChhc3NxIHVybC1odHRwLXJlc3BvbnNlLXN0YXR1cyB1 cmwtaHR0cC1jb2RlcykpKSkKICAgICAodXJsLWh0dHAtZGVidWcgIlBhcnNlZCBIVFRQIGhlYWRl cnM6IGNsYXNzPSVkIHN0YXR1cz0lZCIKQEAgLTYyOCw4ICs2MjksMTAgQEAgdXJsLWh0dHAtcGFy c2UtaGVhZGVycwogCSAgOzsgR2VuZXJpYyBzdWNjZXNzIGZvciBhbGwgb3RoZXJzLiAgU3RvcmUg aW4gdGhlIGNhY2hlLCBhbmQKIAkgIDs7IG1hcmsgaXQgYXMgc3VjY2Vzc2Z1bC4KIAkgICh3aWRl bikKLQkgIChpZiAoYW5kIHVybC1hdXRvbWF0aWMtY2FjaGluZyAoZXF1YWwgdXJsLWh0dHAtbWV0 aG9kICJHRVQiKSkKLQkgICAgICAodXJsLXN0b3JlLWluLWNhY2hlIGJ1ZmZlcikpKSkKKwkgICh3 aGVuIChhbmQgdXJsLWF1dG9tYXRpYy1jYWNoaW5nIChlcXVhbCB1cmwtaHR0cC1tZXRob2QgIkdF VCIpKQorICAgICAgICAgICAgKHNldHEgbm9kZWNvbXByZXNzIHQpCisgICAgICAgICAgICAodXJs LWhhbmRsZS1jb250ZW50LXRyYW5zZmVyLWVuY29kaW5nKQorCSAgICAodXJsLXN0b3JlLWluLWNh Y2hlIGJ1ZmZlcikpKSkKICAgICAgICAoc2V0cSBzdWNjZXNzIHQpKQogICAgICAgKDMJCQkJOyBS ZWRpcmVjdGlvbgogICAgICAgIDs7IDMwMCBNdWx0aXBsZSBjaG9pY2VzCkBAIC02NzcsNyArNjgw LDggQEAgdXJsLWh0dHAtcGFyc2UtaGVhZGVycwogCQkJICAgICh1cmwtY2FjaGUtY3JlYXRlLWZp bGVuYW1lICh1cmwtdmlldy11cmwgdCkpKQogCSAgICAodXJsLWNhY2hlLWV4dHJhY3QgKHVybC1j YWNoZS1jcmVhdGUtZmlsZW5hbWUgKHVybC12aWV3LXVybCB0KSkpCiAJICAgIChzZXRxIHJlZGly ZWN0LXVyaSBuaWwKLQkJICBzdWNjZXNzIHQpKQorCQkgIHN1Y2Nlc3MgdAorICAgICAgICAgICAg ICAgICAgbm9kZWNvbXByZXNzIHQpKQogCSAgICgndXNlLXByb3h5CQkJOyAzMDUKIAkgICAgOzsg VGhlIHJlcXVlc3RlZCByZXNvdXJjZSBNVVNUIGJlIGFjY2Vzc2VkIHRocm91Z2ggdGhlCiAJICAg IDs7IHByb3h5IGdpdmVuIGJ5IHRoZSBMb2NhdGlvbiBmaWVsZC4gIFRoZSBMb2NhdGlvbiBmaWVs ZApAQCAtOTQxLDcgKzk0NSw4IEBAIHVybC1odHRwLXBhcnNlLWhlYWRlcnMKIAkgICAgICBjbGFz cyB1cmwtaHR0cC1yZXNwb25zZS1zdGF0dXMpKSkKICAgICAoaWYgKG5vdCBzdWNjZXNzKQogCSh1 cmwtbWFyay1idWZmZXItYXMtZGVhZCBidWZmZXIpCi0gICAgICAodXJsLWhhbmRsZS1jb250ZW50 LXRyYW5zZmVyLWVuY29kaW5nKSkKKyAgICAgIChpZiAobm90IG5vZGVjb21wcmVzcykKKyAgICAg ICAgICAodXJsLWhhbmRsZS1jb250ZW50LXRyYW5zZmVyLWVuY29kaW5nKSkpCiAgICAgKHVybC1o dHRwLWRlYnVnICJGaW5pc2hlZCBwYXJzaW5nIEhUVFAgaGVhZGVyczogJVMiIHN1Y2Nlc3MpCiAg ICAgKHdpZGVuKQogICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikpCi0tIAoyLjIyLjAKCg== --000000000000d0539f058e6d3d2e Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Don-t-crash-when-parsing-bad-SVG-data-bug-36773.patch" Content-Disposition: attachment; filename="0001-Don-t-crash-when-parsing-bad-SVG-data-bug-36773.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jyha4si90 RnJvbSAxYjZmM2JkNTMyYmYxZWE4MTlkMzc4MGRlZjJlMmM5NTk0YjEyMDRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBXZWQs IDI0IEp1bCAyMDE5IDEyOjM0OjM2ICswMDAwClN1YmplY3Q6IFtQQVRDSCAxLzJdIERvbid0IGNy YXNoIHdoZW4gcGFyc2luZyBiYWQgU1ZHIGRhdGEgKGJ1ZyMzNjc3MykKCiogc3JjL2ltYWdlLmMg KHN2Z19sb2FkX2ltYWdlKTogQmUgbW9yZSBjYXJlZnVsIGFib3V0IGxpYnJzdmcKcmV0dXJuaW5n IE5VTEwgcG9pbnRlcnMuCi0tLQogc3JjL2ltYWdlLmMgfCA5ICsrKysrKystLQogMSBmaWxlIGNo YW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMv aW1hZ2UuYyBiL3NyYy9pbWFnZS5jCmluZGV4IDM1NWM4NDk0OTEuLmIxZjg0ZTE5NDYgMTAwNjQ0 Ci0tLSBhL3NyYy9pbWFnZS5jCisrKyBiL3NyYy9pbWFnZS5jCkBAIC05NTMwLDExICs5NTMwLDE1 IEBAIHN2Z19sb2FkX2ltYWdlIChzdHJ1Y3QgZnJhbWUgKmYsIHN0cnVjdCBpbWFnZSAqaW1nLCBj aGFyICpjb250ZW50cywKICAgaWYgKGJhc2VfZmlsZSkKICAgICBnX29iamVjdF91bnJlZiAoYmFz ZV9maWxlKTsKICAgZ19vYmplY3RfdW5yZWYgKGlucHV0X3N0cmVhbSk7Ci0gIGlmIChlcnIpIGdv dG8gcnN2Z19lcnJvcjsKKyAgaWYgKGVyciB8fCByc3ZnX2hhbmRsZSA9PSBOVUxMKQorICAgIGdv dG8gcnN2Z19lcnJvcjsKICNlbHNlCiAgIC8qIE1ha2UgYSBoYW5kbGUgdG8gYSBuZXcgcnN2ZyBv YmplY3QuICAqLwogICByc3ZnX2hhbmRsZSA9IHJzdmdfaGFuZGxlX25ldyAoKTsKIAorICBpZiAo cnN2Z19oYW5kbGUgPT0gTlVMTCkKKyAgICBnb3RvIHJzdmdfZXJyb3I7CisKICAgLyogU2V0IGJh c2VfdXJpIGZvciBwcm9wZXJseSBoYW5kbGluZyByZWZlcmVuY2VkIGltYWdlcyAodmlhICdocmVm JykuCiAgICAgIFNlZSByc3ZnIGJ1ZyA1OTYxMTQgLSAiaW1hZ2UgcmVmcyBhcmUgcmVsYXRpdmUg dG8gY3VyZGlyLCBub3QgLnN2ZyBmaWxlIgogICAgICA8aHR0cHM6Ly9naXRsYWIuZ25vbWUub3Jn L0dOT01FL2xpYnJzdmcvaXNzdWVzLzMzPi4gKi8KQEAgLTk2NTQsNyArOTY1OCw4IEBAIHN2Z19s b2FkX2ltYWdlIChzdHJ1Y3QgZnJhbWUgKmYsIHN0cnVjdCBpbWFnZSAqaW1nLCBjaGFyICpjb250 ZW50cywKICAgcmV0dXJuIDE7CiAKICByc3ZnX2Vycm9yOgotICBnX29iamVjdF91bnJlZiAocnN2 Z19oYW5kbGUpOworICBpZiAocnN2Z19oYW5kbGUgIT0gTlVMTCkKKyAgICBnX29iamVjdF91bnJl ZiAocnN2Z19oYW5kbGUpOwogICAvKiBGSVhNRTogVXNlIGVycm9yLT5tZXNzYWdlIHNvIHRoZSB1 c2VyIGtub3dzIHdoYXQgaXMgdGhlIGFjdHVhbAogICAgICBwcm9ibGVtIHdpdGggdGhlIGltYWdl LiAgKi8KICAgaW1hZ2VfZXJyb3IgKCJFcnJvciBwYXJzaW5nIFNWRyBpbWFnZSBgJXMnIiwgaW1n LT5zcGVjKTsKLS0gCjIuMjIuMAoK --000000000000d0539f058e6d3d2e--