From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: Crashes in "C-h h" Date: Mon, 1 Jul 2019 15:40:49 +0000 Message-ID: References: <83y31hes6r.fsf@gnu.org> <83r279epwe.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="193784"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Andreas Schwab , eggert@cs.ucla.edu, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 01 17:48:47 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hhyXt-000oIr-Gg for ged-emacs-devel@m.gmane.org; Mon, 01 Jul 2019 17:48:45 +0200 Original-Received: from localhost ([::1]:60268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhyXr-0007IQ-UR for ged-emacs-devel@m.gmane.org; Mon, 01 Jul 2019 11:48:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47302) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhyRi-0003sv-3M for emacs-devel@gnu.org; Mon, 01 Jul 2019 11:42:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhyRe-00027i-Bi for emacs-devel@gnu.org; Mon, 01 Jul 2019 11:42:20 -0400 Original-Received: from mail-ot1-x32a.google.com ([2607:f8b0:4864:20::32a]:35792) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hhyRZ-00017D-Dn; Mon, 01 Jul 2019 11:42:14 -0400 Original-Received: by mail-ot1-x32a.google.com with SMTP id j19so13965017otq.2; Mon, 01 Jul 2019 08:41:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u99T9zqg1zpamwlnGHsYjTH2tUF/oBCc+L7qREtTpqU=; b=U+OCdFrXhn5NZ+GRFIxNEO00QR7Xpfk/M0Xn0/VZ6fGx5tXKFxJbQydW0uKKLStEDV y24yadikZTe9ZNCL9DBFkYbcCloKFanSIFFKJABXpP4K055iK5Jy40QBXKatZ7y+mUQY x3jleyhwgzF5E2758zoqFeUVG5hbkQ3pDGNFP85bqFYImhii+L5Ocgh/xX2Pf0frjt+m wv1ujNIyK4sSFCsxySEDsdNJGaQCWQSSSiccNFqO+vquMds6SgHZOwpx0M0ub8Ea8tbl VqICmxvM2WLrfU+TpOV8R49/5KUj2BE6l4fR4bh5isPkV4k2vI9kEUukEN0nmocth67t eYQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u99T9zqg1zpamwlnGHsYjTH2tUF/oBCc+L7qREtTpqU=; b=DFiU6b31XPMMTj6nr90SVrxZM9akYvf8l+/mAnaDqJXwMA6+0lQFKpje9cZxyd6/Mn L4PsZ581ZPsKzuhuMJ19tSJ9mLxBzA27REO3Ejr0l0QdYCwjLjj0UPEAtaUpqe/u1vI/ NUm2nrY997YLLb+cgfKka6Mv68Jevj63Wn8NBX4e5UIjNuYSeS8yDxZpw4aXX6tbJlOE DUoUEPwVdEluYO23P4pJxqbbDezTAm6ALjwXxERZKRQ5L2n+QQ4kxb+/MykBTUiRUOwX rvRyKgNeIhT0FpjSWI9S3z7n+c1y3bqoDr9YcLye7gTA+tJkgpTxz90TAKKdft268CHU PMlg== X-Gm-Message-State: APjAAAU2HLMxV6ovfTVG7N3rrFUCJVaWbJehBDBkoQEH4SUBhF85KGeA 0IUHJIdWFM8kyL1DwNgQ4kUVSLzQTjQrShF6pe8c6g6Kxbo= X-Google-Smtp-Source: APXvYqyEc/sHEQHJMqjMiULbEl4SD95zzNzAw4c4Hq2ygA9Raz8UghMZNcR6Vzvw5rP9iar4PEWLN8BPuFlk0bV2l/c= X-Received: by 2002:a9d:3c5:: with SMTP id f63mr19885154otf.210.1561995687903; Mon, 01 Jul 2019 08:41:27 -0700 (PDT) In-Reply-To: <83r279epwe.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::32a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238271 Archived-At: On Mon, Jul 1, 2019 at 3:29 PM Eli Zaretskii wrote: > > > #2 0x011467ac in XFIXNUM (a=XIL(0)) at lisp.h:1198 > > > #3 0x0135a8ea in fontset_find_font (fontset=XIL(0xa000000006a97b18), c=1047, > > > face=0x68dc4f8, charset_id=15, fallback=false) at fontset.c:578 > > > > repertory = FONT_DEF_REPERTORY (RFONT_DEF_FONT_DEF (rfont_def)); > > > > if (XFIXNUM (repertory) == charset_id) > > > > Looks like repertory is nil. > > Yes, that part is clear. The question is why... Is there a problem simply testing FIXNUMP in this place? If I'm reading this correctly, repertory may be nil, but it might also be a char table, which might, by sheer accident, have XFIXNUM_RAW (repertory) == charset_id, so it looks like a bug that was caught, not caused, by the recent XFIXNUM change.