From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#41321: 27.0.91; Emacs aborts due to invalid pseudovector objects Date: Tue, 26 May 2020 08:27:41 +0000 Message-ID: References: <83zha8cgpi.fsf@gnu.org> <83r1vibmyj.fsf@gnu.org> <83imgublku.fsf@gnu.org> <831rncjuwf.fsf@gnu.org> <83h7w5xvfa.fsf@gnu.org> <83y2phwb9x.fsf@gnu.org> <83r1v9w9vi.fsf@gnu.org> <83mu5xw50d.fsf@gnu.org> <83k110wxte.fsf@gnu.org> <4bab5f55-95fe-cf34-e490-1d4319728395@cs.ucla.edu> <11bedfbe-a895-ba76-c80b-9ee084ef85aa@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="65205"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41321@debbugs.gnu.org, Stefan Monnier To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 26 10:29:34 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jdUxq-000GrF-LT for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 May 2020 10:29:34 +0200 Original-Received: from localhost ([::1]:60494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdUxp-0000gC-Bi for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 May 2020 04:29:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdUxK-0008IX-JV for bug-gnu-emacs@gnu.org; Tue, 26 May 2020 04:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60681) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdUxK-0000D5-At for bug-gnu-emacs@gnu.org; Tue, 26 May 2020 04:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jdUxK-0007TR-8w for bug-gnu-emacs@gnu.org; Tue, 26 May 2020 04:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 May 2020 08:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41321 X-GNU-PR-Package: emacs Original-Received: via spool by 41321-submit@debbugs.gnu.org id=B41321.159048170528681 (code B ref 41321); Tue, 26 May 2020 08:29:02 +0000 Original-Received: (at 41321) by debbugs.gnu.org; 26 May 2020 08:28:25 +0000 Original-Received: from localhost ([127.0.0.1]:43994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdUwj-0007SX-5L for submit@debbugs.gnu.org; Tue, 26 May 2020 04:28:25 -0400 Original-Received: from mail-oi1-f196.google.com ([209.85.167.196]:38700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdUwh-0007SK-RZ for 41321@debbugs.gnu.org; Tue, 26 May 2020 04:28:24 -0400 Original-Received: by mail-oi1-f196.google.com with SMTP id j145so18006067oib.5 for <41321@debbugs.gnu.org>; Tue, 26 May 2020 01:28:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x48aq++Bgz8bqZ3yWKtHHuU3ycN+bJ6NVruHs/3J6/k=; b=lvoVS7wqxWaqftmQ/POXsuQgkwehEpTtbSjLQyvFsKPE48grkZacHxK+B4xsAN1JYz mv6Rfqvm4C86ICcgKGVJqMVgOtBTBvqo8kJ0z3flBA70zcZS7CyGNPm/TsmdKywS9Mmd TB9NUql7tLz7tsCK2oNmLGnC5P7JpVc5sDI29PZ+GeE3kqn0HEZAur9gVIFoV4/apgJ6 WugRbnKoxIjFBgktBLdmCAgpw2/B7IjW5DGLV2GRlNJExBp6cr7T1WhM0Z7G07esPPkq BL4Krkwx1LerTE4vLsY3x0TPjig3dLoy1tck4MFPV4f7F2aGynMArfSu9rSquyOJm9Ek d89w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x48aq++Bgz8bqZ3yWKtHHuU3ycN+bJ6NVruHs/3J6/k=; b=PXVwKHM8i1QJeSgbygOIR1t0UlypUAhhMN3ni7Krh+A+MBSiGU2xQx/abC1Dfp6nZK X4Qw2iNNT6Dl2B0vOl657PFc7ZGiKA3UUSHcEnJxZ9Y9Rh6uPutIZYldAErIM2rZZfX0 4ZbCuS+xvxFgqfw+EPR+gQnNf6bqjRlzr+rgsd7m5sUMrRylfLQt0ySCRBRAsOednd8I c9GeVEFmZutAZ71WSdsq1legvvpPMOpgdH/HUhhdfEH8/CZuHGZz1TdSlu8Ji7486GbL WwmtLdTActM74vVLdvxLhVlN5uFTOZSc9Rwhm6VtKtI6x+1myaR67ewRhgLt9QTvofBg a+wA== X-Gm-Message-State: AOAM5316Fcw7Tt9Bu8QwO/P+4sqsTuqKOjLBQdwLrSAI1tgC+UJOSo0P oYCrkrNWI+VOhf+0odiC4kYMZqCef/2FJrN7E2w= X-Google-Smtp-Source: ABdhPJxOtharsrXfU1DdtT6C7PYtV57XVJq9JO88H/2jXLMUh/UcYIHo1KD20eYtgtRLQedprHCnsFFUlLMjR5LSWqE= X-Received: by 2002:aca:c6d3:: with SMTP id w202mr14246304oif.44.1590481698093; Tue, 26 May 2020 01:28:18 -0700 (PDT) In-Reply-To: <11bedfbe-a895-ba76-c80b-9ee084ef85aa@cs.ucla.edu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181026 Archived-At: On Tue, May 26, 2020 at 7:51 AM Paul Eggert wrote: > On 5/25/20 11:18 PM, Pip Cet wrote: > > However, this is only because struct Lisp_String happens to have an > > even number of words. If someone changes that, the old code would > > break... > > No, because struct Lisp_String contains a GCALIGNED_UNION_MEMBER, so it is > always GC-aligned, and (for older compilers that don't support alignas (8)) this > is checked statically via 'verify (GCALIGNED (struct Lisp_String))'. As I said, this was specific to the old code, where LISP_ALIGNMENT, not GCALIGNMENT, was used by maybe_lisp_pointer. Things should be fine now (apart from the issue below)! > Now that I've looked at it, though, I see that I forgot to do something similar > with struct Lisp_Float, which has the same issue. Fixed by installing the > attached patch on master. LGTM. > > We're still going to have to deal with symbols on --wide-int builds > > when the two halves of the wide int are saved non-consecutively. > > Yes, I think that's the most pressing issue in this area. > I will have to take a > break now, though, since I have sleep and other work to do. Thanks for all the patches and comments!