From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#41454: 28.0.50; [".+" 0 font-shape-gstring] composition rule breaks paren highlighting Date: Sun, 31 May 2020 19:58:09 +0000 Message-ID: References: <83r1v0j8og.fsf@gnu.org> <83mu5oj853.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000243b4205a6f71ba4" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="104825"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41454@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 31 21:59:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jfU6w-000RF4-QZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 May 2020 21:59:10 +0200 Original-Received: from localhost ([::1]:39064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfU6v-0006NK-Og for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 May 2020 15:59:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfU6o-0006NE-7B for bug-gnu-emacs@gnu.org; Sun, 31 May 2020 15:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50573) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jfU6n-0000i2-SD for bug-gnu-emacs@gnu.org; Sun, 31 May 2020 15:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jfU6n-0006Fi-Qg for bug-gnu-emacs@gnu.org; Sun, 31 May 2020 15:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 May 2020 19:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41454 X-GNU-PR-Package: emacs Original-Received: via spool by 41454-submit@debbugs.gnu.org id=B41454.159095513324003 (code B ref 41454); Sun, 31 May 2020 19:59:01 +0000 Original-Received: (at 41454) by debbugs.gnu.org; 31 May 2020 19:58:53 +0000 Original-Received: from localhost ([127.0.0.1]:33886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfU6f-0006F5-9w for submit@debbugs.gnu.org; Sun, 31 May 2020 15:58:53 -0400 Original-Received: from mail-ot1-f50.google.com ([209.85.210.50]:44982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfU6d-0006Er-Os for 41454@debbugs.gnu.org; Sun, 31 May 2020 15:58:52 -0400 Original-Received: by mail-ot1-f50.google.com with SMTP id f18so6271205otq.11 for <41454@debbugs.gnu.org>; Sun, 31 May 2020 12:58:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fNI2/0vbDsmJoXrLEDSpfcD/R2+peyTuE0IQIlfggtI=; b=AyRn/+CcpyPFMtEjwISVzQHOiNcBaS35yWgPqN0/tNKhbehshd8qiyz8kKBlYbIMDu JHsaU+SwFICGEdBoJgR2/qexW2l6vwdKwe1IYQBqYmkLKTzq+RpKwB80dRZH5hyfaOzd 8wIXJgpEHiuU2gWC1EuM4mmH58bKdIkH7xNzMSI6qiRN2QFCWdN2W3rWlnFSAmHOTDD0 ZUL3WYJx2Kyw5ONfFzQSoTt49E84YVgfKeUbEccTfQbKoyz2LdfT/LHDDHnZ7yxVBx7Y 3IstfpwFOPntiAJvsAcenY3EoS17x4yxi+0vPWe52TxiryOilCUulou0bG0wTiKV7PpB 8w+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fNI2/0vbDsmJoXrLEDSpfcD/R2+peyTuE0IQIlfggtI=; b=JwjmwRKfqGtrg7ByNshXL3KK9xdPSF+KQtwJI0GSvCauq0dY32PhjaBgiTYzPdEF6q fgNlzPlaEtpxcYKhU66YEIYeLRrTPFKEBOTXoLHp/N2pwtRvtrqDXD2I0tt7M1HRtkwY Ssja/jhLmcm9acNnnT2lZSCSMJgi2O969qVZ17g701DOzA5yXMfzNuB/Rf5g5tHJdGJ5 Bk9GDw0hWelhGhNcnclj/gt5AseCvGjhG5erhO0QInT7wEVZg3qJf2+dezpXHCDNwU4A dQz8SqzTWR4tITlc/Bc7NXQAI46+hLolkS6bkSPVVi4u64C20k0NY8IFBvjPTUr9Mf31 92iA== X-Gm-Message-State: AOAM532XOkqb/+WpwonqQscsjgMLd7gaCgtvDD9VGMp42vifm+vdrG1u TxD8FEtpAU9VvpqsHbQhtEZKGlhitUQm5e7ySWNpJm35 X-Google-Smtp-Source: ABdhPJxZwatgStsu0WBZ05r2HLr0e8F3v7Mk9OOJ6B7EzWcSFNSgBSOPUW/ZA8mITSGH0IRuHNRyJzoaqQALF79Mv1o= X-Received: by 2002:a9d:6a44:: with SMTP id h4mr14557396otn.287.1590955126037; Sun, 31 May 2020 12:58:46 -0700 (PDT) In-Reply-To: <83mu5oj853.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181318 Archived-At: --000000000000243b4205a6f71ba4 Content-Type: text/plain; charset="UTF-8" On Sun, May 31, 2020 at 6:01 PM Eli Zaretskii wrote: > > Date: Sun, 31 May 2020 20:50:07 +0300 > > From: Eli Zaretskii > > Cc: 41454@debbugs.gnu.org > > > > The problem is that the entire sequence of characters that matches > > the regexp is passed to the shaper, and the result is stored as a > > single composition. And we have special code in the display engine > > not to break sequences of potentially-composed characters when > > handling faces (see compute_stop_pos). So I think there might be > > some bug there which shows when a composition comprises more than a > > single grapheme cluster, and some face is applied to them. > > On second thought, I'm not sure this is the right place to look at. > It could be fill_gstring_glyph_string and BUILD_GSTRING_GLYPH_STRING > instead (and the respective *term.c display functions). Thanks for the hint! You were absolutely correct. --000000000000243b4205a6f71ba4 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Don-t-get-confused-by-mid-gstring-face-changes-bug-4.patch" Content-Disposition: attachment; filename="0001-Don-t-get-confused-by-mid-gstring-face-changes-bug-4.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kavhjw0f0 RnJvbSBjMWQ0Nzc4MDAxNTY3ZjdkZmM3ODI1YjY5MTkzMDg5ZWM2OTg5N2JiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBTdW4s IDMxIE1heSAyMDIwIDE5OjU1OjQ4ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gRG9uJ3QgZ2V0IGNv bmZ1c2VkIGJ5IG1pZC1nc3RyaW5nIGZhY2UgY2hhbmdlcyAoYnVnIzQxNDU0KQoKKiBzcmMveGRp c3AuYyAoZmlsbF9nc3RyaW5nX2dseXBoX3N0cmluZyk6IERvbid0IGV4dGVuZCB0aGUgZ2x5cGgK c3RyaW5nIHBhc3QgZmFjZSBjaGFuZ2VzLgotLS0KIHNyYy94ZGlzcC5jIHwgMSArCiAxIGZpbGUg Y2hhbmdlZCwgMSBpbnNlcnRpb24oKykKCmRpZmYgLS1naXQgYS9zcmMveGRpc3AuYyBiL3NyYy94 ZGlzcC5jCmluZGV4IGRiMGVjNjgzMTUuLjk4OTk1OGZhMTEgMTAwNjQ0Ci0tLSBhL3NyYy94ZGlz cC5jCisrKyBiL3NyYy94ZGlzcC5jCkBAIC0yNzY5OCw2ICsyNzY5OCw3IEBAIGZpbGxfZ3N0cmlu Z19nbHlwaF9zdHJpbmcgKHN0cnVjdCBnbHlwaF9zdHJpbmcgKnMsIGludCBmYWNlX2lkLAogICB3 aGlsZSAoZ2x5cGggPCBsYXN0CiAJICYmIGdseXBoLT51LmNtcC5hdXRvbWF0aWMKIAkgJiYgZ2x5 cGgtPnUuY21wLmlkID09IHMtPmNtcF9pZAorCSAmJiBnbHlwaC0+ZmFjZV9pZCA9PSBmYWNlX2lk CiAJICYmIHMtPmNtcF90byA9PSBnbHlwaC0+c2xpY2UuY21wLmZyb20pCiAgICAgewogICAgICAg cy0+d2lkdGggKz0gZ2x5cGgtPnBpeGVsX3dpZHRoOwotLSAKMi4yNy4wLnJjMAoK --000000000000243b4205a6f71ba4--