From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#41520: 28.0.50; Crash in character.h due to assertion error Date: Mon, 25 May 2020 07:41:54 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000000c4c2405a6741fe4" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="10697"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41520@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 25 09:43:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jd7lO-0002kN-AD for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 May 2020 09:43:10 +0200 Original-Received: from localhost ([::1]:39390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jd7lN-0000dc-8X for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 May 2020 03:43:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jd7lG-0000cE-Jn for bug-gnu-emacs@gnu.org; Mon, 25 May 2020 03:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56354) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jd7lG-0004Gs-Ay for bug-gnu-emacs@gnu.org; Mon, 25 May 2020 03:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jd7lG-0001m2-8z for bug-gnu-emacs@gnu.org; Mon, 25 May 2020 03:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 May 2020 07:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41520 X-GNU-PR-Package: emacs Original-Received: via spool by 41520-submit@debbugs.gnu.org id=B41520.15903925586786 (code B ref 41520); Mon, 25 May 2020 07:43:02 +0000 Original-Received: (at 41520) by debbugs.gnu.org; 25 May 2020 07:42:38 +0000 Original-Received: from localhost ([127.0.0.1]:39667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jd7ks-0001lO-Bn for submit@debbugs.gnu.org; Mon, 25 May 2020 03:42:38 -0400 Original-Received: from mail-oi1-f171.google.com ([209.85.167.171]:45468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jd7kq-0001lC-S1 for 41520@debbugs.gnu.org; Mon, 25 May 2020 03:42:37 -0400 Original-Received: by mail-oi1-f171.google.com with SMTP id d191so15305277oib.12 for <41520@debbugs.gnu.org>; Mon, 25 May 2020 00:42:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t4OKbTC52p1eqyelEFrrbKn2uVx5bndRZ+tTEy+/poY=; b=Qf6dMRXyDPYpMw22GGowueG43qybkblObtFbwLIhTlMPlLFHQ5jFT6inM9igX5spAZ NnxLr+RnFTODUnHb+dVe1mCpeuSp3b6w7PCc1GE4ZYzNr8hR8G+/aKbIjd6gKooL2Pxe wX5rNlTOg1se1ltqIaOT/i2BMNLtVhvtzFuWdXVi/U6AHQZaMUCNRAJ9Sc0boLljrkeF cRD/8wjF3Je4bcwQ5+F1mb3e2FlQ17khr/6nxkna6PEwSXMtOgTLlRo+jslhpAOazMyp t/ee0UKjTGkzU7Gqqp4crKvBKh5WAqTU3lYTT1nQvwWnM5mOk1LqRmCI/asU6lwpDyrY npag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t4OKbTC52p1eqyelEFrrbKn2uVx5bndRZ+tTEy+/poY=; b=E0Y8JAJZGNR6YXsj09EhKd5DchMr9p9CbkzrXsgAo5Npj0iTQG5KH/wq+xBe61gD9C ajVHzk5SRk2e6O2ptcdjDw+yLInOBn4wCGDXS5E6Y4VT1ktPkV2oGyeqZ/hdqk11JpSV vWD+uxu9W17aelLTTE07N92D6pozQEFZOtc3efNJ9o99N/WWgS98kCOfuqSQry+TeH2x /VLgkyhhCp9YG+QnUrVNT60dbHZJkj0ysvAM7NLLjAIunOzx62JjskiadO/qF6aauOfO cMwlbb2KaFxBVF4lN7teT9mHIm7gaXMdUHbAwU+6RAuw0EGz+VlImDeaAZo7BB5IpgC0 2FZA== X-Gm-Message-State: AOAM532no1rOUQ+htDlWIdtH/Oep1GyJ+jMLj7DLTrS3IXvEq2J7OvNo VL33V/tcQOWaF0i4iZujnWtph04ggzk8GPYxOLo= X-Google-Smtp-Source: ABdhPJzfoPHO2cWO+UQnot5qfLbehDYDbEndn94+Ja/my9MroUEnkM8copUtCeH05GmoBnvG5g4U0TTVJO32jqXypug= X-Received: by 2002:a05:6808:1c8:: with SMTP id x8mr10108145oic.30.1590392550863; Mon, 25 May 2020 00:42:30 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180956 Archived-At: --0000000000000c4c2405a6741fe4 Content-Type: text/plain; charset="UTF-8" On Mon, May 25, 2020 at 7:28 AM Pip Cet wrote: > On Mon, May 25, 2020 at 7:06 AM Stefan Kangas wrote: > There's at least one other place that has the same error, so I'll grep > some more before sending a patch. Patch attached (it compiles, but I haven't tested it thoroughly). This should fix two bugs in xdisp.c and a bug in Fend_of_line. All of these bugs were silently fixed by my pos_t conversion. At the very least, FETCH_CHAR should be renamed so it's clear that the right way to use it is FETCH_CHAR (bytepos), not FETCH_CHAR (charpos). I suggest FETCH_CHAR_AT_BYTEPOS. --0000000000000c4c2405a6741fe4 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-assertion-errors-caused-by-bytepos-charpos-confu.patch" Content-Disposition: attachment; filename="0001-Fix-assertion-errors-caused-by-bytepos-charpos-confu.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kam6mk0p0 RnJvbSA0NjBkZGQ2YzQwOTQwNjEwNTQ4Yzc0ZWZiZDNkYTlmYThiMTcwZjcxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBNb24s IDI1IE1heSAyMDIwIDA3OjM1OjI4ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gRml4IGFzc2VydGlv biBlcnJvcnMgY2F1c2VkIGJ5IGJ5dGVwb3MvY2hhcnBvcyBjb25mdXNpb24KCiogc3JjL3hkaXNw LmMgKEZiaWRpX2ZpbmRfb3ZlcnJpZGRlbl9kaXJlY3Rpb25hbGl0eSk6IFVzZQpGRVRDSF9CWVRF LCBub3QgRkVUQ0hfQ0hBUiwgZm9yIGEgZGVjcmVtZW50ZWQgYnl0ZSBwb3NpdGlvbi4KKGdldF92 aXN1YWxseV9maXJzdF9lbGVtZW50KTogRGl0dG8uCgoqIHNyYy9jbWRzLmMgKEZlbmRfb2ZfbGlu ZSk6IFVzZSBieXRlIHBvc2l0aW9ucyBmb3IgRkVUQ0hfQ0hBUiwKbm90IGNoYXIgcG9zaXRpb25z LgotLS0KIHNyYy9jbWRzLmMgIHwgNCArKy0tCiBzcmMveGRpc3AuYyB8IDQgKystLQogMiBmaWxl cyBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv c3JjL2NtZHMuYyBiL3NyYy9jbWRzLmMKaW5kZXggOWY5NmYyMTBiOS4uZDE5OGJhZmMxNyAxMDA2 NDQKLS0tIGEvc3JjL2NtZHMuYworKysgYi9zcmMvY21kcy5jCkBAIC0xOTQsNyArMTk0LDcgQEAg REVGVU4gKCJlbmQtb2YtbGluZSIsIEZlbmRfb2ZfbGluZSwgU2VuZF9vZl9saW5lLCAwLCAxLCAi XnAiLAogICAgICAgU0VUX1BUIChuZXdwb3MpOwogCiAgICAgICBpZiAoUFQgPiBuZXdwb3MKLQkg ICYmIEZFVENIX0NIQVIgKFBUIC0gMSkgPT0gJ1xuJykKKwkgICYmIEZFVENIX0NIQVIgKFBUX0JZ VEUgLSAxKSA9PSAnXG4nKQogCXsKIAkgIC8qIElmIHdlIHNraXBwZWQgb3ZlciBhIG5ld2xpbmUg dGhhdCBmb2xsb3dzCiAJICAgICBhbiBpbnZpc2libGUgaW50YW5naWJsZSBydW4sCkBAIC0yMDUs NyArMjA1LDcgQEAgREVGVU4gKCJlbmQtb2YtbGluZSIsIEZlbmRfb2ZfbGluZSwgU2VuZF9vZl9s aW5lLCAwLCAxLCAiXnAiLAogCSAgYnJlYWs7CiAJfQogICAgICAgZWxzZSBpZiAoUFQgPiBuZXdw b3MgJiYgUFQgPCBaVgotCSAgICAgICAmJiBGRVRDSF9DSEFSIChQVCkgIT0gJ1xuJykKKwkgICAg ICAgJiYgRkVUQ0hfQ0hBUiAoUFRfQllURSkgIT0gJ1xuJykKIAkvKiBJZiB3ZSBza2lwcGVkIHNv bWV0aGluZyBpbnRhbmdpYmxlCiAJICAgYW5kIG5vdyB3ZSdyZSBub3QgcmVhbGx5IGF0IGVvbCwK IAkgICBrZWVwIGdvaW5nLiAgKi8KZGlmZiAtLWdpdCBhL3NyYy94ZGlzcC5jIGIvc3JjL3hkaXNw LmMKaW5kZXggY2YxNWY1NzliNS4uMDBjNTI2ODc0YyAxMDA2NDQKLS0tIGEvc3JjL3hkaXNwLmMK KysrIGIvc3JjL3hkaXNwLmMKQEAgLTgyOTAsNyArODI5MCw3IEBAIGdldF92aXN1YWxseV9maXJz dF9lbGVtZW50IChzdHJ1Y3QgaXQgKml0KQogICAgIH0KICAgZWxzZSBpZiAoaXQtPmJpZGlfaXQu Y2hhcnBvcyA9PSBib2IKIAkgICB8fCAoIXN0cmluZ19wCi0JICAgICAgICYmIChGRVRDSF9DSEFS IChpdC0+YmlkaV9pdC5ieXRlcG9zIC0gMSkgPT0gJ1xuJworCSAgICAgICAmJiAoRkVUQ0hfQllU RSAoaXQtPmJpZGlfaXQuYnl0ZXBvcyAtIDEpID09ICdcbicKIAkJICAgfHwgRkVUQ0hfQ0hBUiAo aXQtPmJpZGlfaXQuYnl0ZXBvcykgPT0gJ1xuJykpKQogICAgIHsKICAgICAgIC8qIElmIHdlIGFy ZSBhdCB0aGUgYmVnaW5uaW5nIG9mIGEgbGluZS9zdHJpbmcsIHdlIGNhbiBwcm9kdWNlCkBAIC0y NDE4Miw3ICsyNDE4Miw3IEBAIERFRlVOICgiYmlkaS1maW5kLW92ZXJyaWRkZW4tZGlyZWN0aW9u YWxpdHkiLAogCSAgaXRiLmNoYXJwb3MgPSBCRUdWOwogCSAgaXRiLmJ5dGVwb3MgPSBCRUdWX0JZ VEU7CiAJfQotICAgICAgZWxzZSBpZiAoRkVUQ0hfQ0hBUiAoZnJvbV9icG9zIC0gMSkgPT0gJ1xu JykKKyAgICAgIGVsc2UgaWYgKEZFVENIX0JZVEUgKGZyb21fYnBvcyAtIDEpID09ICdcbicpCiAJ ewogCSAgaXRiLmNoYXJwb3MgPSBmcm9tX3BvczsKIAkgIGl0Yi5ieXRlcG9zID0gZnJvbV9icG9z OwotLSAKMi4yNy4wLnJjMAoK --0000000000000c4c2405a6741fe4--