From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel,gmane.emacs.diffs Subject: Re: [Emacs-diffs] master f18af6c: Audit use of lsh and fix glitches Date: Wed, 22 Aug 2018 12:36:41 +0000 Message-ID: References: <20180821204437.16880.99611@vcs0.savannah.gnu.org> <20180821204439.62390209A6@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1534941338 19623 195.159.176.226 (22 Aug 2018 12:35:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 22 Aug 2018 12:35:38 +0000 (UTC) Cc: emacs-diffs@gnu.org To: emacs-devel@gnu.org, eggert@cs.ucla.edu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 22 14:35:33 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fsSMH-00051C-Iv for ged-emacs-devel@m.gmane.org; Wed, 22 Aug 2018 14:35:33 +0200 Original-Received: from localhost ([::1]:58854 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsSON-0007Ne-Ri for ged-emacs-devel@m.gmane.org; Wed, 22 Aug 2018 08:37:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsSOE-0007NN-It for emacs-devel@gnu.org; Wed, 22 Aug 2018 08:37:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsSOA-0006m0-Pn for emacs-devel@gnu.org; Wed, 22 Aug 2018 08:37:33 -0400 Original-Received: from mail-lf1-x143.google.com ([2a00:1450:4864:20::143]:33269) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fsSO5-0006gB-WD; Wed, 22 Aug 2018 08:37:28 -0400 Original-Received: by mail-lf1-x143.google.com with SMTP id c7-v6so1290950lfe.0; Wed, 22 Aug 2018 05:37:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DCzO+s3+25blGyfy6qfWV9Hyd1gFqp7NljEZgIoi6+c=; b=QeK1L+k18k8h15reluLnys+a5DAa0B1FtRcOu88mxC2G/r6ZQAi0PqE+lHLnFEO7ov Zirty67/lE67T2bDKIxRhcH2JoRpy+UFN6yPBNGp0TT4HZ4BOoPKNmKAYmsZ9bp+oo7I 8Xu024R8Ovpdz9sTBqZqIKdHeWCfuTY1SDDL01hIQwcMu1FcvWFKWeByZSx3ldpyS31g IZopoXZir2FSHQQ+GyCBEtacALkOm/5J5u4SmgojNRRruuVYtg3MsTloPjN1SwyQf+DN M8nPqxVfehusYRKUMBZ0ibBt+ataO0ZtBEP1IHFOr9mDGommL3RKoiRy97+PlMoXK2lq ChDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DCzO+s3+25blGyfy6qfWV9Hyd1gFqp7NljEZgIoi6+c=; b=A/8bS+X3es2Q5CUw3f+4AeHBtWrY8BzL1tPWuL0hhNXpQcpGcTMi7iDKL18+eN75Dd Z7kD81Okv8J9wBdK1tISrWpWe8QabguDolq6I6Wv5DUBNvw3BYLQTkkxzyUTkXrUDoHZ K8/n+2KP7P4LSo2Qz7uawrispoczZEPhjALMw6WtUqYD//2hi7H9Lpiz1d7CtcLZhQdH i+soqkCiAdQj1Vyl500dOE+9g4JSm6PdUcO96S5d5MNn9YRjOm7VB+8kF02QDTZqqa3c tR2WmbuUJmcxiyRvmNFB7YJPzVknKVxi0P0ybuyXToaH0hWew8kD51/kcj319fIuKuHv hNJw== X-Gm-Message-State: APzg51AkVdbFPXD/yIsr0WObn8W5nUdjZVW6d1PUMwt/d4dt4WkRs6Yu 7D9kGjO0IELg5ZkM5XMhQMbX3ZKeSPIkfv7lUvfoUw== X-Google-Smtp-Source: ANB0VdaoxAIuKaEb0LrV9AQt03eUP2NBAl/FmNwrlRg8mtOyG9GPKbHi5aALb8/P4Rj5c/SClFcav+qpzTFF4eEz7T0= X-Received: by 2002:a19:f83:: with SMTP id 3-v6mr3214549lfp.131.1534941443441; Wed, 22 Aug 2018 05:37:23 -0700 (PDT) In-Reply-To: <20180821204439.62390209A6@vcs0.savannah.gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::143 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228801 gmane.emacs.diffs:146742 Archived-At: On Tue, Aug 21, 2018 at 9:01 PM Paul Eggert wrote: > * lisp/vc/vc-hg.el (vc-hg-state-fast): When testing fixnum width, > prefer (zerop (ash most-positive-fixnum -32)) to (zerop (lsh -1 > 32)) (Bug#32485#11). I think the previous code was correct: now we have bignums, we should no longer return 'unsupported on machines with 30/32-bit fixnums, because 32 bits fit just fine into a bignum. Another `most-positive-fixnum' we can eliminate! All appearances of "fixnum" in that file should be replaced by "integer".