all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Pip Cet <pipcet@gmail.com>
To: eggert@cs.ucla.edu
Cc: 32405@debbugs.gnu.org
Subject: bug#32405: [PATCH] Turn misc objects into pseudovectors
Date: Thu, 9 Aug 2018 06:11:14 +0000	[thread overview]
Message-ID: <CAOqdjBeKW42wi2U8LUeaTs+6FXbp5mMnX7qVOKKAc6oZjOu6tg@mail.gmail.com> (raw)
In-Reply-To: <20180809025852.28874-1-eggert@cs.ucla.edu>

Hello Paul,

I'm still working (as time permits) on precise garbage collection
experiments (my current code doesn't use anything like the Lisp_Type
tag). I think your patch doesn't make things any worse for that,
though it moves special-case code from the main loop of mark_object to
the pseudovector-specific code. Is that right?

I was a bit surprised to see this code:

+      case PVEC_FINALIZER:
+        VECTOR_MARK (ptr);
+        mark_object (XFINALIZER (obj)->function);
+        break;
+

Isn't that precisely what the default code does?

Similarly for bool vectors, misc ptrs, and user ptrs.

Also, I'm curious what ideas you have for the newly freed Lisp_Type tag.





  parent reply	other threads:[~2018-08-09  6:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09  2:58 bug#32405: [PATCH] Turn misc objects into pseudovectors Paul Eggert
2018-08-09  5:01 ` bug#32405: Turning " Paul Eggert
2018-08-09  7:16   ` Paul Eggert
2018-08-09 16:24   ` Stefan Monnier
2018-08-09  6:11 ` Pip Cet [this message]
2018-08-09  7:44   ` bug#32405: [PATCH] Turn " Paul Eggert
2018-08-10  2:01     ` Richard Stallman
2018-08-09 17:23 ` Andy Moreton
2018-08-09 17:53 ` Pip Cet
2018-08-09 18:10   ` Paul Eggert
2018-08-09 18:24 ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOqdjBeKW42wi2U8LUeaTs+6FXbp5mMnX7qVOKKAc6oZjOu6tg@mail.gmail.com \
    --to=pipcet@gmail.com \
    --cc=32405@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.