From: Pip Cet <pipcet@gmail.com>
To: eggert@cs.ucla.edu
Cc: tom@tromey.com, emacs-devel@gnu.org
Subject: Re: Merging bignum to master
Date: Tue, 14 Aug 2018 13:04:43 +0000 [thread overview]
Message-ID: <CAOqdjBe8fi0EQ5+VcNSSu-LgrnuGO9tbu5=f1UBTbiWbGZ5+Dw@mail.gmail.com> (raw)
In-Reply-To: <611579fd-52f2-0104-ef82-a7a4a3929700@cs.ucla.edu>
[-- Attachment #1: Type: text/plain, Size: 158 bytes --]
Is it intentional that int-forwarded variables are still limited to
the fixnum range? In any case, we probably didn't want to rename
XINTFWD to XFIXNUMFWD...
[-- Attachment #2: 0001-fix-minor-oversights-in-the-bignum-patch.patch --]
[-- Type: text/x-patch, Size: 2045 bytes --]
From 546cc94a830ac971ac72700deac908fd8e41d356 Mon Sep 17 00:00:00 2001
From: Pip Cet <pipcet@gmail.com>
Date: Tue, 14 Aug 2018 12:36:04 +0000
Subject: [PATCH] fix minor oversights in the bignum patch
---
src/data.c | 6 +++---
src/lread.c | 7 +++----
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/src/data.c b/src/data.c
index a1215b9d6bf..4cd93f0ac7f 100644
--- a/src/data.c
+++ b/src/data.c
@@ -74,7 +74,7 @@ XKBOARD_OBJFWD (union Lisp_Fwd *a)
return &a->u_kboard_objfwd;
}
static struct Lisp_Intfwd *
-XFIXNUMFWD (union Lisp_Fwd *a)
+XINTFWD (union Lisp_Fwd *a)
{
eassert (INTFWDP (a));
return &a->u_intfwd;
@@ -1002,7 +1002,7 @@ do_symval_forwarding (register union Lisp_Fwd *valcontents)
switch (XFWDTYPE (valcontents))
{
case Lisp_Fwd_Int:
- XSETINT (val, *XFIXNUMFWD (valcontents)->intvar);
+ XSETINT (val, *XINTFWD (valcontents)->intvar);
return val;
case Lisp_Fwd_Bool:
@@ -1095,7 +1095,7 @@ store_symval_forwarding (union Lisp_Fwd *valcontents, register Lisp_Object newva
{
case Lisp_Fwd_Int:
CHECK_FIXNUM (newval);
- *XFIXNUMFWD (valcontents)->intvar = XFIXNUM (newval);
+ *XINTFWD (valcontents)->intvar = XFIXNUM (newval);
break;
case Lisp_Fwd_Bool:
diff --git a/src/lread.c b/src/lread.c
index df2fe581203..7411f1c7354 100644
--- a/src/lread.c
+++ b/src/lread.c
@@ -3813,10 +3813,9 @@ string_to_number (char const *string, int base, int flags)
return make_bignum_str (string, base);
}
- /* Either the number uses float syntax, or it does not fit into a fixnum.
- Convert it from string to floating point, unless the value is already
- known because it is an infinity, a NAN, or its absolute value fits in
- uintmax_t. */
+ /* The number uses float syntax. Convert it from string to floating
+ point, unless the value is already known because it is an
+ infinity, a NAN, or its absolute value fits in uintmax_t. */
if (! value)
value = atof (string + signedp);
--
2.18.0
next prev parent reply other threads:[~2018-08-14 13:04 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-11 19:47 Merging bignum to master Tom Tromey
2018-08-11 21:28 ` Basil L. Contovounesios
2018-08-12 16:34 ` Tom Tromey
2018-08-13 12:21 ` Basil L. Contovounesios
2018-08-14 0:21 ` Andy Moreton
2018-08-15 23:41 ` Andy Moreton
2018-08-16 15:38 ` Basil L. Contovounesios
2018-08-19 8:26 ` Paul Eggert
2018-08-17 14:58 ` Eli Zaretskii
2018-08-12 6:29 ` Ulrich Mueller
2018-08-12 8:09 ` Paul Eggert
2018-08-12 17:21 ` Ulrich Mueller
2018-08-12 18:20 ` Eli Zaretskii
2018-08-12 19:30 ` Ulrich Mueller
2018-08-13 0:15 ` Paul Eggert
2018-08-12 18:05 ` Eli Zaretskii
2018-08-12 23:53 ` Paul Eggert
2018-08-13 0:20 ` Tom Tromey
2018-08-13 7:51 ` Andreas Schwab
2018-08-13 8:06 ` Ulrich Mueller
2018-08-13 9:14 ` Paul Eggert
2018-08-14 23:09 ` Paul Eggert
2018-08-16 2:46 ` Richard Stallman
2018-08-13 23:31 ` Richard Stallman
2018-08-14 1:41 ` Paul Eggert
2018-08-16 2:41 ` Richard Stallman
2018-08-16 19:31 ` Paul Eggert
2018-08-16 22:02 ` Stefan Monnier
2018-08-12 7:37 ` John Wiegley
2018-08-12 18:21 ` Eli Zaretskii
2018-08-12 11:48 ` Pip Cet
2018-08-12 16:02 ` Tom Tromey
2018-08-13 22:58 ` Paul Eggert
2018-08-14 1:12 ` Noam Postavsky
2018-08-14 13:04 ` Pip Cet [this message]
2018-08-14 18:01 ` Paul Eggert
2018-08-15 15:20 ` Pip Cet
2018-08-15 16:17 ` Paul Eggert
2018-08-15 23:57 ` Andy Moreton
2018-08-16 22:00 ` Stefan Monnier
2018-08-20 16:28 ` Some vars now limited to fixnum size. (Was: Merging bignum to master) Karl Fogel
2018-08-20 16:54 ` Paul Eggert
2018-08-20 17:27 ` Eli Zaretskii
2018-08-20 17:27 ` Paul Eggert
2018-08-20 18:00 ` Eli Zaretskii
2018-08-20 19:55 ` Pip Cet
2018-08-20 23:15 ` Paul Eggert
2018-08-21 15:01 ` Some vars now limited to fixnum size Tom Tromey
2018-08-21 16:36 ` Andy Moreton
2018-08-21 18:46 ` Paul Eggert
2018-08-22 15:39 ` Tom Tromey
2018-08-21 3:38 ` Some vars now limited to fixnum size. (Was: Merging bignum to master) Richard Stallman
2018-08-21 4:09 ` Paul Eggert
2018-08-22 4:03 ` Richard Stallman
2018-08-22 4:53 ` Paul Eggert
2018-08-20 17:25 ` Eli Zaretskii
2018-08-14 0:51 ` Merging bignum to master Andy Moreton
2018-08-15 15:46 ` Andy Moreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOqdjBe8fi0EQ5+VcNSSu-LgrnuGO9tbu5=f1UBTbiWbGZ5+Dw@mail.gmail.com' \
--to=pipcet@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.