From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions' Date: Sat, 15 Jun 2019 15:14:43 +0000 Message-ID: References: <83h88tzbly.fsf@gnu.org> <835zp9z4oj.fsf@gnu.org> <83y325xnk0.fsf@gnu.org> <83k1doy5om.fsf@gnu.org> <83d0jgxt83.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000327750058b5e3bcc" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="26338"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36190@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 15 17:19:02 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcASM-0006j0-Dk for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Jun 2019 17:19:02 +0200 Original-Received: from localhost ([::1]:60942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcASL-00019A-FA for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Jun 2019 11:19:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58708) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcARS-00018e-DR for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 11:18:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcAPY-0004Tg-4D for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 11:16:11 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53765) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hcAPR-0003tg-Qz for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 11:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hcAPR-0002cX-Jy for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 11:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jun 2019 15:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36190 X-GNU-PR-Package: emacs Original-Received: via spool by 36190-submit@debbugs.gnu.org id=B36190.156061172810036 (code B ref 36190); Sat, 15 Jun 2019 15:16:01 +0000 Original-Received: (at 36190) by debbugs.gnu.org; 15 Jun 2019 15:15:28 +0000 Original-Received: from localhost ([127.0.0.1]:39076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcAOu-0002bn-71 for submit@debbugs.gnu.org; Sat, 15 Jun 2019 11:15:28 -0400 Original-Received: from mail-oi1-f177.google.com ([209.85.167.177]:33407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcAOr-0002bZ-IS for 36190@debbugs.gnu.org; Sat, 15 Jun 2019 11:15:26 -0400 Original-Received: by mail-oi1-f177.google.com with SMTP id q186so4149212oia.0 for <36190@debbugs.gnu.org>; Sat, 15 Jun 2019 08:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nVU9i0aqYU0xAL314iQgOFnk9XBsGBCIICHUaiPHKao=; b=ulLNcVJpAZGqRaEbQUr1jXm8Zak/wvO8IXhkNmw0epArdd68+7bzeWugEuntr0IUbz XqGi0kSFkN5yVsh+3w0T6xMucC2GUfXP/kHxseVo6B9nmRLH95nH8oLC/3cz/lzyLceH ttYY4eAPI8eVhbhMfIE1tJIU5JaeFqRixrcdPmDAojLRcSQ19XyRhsw3Fbs3kM+x/eSL 4G0aoRJl/Mh5AJER+8v1bWUcl4ENulq3YAhft77YG95PqGIa/3Je91X1iYeG0kgkfhT2 C0Lcs7GkwGx5zVywKuImnR34lFIB19dMvh3u2eVwLbaFwqUddCaG0RIEnhm1DQocv5dz CwKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nVU9i0aqYU0xAL314iQgOFnk9XBsGBCIICHUaiPHKao=; b=UpW5qYdWTpzFWNbVNW/YQgn6ysst8HddshU1NGwr32/TUQz0Ds2SZE2nzk4E2pYI65 LNQWvf3Pby8bE16aXeacIMGBXPvhReCXH0pVkAZzo/0aPL4oUMrFKRVbluL8OTprf+/H Pt6q8iwRfxhvu9vCEY/bfR3gRdNpk9lHdmhu1cbWcD8aNt/PszPezquztSvedoEn1kT8 3IgPH48pBq4YObmW5QQ1vaAOl3YaRy/UyuzXKsP/ZE1wWP2rhUwUglhFUt5QrVHcPu5T Wdu4vQ793Icvtnfxtzo79FzViQYF6q950Ns1Y7MkUJVXG+40PrI3T3bZEUMkmAFusobQ 8/Ag== X-Gm-Message-State: APjAAAX0AHxz70XsxRDX+IpKWzvC1m8XRLGUnyBOM4DicC9Vr6Cs7twY /VFxb46MkoCXZ0A3s53PPe/RGfTbjwB/VZEKx4s= X-Google-Smtp-Source: APXvYqwBnTZdR931t8fVxcZ5EyTI9ZNMwOavt+Z4pRmqlDd8HrtdfBSzPi34QnleWLbTlcFCiuaGvWYdiqb3Ucrf48w= X-Received: by 2002:aca:dcd7:: with SMTP id t206mr5416595oig.30.1560611719892; Sat, 15 Jun 2019 08:15:19 -0700 (PDT) In-Reply-To: <83d0jgxt83.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160616 Archived-At: --000000000000327750058b5e3bcc Content-Type: text/plain; charset="UTF-8" On Fri, Jun 14, 2019 at 12:11 PM Eli Zaretskii wrote: > > From: Pip Cet > > Date: Fri, 14 Jun 2019 11:14:53 +0000 > > Cc: 36190@debbugs.gnu.org > > > > Okay, I fixed those two issues. > > Thanks. Except that calls set_buffer_internal twice for a single call to put-text-property. That's too slow, right? How about simply emulating (with-current-buffer buffer (put-text-property ...)), as the attached patch does? That should fix the immediate problem. Thanks! --000000000000327750058b5e3bcc Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Update-current-buffer-when-changing-text-properties.patch" Content-Disposition: attachment; filename="0001-Update-current-buffer-when-changing-text-properties.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jwxnw5vy0 RnJvbSBjODIyZTU2MmFhYTUxYWYyZmM2ZmZjNzcwODEyNGZlYzZiYjMzM2U0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBTYXQs IDE1IEp1biAyMDE5IDE1OjEyOjE0ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gVXBkYXRlIGN1cnJl bnQgYnVmZmVyIHdoZW4gY2hhbmdpbmcgdGV4dCBwcm9wZXJ0aWVzLgoKKiBzcmMvdGV4dHByb3Au YyAoYWRkX3RleHRfcHJvcGVydGllc18xLCBzZXRfdGV4dF9wcm9wZXJ0aWVzKQooc2V0X3RleHRf cHJvcGVydGllc18xLCBGcmVtb3ZlX3RleHRfcHJvcGVydGllcyk6Ci0tLQogc3JjL3RleHRwcm9w LmMgfCA0OCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysK IDEgZmlsZSBjaGFuZ2VkLCA0OCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL3RleHRw cm9wLmMgYi9zcmMvdGV4dHByb3AuYwppbmRleCBhZTQyYzQ0MTg1Li40NmRlMzcyYjYxIDEwMDY0 NAotLS0gYS9zcmMvdGV4dHByb3AuYworKysgYi9zcmMvdGV4dHByb3AuYwpAQCAtMTE0MSw2ICsx MTQxLDE1IEBAIERFRlVOICgicHJldmlvdXMtc2luZ2xlLXByb3BlcnR5LWNoYW5nZSIsIEZwcmV2 aW91c19zaW5nbGVfcHJvcGVydHlfY2hhbmdlLAogYWRkX3RleHRfcHJvcGVydGllc18xIChMaXNw X09iamVjdCBzdGFydCwgTGlzcF9PYmplY3QgZW5kLAogCQkgICAgICAgTGlzcF9PYmplY3QgcHJv cGVydGllcywgTGlzcF9PYmplY3Qgb2JqZWN0LAogCQkgICAgICAgZW51bSBwcm9wZXJ0eV9zZXRf dHlwZSBzZXRfdHlwZSkgeworICBpZiAoQlVGRkVSUCAob2JqZWN0KSAmJiBYQlVGRkVSIChvYmpl Y3QpICE9IGN1cnJlbnRfYnVmZmVyKQorICAgIHsKKyAgICAgIHB0cmRpZmZfdCBjb3VudCA9IFNQ RUNQRExfSU5ERVggKCk7CisgICAgICByZWNvcmRfdW53aW5kX2N1cnJlbnRfYnVmZmVyICgpOwor ICAgICAgc2V0X2J1ZmZlcl9pbnRlcm5hbCAoWEJVRkZFUiAob2JqZWN0KSk7CisgICAgICByZXR1 cm4gdW5iaW5kX3RvIChjb3VudCwgYWRkX3RleHRfcHJvcGVydGllc18xIChzdGFydCwgZW5kLCBw cm9wZXJ0aWVzLAorCQkJCQkJICAgICAgb2JqZWN0LCBzZXRfdHlwZSkpOworICAgIH0KKwogICBJ TlRFUlZBTCBpLCB1bmNoYW5nZWQ7CiAgIHB0cmRpZmZfdCBzLCBsZW47CiAgIGJvb2wgbW9kaWZp ZWQgPSBmYWxzZTsKQEAgLTEzNDIsNiArMTM1MSwxNSBAQCBmYWNlKHMpIGFyZSByZXRhaW5lZC4g IFRoaXMgaXMgZG9uZSBieSBzZXR0aW5nIHRoZSBgZmFjZScgcHJvcGVydHkgdG8KIHNldF90ZXh0 X3Byb3BlcnRpZXMgKExpc3BfT2JqZWN0IHN0YXJ0LCBMaXNwX09iamVjdCBlbmQsIExpc3BfT2Jq ZWN0IHByb3BlcnRpZXMsCiAJCSAgICAgTGlzcF9PYmplY3Qgb2JqZWN0LCBMaXNwX09iamVjdCBj b2hlcmVudF9jaGFuZ2VfcCkKIHsKKyAgaWYgKEJVRkZFUlAgKG9iamVjdCkgJiYgWEJVRkZFUiAo b2JqZWN0KSAhPSBjdXJyZW50X2J1ZmZlcikKKyAgICB7CisgICAgICBwdHJkaWZmX3QgY291bnQg PSBTUEVDUERMX0lOREVYICgpOworICAgICAgcmVjb3JkX3Vud2luZF9jdXJyZW50X2J1ZmZlciAo KTsKKyAgICAgIHNldF9idWZmZXJfaW50ZXJuYWwgKFhCVUZGRVIgKG9iamVjdCkpOworICAgICAg cmV0dXJuIHVuYmluZF90byAoY291bnQsIHNldF90ZXh0X3Byb3BlcnRpZXMgKHN0YXJ0LCBlbmQs IHByb3BlcnRpZXMsCisJCQkJCQkgICAgb2JqZWN0LCBjb2hlcmVudF9jaGFuZ2VfcCkpOworICAg IH0KKwogICBJTlRFUlZBTCBpOwogICBib29sIGZpcnN0X3RpbWUgPSB0cnVlOwogCkBAIC0xNDEy LDYgKzE0MzAsMTcgQEAgc2V0X3RleHRfcHJvcGVydGllcyAoTGlzcF9PYmplY3Qgc3RhcnQsIExp c3BfT2JqZWN0IGVuZCwgTGlzcF9PYmplY3QgcHJvcGVydGllcywKIHNldF90ZXh0X3Byb3BlcnRp ZXNfMSAoTGlzcF9PYmplY3Qgc3RhcnQsIExpc3BfT2JqZWN0IGVuZCwKIAkJICAgICAgIExpc3Bf T2JqZWN0IHByb3BlcnRpZXMsIExpc3BfT2JqZWN0IG9iamVjdCwgSU5URVJWQUwgaSkKIHsKKyAg aWYgKEJVRkZFUlAgKG9iamVjdCkgJiYgWEJVRkZFUiAob2JqZWN0KSAhPSBjdXJyZW50X2J1ZmZl cikKKyAgICB7CisgICAgICBwdHJkaWZmX3QgY291bnQgPSBTUEVDUERMX0lOREVYICgpOworICAg ICAgcmVjb3JkX3Vud2luZF9jdXJyZW50X2J1ZmZlciAoKTsKKyAgICAgIHNldF9idWZmZXJfaW50 ZXJuYWwgKFhCVUZGRVIgKG9iamVjdCkpOworCisgICAgICBzZXRfdGV4dF9wcm9wZXJ0aWVzXzEg KHN0YXJ0LCBlbmQsIHByb3BlcnRpZXMsIG9iamVjdCwgaSk7CisgICAgICB1bmJpbmRfdG8gKGNv dW50LCBRbmlsKTsKKyAgICAgIHJldHVybjsKKyAgICB9CisKICAgSU5URVJWQUwgcHJldl9jaGFu Z2VkID0gTlVMTDsKICAgcHRyZGlmZl90IHMgPSBYRklYTlVNIChzdGFydCk7CiAgIHB0cmRpZmZf dCBsZW4gPSBYRklYTlVNIChlbmQpIC0gczsKQEAgLTE0OTQsNiArMTUyMywxNSBAQCBERUZVTiAo InJlbW92ZS10ZXh0LXByb3BlcnRpZXMiLCBGcmVtb3ZlX3RleHRfcHJvcGVydGllcywKIFVzZSBg c2V0LXRleHQtcHJvcGVydGllcycgaWYgeW91IHdhbnQgdG8gcmVtb3ZlIGFsbCB0ZXh0IHByb3Bl cnRpZXMuICAqLykKICAgKExpc3BfT2JqZWN0IHN0YXJ0LCBMaXNwX09iamVjdCBlbmQsIExpc3Bf T2JqZWN0IHByb3BlcnRpZXMsIExpc3BfT2JqZWN0IG9iamVjdCkKIHsKKyAgaWYgKEJVRkZFUlAg KG9iamVjdCkgJiYgWEJVRkZFUiAob2JqZWN0KSAhPSBjdXJyZW50X2J1ZmZlcikKKyAgICB7Cisg ICAgICBwdHJkaWZmX3QgY291bnQgPSBTUEVDUERMX0lOREVYICgpOworICAgICAgcmVjb3JkX3Vu d2luZF9jdXJyZW50X2J1ZmZlciAoKTsKKyAgICAgIHNldF9idWZmZXJfaW50ZXJuYWwgKFhCVUZG RVIgKG9iamVjdCkpOworICAgICAgcmV0dXJuIHVuYmluZF90byAoY291bnQsIEZyZW1vdmVfdGV4 dF9wcm9wZXJ0aWVzIChzdGFydCwgZW5kLCBwcm9wZXJ0aWVzLAorCQkJCQkJCW9iamVjdCkpOwor ICAgIH0KKwogICBJTlRFUlZBTCBpLCB1bmNoYW5nZWQ7CiAgIHB0cmRpZmZfdCBzLCBsZW47CiAg IGJvb2wgbW9kaWZpZWQgPSBmYWxzZTsKQEAgLTE2MDYsNiArMTY0NCwxNiBAQCBERUZVTiAoInJl bW92ZS1saXN0LW9mLXRleHQtcHJvcGVydGllcyIsIEZyZW1vdmVfbGlzdF9vZl90ZXh0X3Byb3Bl cnRpZXMsCiBSZXR1cm4gdCBpZiBhbnkgcHJvcGVydHkgd2FzIGFjdHVhbGx5IHJlbW92ZWQsIG5p bCBvdGhlcndpc2UuICAqLykKICAgKExpc3BfT2JqZWN0IHN0YXJ0LCBMaXNwX09iamVjdCBlbmQs IExpc3BfT2JqZWN0IGxpc3Rfb2ZfcHJvcGVydGllcywgTGlzcF9PYmplY3Qgb2JqZWN0KQogewor ICBpZiAoQlVGRkVSUCAob2JqZWN0KSAmJiBYQlVGRkVSIChvYmplY3QpICE9IGN1cnJlbnRfYnVm ZmVyKQorICAgIHsKKyAgICAgIHB0cmRpZmZfdCBjb3VudCA9IFNQRUNQRExfSU5ERVggKCk7Cisg ICAgICByZWNvcmRfdW53aW5kX2N1cnJlbnRfYnVmZmVyICgpOworICAgICAgc2V0X2J1ZmZlcl9p bnRlcm5hbCAoWEJVRkZFUiAob2JqZWN0KSk7CisgICAgICByZXR1cm4gdW5iaW5kX3RvIChjb3Vu dCwgRnJlbW92ZV9saXN0X29mX3RleHRfcHJvcGVydGllcyAoc3RhcnQsIGVuZCwKKwkJCQkJCQkJ bGlzdF9vZl9wcm9wZXJ0aWVzLAorCQkJCQkJCQlvYmplY3QpKTsKKyAgICB9CisKICAgSU5URVJW QUwgaSwgdW5jaGFuZ2VkOwogICBwdHJkaWZmX3QgcywgbGVuOwogICBib29sIG1vZGlmaWVkID0g ZmFsc2U7Ci0tIAoyLjIwLjEKCg== --000000000000327750058b5e3bcc--