From: Pip Cet <pipcet@gmail.com>
To: Naoya Yamashita <conao3@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] * src/eval.c: Stop checking for nvars, and use only CONSP
Date: Tue, 2 Mar 2021 05:34:35 +0000 [thread overview]
Message-ID: <CAOqdjBdp_Sy1cCR+umKfjO26GFhhqD0SvzPKtyT8864e+Yrtbw@mail.gmail.com> (raw)
In-Reply-To: <20210302.111043.609653289571449353.conao3@gmail.com>
On Tue, Mar 2, 2021 at 2:19 AM Naoya Yamashita <conao3@gmail.com> wrote:
> I found src/eval.c (let) has redundant conditions, that compares
> the length of the list with the current index and also checks if
> the current list is cons.
Technically, those aren't redundant. We're calling eval_sub in between
the checks, and that might modify the list of arguments.
That's not something that is supported, but it is something that
shouldn't segfault, just throw an error.
IIUC, the following will likely segfault with your patch:
(let ((cons-cell '((a 2) (b 3))))
(eval `(let ((x (setcdr ',cons-cell nil))
. ,cons-cell)
(message "foo"))))
Again, that's not code that should work. It isn't quite nasty enough
to justify a segfault, though, IMHO.
Pip
next prev parent reply other threads:[~2021-03-02 5:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 2:10 [PATCH] * src/eval.c: Stop checking for nvars, and use only CONSP Naoya Yamashita
2021-03-02 2:48 ` Stefan Monnier
2021-03-02 3:09 ` Naoya Yamashita
2021-03-02 14:31 ` Stefan Monnier
2021-03-02 15:19 ` Pip Cet
2021-03-02 15:48 ` Stefan Monnier
2021-03-02 17:04 ` Pip Cet
2021-03-02 17:44 ` Stefan Monnier
2021-03-02 19:50 ` Pip Cet
2021-03-02 23:48 ` Stefan Monnier
2021-03-02 5:34 ` Pip Cet [this message]
2021-03-02 5:41 ` Eli Zaretskii
2021-03-02 7:14 ` Naoya Yamashita
2021-03-02 7:30 ` Pip Cet
2021-03-02 14:00 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOqdjBdp_Sy1cCR+umKfjO26GFhhqD0SvzPKtyT8864e+Yrtbw@mail.gmail.com \
--to=pipcet@gmail.com \
--cc=conao3@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.