From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: Crashes in "C-h h" Date: Mon, 1 Jul 2019 15:51:30 +0000 Message-ID: References: <83y31hes6r.fsf@gnu.org> <83r279epwe.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="211694"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Andreas Schwab , eggert@cs.ucla.edu, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 01 17:52:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hhybp-000swk-Te for ged-emacs-devel@m.gmane.org; Mon, 01 Jul 2019 17:52:50 +0200 Original-Received: from localhost ([::1]:60308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhybo-0002T5-Vg for ged-emacs-devel@m.gmane.org; Mon, 01 Jul 2019 11:52:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50164) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhybT-0002SA-8k for emacs-devel@gnu.org; Mon, 01 Jul 2019 11:52:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhybO-0001HQ-I1 for emacs-devel@gnu.org; Mon, 01 Jul 2019 11:52:25 -0400 Original-Received: from mail-ot1-f49.google.com ([209.85.210.49]:34881) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hhybC-00019H-QG; Mon, 01 Jul 2019 11:52:11 -0400 Original-Received: by mail-ot1-f49.google.com with SMTP id j19so14002823otq.2; Mon, 01 Jul 2019 08:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fZ7mNiDic78SxVJZkxfg0XEZAvw4lM5FlvptqZvZiZI=; b=hMOx19YztEgJmXrxaMxH5PFGrO64vJh7RpG6h6fBVjfeFEtZ2xGs4z06eDGt+TjmB4 pVH8kyi5w6aoqcqHq0xhRASFd+0hxfJ4p9Eygexgi9HyqCwNDYhapAyayEFZozt/O8Zf e6Z4Xptqa4lOPk3CJfOHnkjNQrCFbsu/7iERF4HiGtE1YOKg8aMl/6qTxpi5D2IdO7Ct wr3LBq5GPUcxdqBRAinAV5UGjPxjvwx2KY+fVjXjc8vIPXcaYsknAcx3Z1LDbmsswls8 2n9ifgLTKHUdWp2L8zZ2scyfz7OgfcY9SEvaaAlnlgAsDuB6NnwClmkLk5+LvrqUPwxf 4Sow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fZ7mNiDic78SxVJZkxfg0XEZAvw4lM5FlvptqZvZiZI=; b=c65HdJ/BdbIRmkzi6rX+k1wjNdrp9fzI9b+0tCW4lJCQym2ewlGY76b9uVzGHsuWlk kzkH/EVNFABCjapyPcxtboZh1iGayTKHW6go6zPPhCGJvtK8JRC4wrhKGcu3DKaXCH+C zKHpev8715Biv5TsX8kegg79DrhCver9OfAuqOFLgl0iIsCsCS9I6gRI94pUGTXbuwOU w0siDrF6gCuT8Sh1C+XBIg0lM/3/0r7GULTc7DpDMylA0fkYJNsKgehwxtP7tRjuyW5G mWUdxDXPl4FI512WPEh4N3AUyER60D5pRdoPcD0JGIWY/LtJH3Wc4hL0JbjhAjvad+xM UHTQ== X-Gm-Message-State: APjAAAVjrCNmhecmIsRHpsTahzziqDS3nbE/6VsUUuUpy+5snrprb83M 1MM15GxVJaeoVl3fp273iTMX4IE3AerQZAigJkmruodqm5I= X-Google-Smtp-Source: APXvYqxwH//wJo/PhSAXN26oM/W9UQFzKw2ukNodguB+HCK1uL8TL93Xvi672qd8mCBYCU2HLEgnwOoOLZWpG/amQUM= X-Received: by 2002:a9d:664c:: with SMTP id q12mr18821963otm.175.1561996328185; Mon, 01 Jul 2019 08:52:08 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.210.49 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238273 Archived-At: > the recent XFIXNUM change. "The recent XFIXNUM change" I rather cryptically alluded to is that you're no longer allowed to call XFIXNUM on a Lisp_Object that isn't FIXNUMP; previously, this was valid in some circumstances, either because XFIXNUM (non_fixnum_object) wasn't actually ever used (FIXNUMP check after the XFIXNUM), or because the only thing that was relied on was that XFIXNUM (Qnil) == 0. There are two fixes: - check FIXNUMP - use XFIXNUM_RAW The second fix is only available to us if we're definitely sure that XFIXNUM_RAW will not be used (except, maybe, if we want to introduce a Qnil-is-0 dependency, in the case of a nil repertory). I don't think that's the case here.