From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#21317: 25.0.50; frame-resize-pixelwise has no effect (GTK, no window manager) Date: Sun, 23 Aug 2015 13:47:58 +0000 Message-ID: References: <55D8196B.3010206@gmx.at> <55D8844F.4080508@gmx.at> <55D8B57E.3010400@gmx.at> <55D9AA9D.9030807@gmx.at> <55D9C948.7040105@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=089e01182a34afb431051dfabf68 X-Trace: ger.gmane.org 1440337913 13878 80.91.229.3 (23 Aug 2015 13:51:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 23 Aug 2015 13:51:53 +0000 (UTC) Cc: 21317@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 23 15:51:45 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZTVgW-000722-1X for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Aug 2015 15:51:44 +0200 Original-Received: from localhost ([::1]:50213 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTVgV-0001k3-91 for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Aug 2015 09:51:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTVdz-0007QN-EX for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2015 09:49:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTVdv-0004B4-AF for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2015 09:49:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTVdv-0004B0-6T for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2015 09:49:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZTVdu-0000lG-Mk for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2015 09:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Aug 2015 13:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21317 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21317-submit@debbugs.gnu.org id=B21317.14403376822857 (code B ref 21317); Sun, 23 Aug 2015 13:49:02 +0000 Original-Received: (at 21317) by debbugs.gnu.org; 23 Aug 2015 13:48:02 +0000 Original-Received: from localhost ([127.0.0.1]:35691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZTVcv-0000jw-Lu for submit@debbugs.gnu.org; Sun, 23 Aug 2015 09:48:02 -0400 Original-Received: from mail-ig0-f194.google.com ([209.85.213.194]:34606) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZTVct-0000ja-3E for 21317@debbugs.gnu.org; Sun, 23 Aug 2015 09:47:59 -0400 Original-Received: by igdx6 with SMTP id x6so5447075igd.1 for <21317@debbugs.gnu.org>; Sun, 23 Aug 2015 06:47:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=dXhRQBtylGMOtAHjeyI5xyrJZw4gZPqRo9DUsx4MzOM=; b=Bj51EkbYFiayuEUiMLd1wPcIx6HxeKcgyuZn+roIJWGZZcCEgvfgkJ/6X0w5ucwer4 J7M/EEGndVpjCfp82wyw/1BlKyK5aLdC85bxyBez4lvER+CkaVQ4hYMtOH2ywGmTcc14 B9AmeuxFaHZnV28jdVeqNd+VzSOKdLLm4sf5xMCOdXY/lyBg1NPnzU9Uo4zVKXKz0jrF pl68oq6VV5FOgwpwGa4SAayMWDZesrDfUYfHO+t3EXxXrAJQhcgBIQzVSLhzzyAAw/li k42L0SBgUxdL88Ax+JACuD35EjpbarYtLXSGtRPEJ4yY0dibFns+peqAq2xVgmal6abH KZxg== X-Received: by 10.50.17.9 with SMTP id k9mr11494921igd.93.1440337678492; Sun, 23 Aug 2015 06:47:58 -0700 (PDT) Original-Received: by 10.79.78.66 with HTTP; Sun, 23 Aug 2015 06:47:58 -0700 (PDT) In-Reply-To: <55D9C948.7040105@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105729 Archived-At: --089e01182a34afb431051dfabf68 Content-Type: text/plain; charset=UTF-8 On Sun, Aug 23, 2015 at 1:23 PM, martin rudalics wrote: >> I've attached a patch that combines your patch with the minor fixes I >> suggested in the previous email. It appears to work here. > > Thanks. This > > + lval = Qnil; > + switch (f->want_fullscreen) > + { > + case FULLSCREEN_WIDTH: > + lval = Qfullwidth; > + break; > + case FULLSCREEN_HEIGHT: > + lval = Qfullheight; > + break; > + case FULLSCREEN_BOTH: > + lval = Qfullboth; > + break; > + case FULLSCREEN_MAXIMIZED: > + lval = Qmaximized; > + break; > + } > > looks a bit ugly. Can't we set lval in the switch above? I agree. > If f->want_fullscreen changed in between we'd get in hot water anyway. > > (Also I'd like to keep the patch resonably small so I can install it as > a "tiny change". Or do you have copyright papers signed for Emacs?) (No, but soon, hopefully.) I've attached the patch with a suggested ChangeLog entry (though of course you should change it to your own name). --089e01182a34afb431051dfabf68 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Fix-full-screen-code-when-there-is-no-window-manager.patch" Content-Disposition: attachment; filename="0001-Fix-full-screen-code-when-there-is-no-window-manager.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_idoju2qw0 RnJvbSAyZDlhMGVhZjU1Y2VjYTNjM2JiOTNhNTA4ZjExNWI0ZDllZTI4YTk1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXAgPHBpcGNldEBnbWFpbC5jb20+CkRhdGU6IFN1biwg MjMgQXVnIDIwMTUgMTI6MjQ6MDQgKzAwMDAKU3ViamVjdDogW1BBVENIXSBGaXggZnVsbC1zY3Jl ZW4gY29kZSB3aGVuIHRoZXJlIGlzIG5vIHdpbmRvdyBtYW5hZ2VyLgoKCSogeHRlcm0uYyAoZ2V0 X2N1cnJlbnRfd21fc3RhdGUpOiBFeHBvcnQgZnVuY3Rpb24uCgkoeF9jaGVja19mdWxsc2NyZWVu KTogQ2FsbCBgeF93bV9zZXRfc2l6ZV9oaW50JywgcmVzdG9yZQoJYGZ1bGxzY3JlZW4nIGZyYW1l IHBhcmFtZXRlci4KCgkqIGd0a3V0aWwuYyAoeF93bV9zZXRfc2l6ZV9oaW50KTogU2V0IHNpemUg aGludHMgd2hlbiBydW5uaW5nCgl3aXRob3V0IGEgd2luZG93IG1hbmFnZXIuCi0tLQogc3JjL2d0 a3V0aWwuYyB8IDE2ICsrKysrKysrKy0tLS0tLS0KIHNyYy94dGVybS5jICAgfCAyMSArKysrKysr KysrKysrKysrKystLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgMTAgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2d0a3V0aWwuYyBiL3NyYy9ndGt1dGlsLmMKaW5k ZXggZDY4NGNkOS4uOGU1M2ExNiAxMDA2NDQKLS0tIGEvc3JjL2d0a3V0aWwuYworKysgYi9zcmMv Z3RrdXRpbC5jCkBAIC0xMzUsNiArMTM1LDggQEAgYWxvbmcgd2l0aCBHTlUgRW1hY3MuICBJZiBu b3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uICAqLwogc3RhdGljIHZvaWQg dXBkYXRlX3RoZW1lX3Njcm9sbGJhcl93aWR0aCAodm9pZCk7CiBzdGF0aWMgdm9pZCB1cGRhdGVf dGhlbWVfc2Nyb2xsYmFyX2hlaWdodCAodm9pZCk7CiAKK2Jvb2wgZ2V0X2N1cnJlbnRfd21fc3Rh dGUgKHN0cnVjdCBmcmFtZSAqLCBXaW5kb3csIGludCAqLCBib29sICopOworCiAjZGVmaW5lIFRC X0lORk9fS0VZICJ4Z19mcmFtZV90Yl9pbmZvIgogc3RydWN0IHhnX2ZyYW1lX3RiX2luZm8KIHsK QEAgLTEzNjQsNyArMTM2Niw4IEBAIHhfd21fc2V0X3NpemVfaGludCAoc3RydWN0IGZyYW1lICpm LCBsb25nIGludCBmbGFncywgYm9vbCB1c2VyX3Bvc2l0aW9uKQogICBpbnQgYmFzZV93aWR0aCwg YmFzZV9oZWlnaHQ7CiAgIGludCBtaW5fcm93cyA9IDAsIG1pbl9jb2xzID0gMDsKICAgaW50IHdp bl9ncmF2aXR5ID0gZi0+d2luX2dyYXZpdHk7Ci0gIExpc3BfT2JqZWN0IGZzX3N0YXRlLCBmcmFt ZTsKKyAgaW50IHN0YXRlID0gRlVMTFNDUkVFTl9OT05FOworICBib29sIHN0aWNreSA9IGZhbHNl OwogICBpbnQgc2NhbGUgPSB4Z19nZXRfZ2RrX3NjYWxlICgpOwogCiAgIC8qIERvbid0IHNldCBz aXplIGhpbnRzIGR1cmluZyBpbml0aWFsaXphdGlvbjsgdGhhdCBhcHBhcmVudGx5IGxlYWRzCkBA IC0xMzczLDEzICsxMzc2LDEyIEBAIHhfd21fc2V0X3NpemVfaGludCAoc3RydWN0IGZyYW1lICpm LCBsb25nIGludCBmbGFncywgYm9vbCB1c2VyX3Bvc2l0aW9uKQogICBpZiAoTklMUCAoVmFmdGVy X2luaXRfdGltZSkgfHwgIUZSQU1FX0dUS19PVVRFUl9XSURHRVQgKGYpKQogICAgIHJldHVybjsK IAotICBYU0VURlJBTUUgKGZyYW1lLCBmKTsKLSAgZnNfc3RhdGUgPSBGZnJhbWVfcGFyYW1ldGVy IChmcmFtZSwgUWZ1bGxzY3JlZW4pOwotICBpZiAoRVEgKGZzX3N0YXRlLCBRbWF4aW1pemVkKSB8 fCBFUSAoZnNfc3RhdGUsIFFmdWxsYm90aCkpCisgIGdldF9jdXJyZW50X3dtX3N0YXRlIChmLCBG UkFNRV9PVVRFUl9XSU5ET1cgKGYpLCAmc3RhdGUsICZzdGlja3kpOworICBpZiAoc3RhdGUgIT0g RlVMTFNDUkVFTl9OT05FKQogICAgIHsKLSAgICAgIC8qIERvbid0IHNldCBoaW50cyB3aGVuIG1h eGltaXplZCBvciBmdWxsc2NyZWVuLiAgQXBwYXJlbnRseSBLV2luIGFuZAotICAgICAgICAgR3Rr MyBkb24ndCBnZXQgYWxvbmcgYW5kIHRoZSBmcmFtZSBzaHJpbmtzICghKS4KLSAgICAgICovCisg ICAgICAvKiBEb24ndCBzZXQgaGludHMgd2hlbiB0aGUgZnJhbWUgY3VycmVudGx5IGlzIG1heGlt aXplZCBvcgorICAgICAgICAgZnVsbHNjcmVlbi4gIEFwcGFyZW50bHkgS1dpbiBhbmQgR3RrMyBk b24ndCBnZXQgYWxvbmcgYW5kIHRoZQorICAgICAgICAgZnJhbWUgc2hyaW5rcyAoISkuICAqLwog ICAgICAgcmV0dXJuOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvc3JjL3h0ZXJtLmMgYi9zcmMveHRl cm0uYwppbmRleCBiN2FhY2ZhLi5kY2Q0NTdmIDEwMDY0NAotLS0gYS9zcmMveHRlcm0uYworKysg Yi9zcmMveHRlcm0uYwpAQCAtMjQ3LDcgKzI0Nyw3IEBAIHN0YXRpYyB2b2lkIHhfd21fc2V0X3dp bmRvd19zdGF0ZSAoc3RydWN0IGZyYW1lICosIGludCk7CiBzdGF0aWMgdm9pZCB4X3dtX3NldF9p Y29uX3BpeG1hcCAoc3RydWN0IGZyYW1lICosIHB0cmRpZmZfdCk7CiBzdGF0aWMgdm9pZCB4X2lu aXRpYWxpemUgKHZvaWQpOwogCi1zdGF0aWMgYm9vbCBnZXRfY3VycmVudF93bV9zdGF0ZSAoc3Ry dWN0IGZyYW1lICosIFdpbmRvdywgaW50ICosIGJvb2wgKik7Citib29sIGdldF9jdXJyZW50X3dt X3N0YXRlIChzdHJ1Y3QgZnJhbWUgKiwgV2luZG93LCBpbnQgKiwgYm9vbCAqKTsKIAogLyogRmx1 c2ggZGlzcGxheSBvZiBmcmFtZSBGLiAgKi8KIApAQCAtOTkwNCw3ICs5OTA0LDcgQEAgeF9zZXRf c3RpY2t5IChzdHJ1Y3QgZnJhbWUgKmYsIExpc3BfT2JqZWN0IG5ld192YWx1ZSwgTGlzcF9PYmpl Y3Qgb2xkX3ZhbHVlKQogCiAgICBSZXR1cm4gdHJ1ZSBpZmYgd2UgYXJlIG5vdCBoaWRkZW4uICAq LwogCi1zdGF0aWMgYm9vbAorYm9vbAogZ2V0X2N1cnJlbnRfd21fc3RhdGUgKHN0cnVjdCBmcmFt ZSAqZiwKICAgICAgICAgICAgICAgICAgICAgICBXaW5kb3cgd2luZG93LAogICAgICAgICAgICAg ICAgICAgICAgIGludCAqc2l6ZV9zdGF0ZSwKQEAgLTEwMTU1LDYgKzEwMTU1LDggQEAgeF9oYW5k bGVfbmV0X3dtX3N0YXRlIChzdHJ1Y3QgZnJhbWUgKmYsIGNvbnN0IFhQcm9wZXJ0eUV2ZW50ICpl dmVudCkKIHN0YXRpYyB2b2lkCiB4X2NoZWNrX2Z1bGxzY3JlZW4gKHN0cnVjdCBmcmFtZSAqZikK IHsKKyAgTGlzcF9PYmplY3QgbHZhbCA9IFFuaWw7CisKICAgaWYgKGRvX2V3bWhfZnVsbHNjcmVl biAoZikpCiAgICAgcmV0dXJuOwogCkBAIC0xMDE3MywyMiArMTAxNzUsMzEgQEAgeF9jaGVja19m dWxsc2NyZWVuIChzdHJ1Y3QgZnJhbWUgKmYpCiAgICAgICBzd2l0Y2ggKGYtPndhbnRfZnVsbHNj cmVlbikKICAgICAgICAgewogICAgICAgICAgIC8qIE5vIGRpZmZlcmVuY2UgYmV0d2VlbiB0aGVz ZSB0d28gd2hlbiB0aGVyZSBpcyBubyBXTSAqLwotICAgICAgICBjYXNlIEZVTExTQ1JFRU5fQk9U SDoKICAgICAgICAgY2FzZSBGVUxMU0NSRUVOX01BWElNSVpFRDoKKyAgICAgICAgICBsdmFsID0g UW1heGltaXplZDsKKyAgICAgICAgICB3aWR0aCA9IHhfZGlzcGxheV9waXhlbF93aWR0aCAoZHB5 aW5mbyk7CisgICAgICAgICAgaGVpZ2h0ID0geF9kaXNwbGF5X3BpeGVsX2hlaWdodCAoZHB5aW5m byk7CisgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgRlVMTFNDUkVFTl9CT1RIOgorICAg ICAgICAgIGx2YWwgPSBRZnVsbGJvdGg7CiAgICAgICAgICAgd2lkdGggPSB4X2Rpc3BsYXlfcGl4 ZWxfd2lkdGggKGRweWluZm8pOwogICAgICAgICAgIGhlaWdodCA9IHhfZGlzcGxheV9waXhlbF9o ZWlnaHQgKGRweWluZm8pOwogICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIEZVTExTQ1JF RU5fV0lEVEg6CisgICAgICAgICAgbHZhbCA9IFFmdWxsd2lkdGg7CiAgICAgICAgICAgd2lkdGgg PSB4X2Rpc3BsYXlfcGl4ZWxfd2lkdGggKGRweWluZm8pOwogCSAgaGVpZ2h0ID0gaGVpZ2h0ICsg RlJBTUVfTUVOVUJBUl9IRUlHSFQgKGYpOwogCSAgYnJlYWs7CiAgICAgICAgIGNhc2UgRlVMTFND UkVFTl9IRUlHSFQ6CisgICAgICAgICAgbHZhbCA9IFFmdWxsaGVpZ2h0OwogICAgICAgICAgIGhl aWdodCA9IHhfZGlzcGxheV9waXhlbF9oZWlnaHQgKGRweWluZm8pOwogICAgICAgICB9CiAKICAg ICAgIGZyYW1lX3NpemVfaGlzdG9yeV9hZGQKIAkoZiwgUXhfY2hlY2tfZnVsbHNjcmVlbiwgd2lk dGgsIGhlaWdodCwgUW5pbCk7CiAKKyAgICAgIHhfd21fc2V0X3NpemVfaGludCAoZiwgMCwgZmFs c2UpOworCiAgICAgICBYUmVzaXplV2luZG93IChGUkFNRV9YX0RJU1BMQVkgKGYpLCBGUkFNRV9P VVRFUl9XSU5ET1cgKGYpLAogCQkgICAgIHdpZHRoLCBoZWlnaHQpOwogCkBAIC0xMDIwMSw2ICsx MDIxMiwxMCBAQCB4X2NoZWNrX2Z1bGxzY3JlZW4gKHN0cnVjdCBmcmFtZSAqZikKIAkgIHhfc3lu YyAoZik7CiAJfQogICAgIH0KKworICAvKiBgeF9uZXRfd21fc3RhdGUnIG1pZ2h0IGhhdmUgcmVz ZXQgdGhlIGZ1bGxzY3JlZW4gZnJhbWUgcGFyYW1ldGVyLAorICAgICByZXN0b3JlIGl0LiAqLwor ICBzdG9yZV9mcmFtZV9wYXJhbSAoZiwgUWZ1bGxzY3JlZW4sIGx2YWwpOwogfQogCiAvKiBUaGlz IGZ1bmN0aW9uIGlzIGNhbGxlZCBieSB4X3NldF9vZmZzZXQgdG8gZGV0ZXJtaW5lIHdoZXRoZXIg dGhlIHdpbmRvdwotLSAKMi41LjAKCg== --089e01182a34afb431051dfabf68--