From: Pip Cet <pipcet@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Andrea Corallo <akrl@sdf.org>, emacs-devel@gnu.org
Subject: Re: Getting ready to land native-compilation on master
Date: Fri, 9 Apr 2021 16:17:15 +0000 [thread overview]
Message-ID: <CAOqdjBdSi04PB2NT_M4Z61GdKqLK2hO_sr2kVW2B5FvHSHeRPA@mail.gmail.com> (raw)
In-Reply-To: <83v98v7dzs.fsf@gnu.org>
On Fri, Apr 9, 2021 at 2:04 PM Eli Zaretskii <eliz@gnu.org> wrote:
> AFAICT, we are quite ready to land this important feature. The branch
> was tested on several systems and is in good shape: many issues and
> bugs were fixed, and currently no known issues remain that block the
> merge. (There's a lot yet to do wrt documenting the feature and its
> various aspects, but that can be done on master after merging.)
There are still (theoretical, at least) miscompilation bugs, last I
checked. I don't think these should block the merge and there's plenty
of time to fix them on the master branch.
I must say I'm unhappy with many of the changes that are introduced
outside of comp.c/comp.el (asynchronous compilation as a
default/forced-on-users feature, the .eln handling, the way
natively-compiled functions are subrs even though they have virtually
nothing in common with them...). But, again, that's also something
that can be discussed more reasonably once the branch has been merged,
and there's perhaps less of an attitude of owning the branch.
I also think that it would be reasonable to merge only the "essential"
native-compilation features at first, and leaving out things like the
half-written SSA optimizer that's currently on the branch (or was last
I checked). But my understanding is Andrea is unwilling to consider
this option, and it's much better to have a master branch that Andrea
continues to work on.
> If no significant issues pop up within a week, I will ask Andrea to
> merge the branch onto master the next weekend (i.e. around 17th of
> April).
Hooray!
> Last, but not least: I'd like to take this opportunity to thank Andrea
> for his hard work and perseverance during this last year. We would
> not be where we are now with this feature without his devotion and
> determination to see this through. Thanks a lot!
Thank you, Andrea!
Pip
next prev parent reply other threads:[~2021-04-09 16:17 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 14:02 Getting ready to land native-compilation on master Eli Zaretskii
2021-04-09 14:27 ` tomas
2021-04-09 14:33 ` Stefan Kangas
2021-04-09 14:39 ` T.V Raman
2021-04-09 16:17 ` Pip Cet [this message]
2021-04-09 16:35 ` Thierry Volpiatto
2021-04-09 18:57 ` Eli Zaretskii
2021-04-10 5:39 ` Thierry Volpiatto
2021-04-09 17:12 ` Jens C. Jensen
2021-04-09 18:53 ` Stefan Monnier
2021-04-09 18:59 ` Jens C. Jensen
2021-04-09 22:43 ` Stefan Monnier
2021-04-10 8:45 ` Jens C. Jensen
2021-04-10 13:10 ` Stefan Monnier
2021-04-09 19:08 ` Andrea Corallo via Emacs development discussions.
2021-04-09 19:14 ` Eli Zaretskii
2021-04-10 0:07 ` Andy Moreton
2021-04-10 7:23 ` Eli Zaretskii
2021-04-10 11:40 ` Andy Moreton
2021-04-09 18:09 ` Sujith Manoharan
2021-04-09 18:50 ` Eli Zaretskii
2021-04-09 18:27 ` Alex Bennée
2021-04-09 18:48 ` Andrea Corallo via Emacs development discussions.
2021-04-14 4:39 ` Pankaj Jangid
2021-04-14 6:31 ` Eli Zaretskii
2021-04-14 9:45 ` Philip Kaludercic
2021-04-14 10:14 ` Andrea Corallo via Emacs development discussions.
2021-04-14 10:35 ` Philip Kaludercic
2021-04-14 10:45 ` Eli Zaretskii
2021-04-14 10:49 ` Eli Zaretskii
2021-04-14 12:57 ` Philip Kaludercic
2021-04-14 13:10 ` Eli Zaretskii
2021-04-14 14:00 ` Philip Kaludercic
2021-04-14 14:35 ` Stefan Kangas
2021-04-14 14:42 ` Philip Kaludercic
2021-04-14 14:50 ` Stefan Monnier
2021-04-14 15:02 ` Eli Zaretskii
2021-04-14 14:37 ` Eli Zaretskii
2021-04-14 14:48 ` Dmitry Gutov
2021-04-14 17:10 ` Eli Zaretskii
2021-04-14 10:48 ` Andrea Corallo via Emacs development discussions.
2021-04-14 15:53 ` wilde
2021-04-14 17:02 ` Eli Zaretskii
2021-04-14 17:28 ` Alex Bennée
2021-04-14 17:41 ` Eli Zaretskii
2021-04-15 11:15 ` Alex Bennée
2021-04-14 18:07 ` Andrea Corallo via Emacs development discussions.
2021-04-14 20:23 ` Stefan Kangas
2021-04-14 22:01 ` Andrea Corallo via Emacs development discussions.
2021-04-15 9:25 ` wilde
2021-04-15 11:19 ` wilde
2021-04-15 16:23 ` Andrea Corallo via Emacs development discussions.
2021-04-27 16:25 ` wilde
2021-04-28 3:06 ` Corwin Brust
2021-04-28 17:52 ` Jose E. Marchesi
2021-04-29 8:20 ` Arthur Miller
2021-04-22 10:09 ` wilde
2021-04-22 11:14 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOqdjBdSi04PB2NT_M4Z61GdKqLK2hO_sr2kVW2B5FvHSHeRPA@mail.gmail.com \
--to=pipcet@gmail.com \
--cc=akrl@sdf.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.