From: Pip Cet <pipcet@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Andrea Corallo <akrl@sdf.org>, 47067@debbugs.gnu.org
Subject: bug#47067: 28.0.50; [feature/native-comp] Crash while scrolling through dispnew.c
Date: Sat, 13 Mar 2021 16:32:50 +0000 [thread overview]
Message-ID: <CAOqdjBdQEMtmqT8F0tCWF8+HTf_-vE2aZoB4H63abgOoKFFZRg@mail.gmail.com> (raw)
In-Reply-To: <83k0qbhvnh.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 4656 bytes --]
On Sat, Mar 13, 2021 at 4:21 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Pip Cet <pipcet@gmail.com>
> > Date: Sat, 13 Mar 2021 15:45:52 +0000
> > Cc: Andrea Corallo <akrl@sdf.org>, 47067@debbugs.gnu.org
> >
> > On Sat, Mar 13, 2021 at 3:27 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > > > > It's nowhere in the C backtrace, only its caller
> > > >
> > > > But it was in one of the previous backtraces?
> > >
> > > Too many moons ago. The ABI was bumped since then, and so did the
> > > *.eln files.
> >
> > The code you pasted matches c-beginning-of-statement-1, and so does
> > the Lisp backtrace, so I would suggest we go with it...
>
> I don't know how to go with it: the backtrace is truncated (for
> reasons I don't yet understand) before it gets to it.
I'm pretty sure the first ?? is c-beginning-of-stmt-1. It's a function
with five arguments, at least.
> > > > So EDI is bunk at this point. Can you go back a bit further to where
> > > > it's initialized?
> > >
> > > Sorry, I don't understand: I gave you the disassembly of 512 bytes
> > > before, isn't that enough to see where EDI is assigned the value? Or
> > > what do you mean by "go back"?
> >
> > It's not enough, no. we're looking for an insn of the form mov XXX,
> > %edi or lea XXX, %edi, or anything like that.
>
> I went back 4KB, and the only two instructions that write into EDI are
It's a long function, that might not have been enough.
> the following:
>
> 0x09e3159d: mov -0x100(%ebp),%edi
> 0x09e31c71: mov 0x9f37b9c,%edi
>
> > I'm suspicious because EDI is a register variable that is clobbered
> > somehow right after a setjmp returned. Which setjmp implementation are
> > you using?
>
> Not sure how to answer that. AFAIK, it's a setjmp from the MS runtime.
So not some mingw wrapper for it? I just checked the only "mingw"-like
sources I could find, and they don't appear to use the frame pointer
argument properly...
> > Is it possible that you're on Windows, but unlike other Windows
> > setjmps, it's unsafe to call your setjmp through a function pointer?
>
> How do I tell?
Well, you could just apply this untested patch, fix any obvious
compile errors I might not have spotted, and try to reproduce it. I'm
not currently on a Windows (or x86) machine, so it's a bit hard for me
to test...
> And why I never had any problems with setjmp elsewhere in Emacs,
> although we use it all the time in keyboard.c and elsewhere?
It's only natively-compiled code that attempts to call setjmp through
a function pointer. This was fixed in the POSIX case, but I didn't
touch the Windows code because I assumed that they used the extra
argument in their non-standard API to do this right...
> Here's an interesting factoid: while most addresses in the backtraces
> I see with this recipe are identical from run to run, the 'fun'
> arguments of funcall_lambda's aren't. Compare the backtrace I sent 3
> messages ago with this one:
>
> #0 0x01236964 in arithcompare_driver (nargs=2, args=0x28,
> comparison=ARITH_LESS) at data.c:2673
> #1 0x01236a3c in Flss (nargs=2, args=0x28) at data.c:2691
> #2 0x09e32285 in ?? ()
> #3 0x01261a74 in funcall_lambda (fun=XIL(0xa000000007650188), nargs=5,
> arg_vector=0x826a08) at eval.c:3292
> #4 0x012603c9 in Ffuncall (nargs=6, args=0x826a00) at eval.c:3013
> #5 0x09ea0dbf in ?? ()
> #6 0x012603c9 in Ffuncall (nargs=1, args=0x826bd8) at eval.c:3013
> #7 0x09e8e041 in ?? ()
> #8 0x01261a74 in funcall_lambda (fun=XIL(0xa00000000778d5b8), nargs=1,
> arg_vector=0x826db8) at eval.c:3292
> #9 0x012603c9 in Ffuncall (nargs=2, args=0x826db0) at eval.c:3013
> #10 0x70895b36 in F632d666f6e742d6c6f636b2d6375742d6f66662d6465636c617261746f7273_c_font_lock_cut_off_declarators_0 ()
> from d:\usr\eli\.emacs.d\eln-cache\28.0.50-7d88f6c1\cc-fonts-d7d8a7f5-b7c359cd.eln
> #11 0x01261a74 in funcall_lambda (fun=XIL(0xa000000007785f78), nargs=1,
> arg_vector=0x827050) at eval.c:3292
> #12 0x012603c9 in Ffuncall (nargs=2, args=0x827048) at eval.c:3013
> #13 0x068daf93 in ?? ()
> #14 0x012dea14 in helper_save_restriction () at comp.c:4575
> #15 0x0122eb86 in wrong_type_argument (predicate=XIL(0x892404890c245c89),
> value=XIL(0x8244c89e45d8be0)) at data.c:143
> Backtrace stopped: previous frame inner to this frame (corrupt stack?)
>
> Note how arguments to Funcall's are the same, whereas arguments to
> funcall_lambda's aren't. Even the garbage in the 2 arguments to
> wrong_type_argument are identical.
Which non-stack addresses are invariant in that backtrace?
> Sounds like something is uninitialized somewhere? Hmm...
Maybe...
Pip
[-- Attachment #2: bug46824.diff --]
[-- Type: text/x-diff, Size: 1056 bytes --]
diff --git a/src/comp.c b/src/comp.c
index b24fcb5bf5a99..ce3ad22b30576 100644
--- a/src/comp.c
+++ b/src/comp.c
@@ -1946,6 +1946,11 @@ emit_setjmp (gcc_jit_rvalue *buf)
return gcc_jit_context_new_call (comp.ctxt, NULL, f, 1, args);
#else
/* _setjmp (buf, __builtin_frame_address (0)) */
+ gcc_jit_param *params[] =
+ {
+ gcc_jit_context_new_param (comp.ctxt, NULL, comp.void_ptr_type, "buf"),
+ gcc_jit_context_new_param (comp.ctxt, NULL, comp.unsigned_type, "ret"),
+ };
gcc_jit_rvalue *args[2];
args[0] =
@@ -1959,8 +1964,14 @@ emit_setjmp (gcc_jit_rvalue *buf)
"__builtin_frame_address"),
1, args);
args[0] = buf;
- return emit_call (intern_c_string (STR (SETJMP_NAME)), comp.int_type, 2, args,
- false);
+ gcc_jit_function *f =
+ gcc_jit_context_new_function (comp.ctxt, NULL,
+ GCC_JIT_FUNCTION_IMPORTED,
+ comp.int_type, STR (SETJMP_NAME),
+ ARRAYELTS (params), params,
+ false);
+
+ return gcc_jit_context_new_call (comp.ctxt, NULL, f, 2, args);
#endif
}
next prev parent reply other threads:[~2021-03-13 16:32 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 11:27 bug#47067: 28.0.50; [feature/native-comp] Crash while scrolling through dispnew.c Eli Zaretskii
2021-03-11 12:19 ` Eli Zaretskii
2021-03-11 14:07 ` Eli Zaretskii
2021-03-12 6:46 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-12 8:10 ` Eli Zaretskii
2021-03-12 12:04 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-12 12:51 ` Eli Zaretskii
2021-03-12 15:27 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-12 15:50 ` Eli Zaretskii
2021-03-12 16:08 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-12 16:14 ` Eli Zaretskii
2021-03-12 19:30 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-12 19:48 ` Eli Zaretskii
2021-03-12 20:21 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-13 7:11 ` Eli Zaretskii
2021-03-13 19:51 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-13 20:07 ` Eli Zaretskii
2021-03-13 20:20 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-14 7:19 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-14 8:02 ` Eli Zaretskii
2021-03-14 8:10 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-14 19:29 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-13 19:48 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-12 16:23 ` Eli Zaretskii
2021-03-12 19:04 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-12 19:32 ` Eli Zaretskii
2021-03-12 20:10 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-13 8:34 ` Eli Zaretskii
2021-03-19 9:42 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-19 12:10 ` Eli Zaretskii
2021-03-19 14:05 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-19 14:09 ` Eli Zaretskii
2021-03-20 9:52 ` Eli Zaretskii
2021-03-21 8:26 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-21 9:52 ` Eli Zaretskii
2021-03-21 11:56 ` Eli Zaretskii
2021-03-21 14:37 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-21 15:34 ` Eli Zaretskii
2021-03-21 15:41 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-21 15:54 ` Eli Zaretskii
2021-03-21 16:41 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-21 17:01 ` Eli Zaretskii
2021-03-21 18:36 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-25 16:51 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-25 17:03 ` Eli Zaretskii
2021-03-25 20:24 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-25 20:43 ` Eli Zaretskii
2021-04-04 20:52 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-05 15:06 ` Eli Zaretskii
2021-04-05 16:09 ` Eli Zaretskii
2021-04-05 17:58 ` Eli Zaretskii
2021-04-06 13:17 ` Eli Zaretskii
2021-04-06 13:29 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-06 13:53 ` Eli Zaretskii
2021-04-06 14:01 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-05 18:45 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-05 18:04 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-05 18:19 ` Eli Zaretskii
2021-04-05 18:47 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-05 19:22 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-06 15:49 ` Eli Zaretskii
2021-04-06 16:06 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-06 16:09 ` Eli Zaretskii
2021-03-21 14:36 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-12 18:42 ` Pip Cet
2021-03-12 19:50 ` Eli Zaretskii
2021-03-13 8:18 ` Pip Cet
2021-03-13 8:47 ` Eli Zaretskii
2021-03-13 8:53 ` Pip Cet
2021-03-13 11:10 ` Eli Zaretskii
2021-03-13 11:23 ` Eli Zaretskii
2021-03-13 11:24 ` Pip Cet
2021-03-13 15:27 ` Eli Zaretskii
2021-03-13 15:45 ` Pip Cet
2021-03-13 16:21 ` Eli Zaretskii
2021-03-13 16:32 ` Pip Cet [this message]
2021-03-13 16:53 ` Eli Zaretskii
2021-03-13 17:10 ` Pip Cet
2021-03-13 17:26 ` Eli Zaretskii
2021-03-13 18:55 ` Pip Cet
2021-03-13 19:43 ` Eli Zaretskii
2021-03-13 20:53 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-13 21:00 ` Pip Cet
2021-03-13 21:07 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-13 21:11 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-14 6:07 ` Eli Zaretskii
2021-03-14 6:53 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-14 7:21 ` Eli Zaretskii
2021-03-14 7:31 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-14 7:48 ` Eli Zaretskii
2021-03-14 8:02 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-14 8:06 ` Pip Cet
2021-03-14 11:39 ` Eli Zaretskii
2021-03-14 11:44 ` Pip Cet
2021-03-14 12:08 ` Eli Zaretskii
2021-03-14 12:09 ` Pip Cet
2021-03-14 12:17 ` Pip Cet
2021-03-14 13:31 ` Eli Zaretskii
2021-03-14 14:08 ` Eli Zaretskii
2021-03-14 18:47 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <83mtv5frr4.fsf@gnu.org>
2021-03-14 20:30 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-15 18:36 ` Eli Zaretskii
2021-03-15 20:17 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-16 13:25 ` Eli Zaretskii
2021-03-14 8:03 ` Pip Cet
2021-03-14 5:55 ` Eli Zaretskii
2021-03-14 6:57 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-14 8:20 ` Eli Zaretskii
2021-03-13 17:09 ` Eli Zaretskii
2021-03-14 12:17 ` Eli Zaretskii
2021-03-14 19:00 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-14 19:48 ` Eli Zaretskii
2021-03-14 20:36 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-15 3:24 ` Eli Zaretskii
2021-03-13 20:03 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOqdjBdQEMtmqT8F0tCWF8+HTf_-vE2aZoB4H63abgOoKFFZRg@mail.gmail.com \
--to=pipcet@gmail.com \
--cc=47067@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.