From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] * src/eval.c: Stop checking for nvars, and use only CONSP Date: Tue, 2 Mar 2021 07:30:47 +0000 Message-ID: References: <20210302.111043.609653289571449353.conao3@gmail.com> <83ft1e6rjb.fsf@gnu.org> <20210302.161418.2185996023660309707.conao3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14844"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eliz@gnu.org, emacs-devel@gnu.org To: Naoya Yamashita Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 02 08:32:40 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGzWK-0003kb-Ep for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Mar 2021 08:32:40 +0100 Original-Received: from localhost ([::1]:38596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGzWJ-0002tM-Dn for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Mar 2021 02:32:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGzV9-00021V-Mf for emacs-devel@gnu.org; Tue, 02 Mar 2021 02:31:27 -0500 Original-Received: from mail-ot1-x336.google.com ([2607:f8b0:4864:20::336]:37438) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGzV7-0000GP-Q0; Tue, 02 Mar 2021 02:31:27 -0500 Original-Received: by mail-ot1-x336.google.com with SMTP id g8so15482356otk.4; Mon, 01 Mar 2021 23:31:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=af3zCZktZKP60pc1lNawETVHNOP2EOGtJ/COr1MEL3g=; b=IApQVVaTfsL5GwjcOh+RVvpwNYI+8cLDYTcjIF0QUmQF7WKLwGCDa1Sfa+XfIA7P48 dT8hYVzcee8AFZm+RnDOcIhwH4UtWXkK68hi6Z+zJQ5WpI85G06maHognL99UFw+g3jJ 8f9vr2bbNoyJwb9FNV57B1/7jL6r5N3PMB6diZnrvypwh6yrXouriDTaoDfUG9Lz5UGF Hn8VuJdxVEJ+LLLViwdd2qivmTcRVjq7WXu8UTBAdCgB+IUqg0gu3uxYQqnBxzrO/rbO YHOnOODbbUdS4YzQsExcEQJJO+YPyLqq5YL+VkkPzhXacPuYhkvbWZCJSjbySJDwF81P fOUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=af3zCZktZKP60pc1lNawETVHNOP2EOGtJ/COr1MEL3g=; b=IfrvJozmKNYjqOttVrqy8xkb4E/BmKquGEMzYntUJjlHQ+MueDcedPSMY165CtKStV NJ/X0JTWQ8O9A5i4b2Y2+zb4yzDuGKTHDKPwSon16lj6/Jro7orpz0Tj9y0o6InxRRgC lWe+QFyN05LwgCiaqsI5hH+nyuIBCqJHsp88h5B1OsrWEFq2LUFxWwOc5GE7FRuotjVa c+JxESmCePT+K7Jxw619ogmHa/hmem3I8HnnDbajDrEvb2+wZ+B/J48SKO72gfY0pWI4 RIrdnGklNmMJ2Lj5r38HrZ+V/pqIOnjeyF5oBDPVuA+m7n9Xhl7TbL6orIXXMgG7SMcm 2siQ== X-Gm-Message-State: AOAM532Ze6vMT1LGnMlBbn9PCDVAyh/p9AvObst0dII99QHiJNAreGkw 58Xpr0KDtANSIm1V/m3PlqLDqyt1y9w8yM3JQvw= X-Google-Smtp-Source: ABdhPJxZXU2UzqS3KIm87H9Mr/2NCTli59pZ9ujZ2Nh3seZfTPGV7rcnNLWlQkqh7uFTGwZJfWWdFNoWLU3Ihrt80UQ= X-Received: by 2002:a05:6830:3090:: with SMTP id f16mr16759674ots.292.1614670284314; Mon, 01 Mar 2021 23:31:24 -0800 (PST) In-Reply-To: <20210302.161418.2185996023660309707.conao3@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::336; envelope-from=pipcet@gmail.com; helo=mail-ot1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_FILL_THIS_FORM_SHORT=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265812 Archived-At: On Tue, Mar 2, 2021 at 7:15 AM Naoya Yamashita wrote: > My patched Emacs does not segfault the Pip example either. > > (let ((cons-cell '((a 2) (b 3)))) > (eval `(let ((x (setcdr ',cons-cell nil)) > . ,cons-cell) > (message "foo")))) > ;;=> foo Sorry, I had misunderstood what you were changing about the code. This crashes: (let ((cell '((a 3)))) (eval `(let ((a (setcdr ',cell ',cell)) . ,cell) (message "foo")))) (Please keep in mind such crashes are hard to predict; if I wrote my example the way I intended, it should exhaust the stack on pretty much all machines, but it might still work, by sheer accident, on yours). Pip