From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#30373: [PATCH] Implement finalizers for module functions (Bug#30373) Date: Fri, 3 Jan 2020 18:53:46 +0000 Message-ID: References: <20191226000417.69183-1-phst@google.com> <83v9psgz1x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="22196"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 30373@debbugs.gnu.org, Philipp Stephani , sjindel@google.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 03 19:55:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1inS6K-0005eT-71 for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Jan 2020 19:55:12 +0100 Original-Received: from localhost ([::1]:55788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inS6I-0003H2-Px for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Jan 2020 13:55:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54322) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inS6B-0003Gw-Hd for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2020 13:55:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1inS6A-0002RD-8y for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2020 13:55:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35473) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1inS6A-0002Pa-3W for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2020 13:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1inS6A-0003cH-0z for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2020 13:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Jan 2020 18:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30373 X-GNU-PR-Package: emacs Original-Received: via spool by 30373-submit@debbugs.gnu.org id=B30373.157807767213861 (code B ref 30373); Fri, 03 Jan 2020 18:55:01 +0000 Original-Received: (at 30373) by debbugs.gnu.org; 3 Jan 2020 18:54:32 +0000 Original-Received: from localhost ([127.0.0.1]:41446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inS5f-0003bV-TU for submit@debbugs.gnu.org; Fri, 03 Jan 2020 13:54:32 -0500 Original-Received: from mail-ot1-f51.google.com ([209.85.210.51]:38894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inS5d-0003bI-V1 for 30373@debbugs.gnu.org; Fri, 03 Jan 2020 13:54:30 -0500 Original-Received: by mail-ot1-f51.google.com with SMTP id d7so57825487otf.5 for <30373@debbugs.gnu.org>; Fri, 03 Jan 2020 10:54:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yzpNMlr06XxHf6jJjFPNP3pG8pj9pp/dvHOGS88XDPo=; b=A0HPBPutzgOfkUNZPVREgPa0GoCEmWzI1QZQ5ZXl9HY7GdtPLlmBO4hFoACUcXg34b BqH7jLnr61nPMjyYsX03oQxBHmTI6Hyc8lE+iTxA0jiK9I6EdWZL2z2/Ng9xRGHhmTSl zvInvsvHlPlM5aSlek40Y4Efk9Tbcwv+I9saasPtYcjvP662BuRwupUH1ZKyhR0mkVXN R+0i9kLymqnHwlsrHD0fI+zxBHyyK9pMT97+kPfxkEgYC9KoEUgH/4PTX3Wuy5TwiRes PLUBUeYNidiok4mtHT6rEXSZEjwB4xtcVGt8TROneW7PznUjnh+C79JxNt4IXdb7k+4s KbTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yzpNMlr06XxHf6jJjFPNP3pG8pj9pp/dvHOGS88XDPo=; b=qsd11kKx09YY/Z5mMgPfKsb4CvRy4GfzVPJruOol0OGXh3UdhRerGvt0zjMUNBG6BN grBLMMUxC5TKPQwse4+oonPpaQEcjDU7VZa6DbNEftn3E3r0uTTpMDvjQo/pG7W+8pyS heEdHRGYSKY7jt+yGWNIyckMjlWTdWlwZiWtSJ2HMt1AmsrwwexEPJuqO/PVNPBNb3gk OKA5+74m0wxJg6MckoyPTz/hA9Twf+anRsREjIqzaE0IIayOQTUX+AwnT1RSPE8lurmn z2kEYS4N8g6N9Z5rEa58YCcUwQmPn7IlRBP/tYXD5LUs4Ukj5jTzdcQiJ2sxbaJ5/D9c P1tQ== X-Gm-Message-State: APjAAAXpp2lahPDqbB9tS/RXBsHL3mJqIAu9XLZu5R6bmtvX2g1q6iyq NdqQNU5XgTRHBqxjgP+q+aZmq/tX/RUsgO9Vmmg= X-Google-Smtp-Source: APXvYqx+SSTcq88Iy19rI+MMKQCZckNc2I2hUVu4Pkt9W8gSnMGbWbz/aM+UD3Xkjh/hUXOdR1z2LcsZ42AoHFBqn+Y= X-Received: by 2002:a05:6830:1bd5:: with SMTP id v21mr105942026ota.154.1578077662897; Fri, 03 Jan 2020 10:54:22 -0800 (PST) In-Reply-To: <83v9psgz1x.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:174130 Archived-At: On Fri, Jan 3, 2020 at 6:45 PM Eli Zaretskii wrote: > The new test fails for me on MS-Windows: > > Test module/function-finalizer backtrace: > signal(ert-test-failed (((should (equal (mod-test-function-finalizer > ert-fail(((should (equal (mod-test-function-finalizer-calls) expecte > (if (unwind-protect (setq value-370 (apply fn-368 args-369)) (setq f > (let (form-description-372) (if (unwind-protect (setq value-370 (app > (let ((value-370 'ert-form-evaluation-aborted-371)) (let (form-descr > (let* ((fn-368 #'equal) (args-369 (condition-case err (let ((signal- > (let* ((previous-calls (mod-test-function-finalizer-calls)) (expecte > (closure (t) nil (mod-test-make-function-with-finalizer) (let* ((pre > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > ert-run-test(#s(ert-test :name module/function-finalizer :documentat > ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m > ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type > ert-run-tests-batch((not (tag :unstable))) > ert-run-tests-batch-and-exit((not (tag :unstable))) > eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) > command-line-1((#("-L" 0 2 (charset cp862)) #(";." 0 2 (charset cp86 > command-line() > normal-top-level() > Test module/function-finalizer condition: > (ert-test-failed > ((should > (equal > (mod-test-function-finalizer-calls) > expected-calls)) > :form > (equal > (0 0) > (1 0)) > :value nil :explanation > (list-elt 0 > (different-atoms > (0 "#x0" "? ") > (1 "#x1" "? "))))) > FAILED 26/27 module/function-finalizer (0.109375 sec) If I'm reading the test correctly, it depends on garbage-collect actually collecting an unreferenced vector; since our GC's conservative, that might not be working for you, if a word that happens to look like a reference to the vector is still on the stack. (Or it might be something else entirely, but I don't think the test as it stands is correct).