From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#38748: 28.0.50; crash on MacOS 10.15.2 Date: Wed, 8 Jan 2020 19:18:15 +0000 Message-ID: References: <20191226130420.GB71460@breton.holly.idiocy.org> <83fth7qa3a.fsf@gnu.org> <83blrtq2j0.fsf@gnu.org> <83sgl3lyii.fsf@gnu.org> <834kxej6lc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="38598"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38748@debbugs.gnu.org, alan@idiocy.org, Andrii Kolomoiets , jguenther@gmail.com To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 08 20:19:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ipGrI-0015bB-HO for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Jan 2020 20:19:12 +0100 Original-Received: from localhost ([::1]:48286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipGrH-0002wW-C4 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Jan 2020 14:19:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44526) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipGr8-0002wA-Tu for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2020 14:19:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipGr7-0003WZ-VO for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2020 14:19:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45378) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ipGr7-0003WQ-SF for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2020 14:19:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ipGr7-00077i-NR for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2020 14:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jan 2020 19:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38748 X-GNU-PR-Package: emacs Original-Received: via spool by 38748-submit@debbugs.gnu.org id=B38748.157851113827373 (code B ref 38748); Wed, 08 Jan 2020 19:19:01 +0000 Original-Received: (at 38748) by debbugs.gnu.org; 8 Jan 2020 19:18:58 +0000 Original-Received: from localhost ([127.0.0.1]:51351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipGr4-00077R-JP for submit@debbugs.gnu.org; Wed, 08 Jan 2020 14:18:58 -0500 Original-Received: from mail-ot1-f46.google.com ([209.85.210.46]:46108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipGr2-00077E-Vn for 38748@debbugs.gnu.org; Wed, 08 Jan 2020 14:18:57 -0500 Original-Received: by mail-ot1-f46.google.com with SMTP id r9so4643635otp.13 for <38748@debbugs.gnu.org>; Wed, 08 Jan 2020 11:18:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=l9clJ0pgeneYvyI5dj2CSQ3dNKky8TmVZagXWJh8FRI=; b=MAMJ+CXHSomVe6zwf5RRwPThUA8PF3VvcbrQZecfQ8eiwzDY8W8V7BereM4hgvGjJr 2q7+u2qzX89dOWbTszrOpN1YIRw+3sgWvr1LMjWsSsJIdKYEXerM/ubKbVLVR4FbJ6MG K9PopTRy0kONnegufMr+L+CA+hHe15qZuWBkBGKE4uMu33H8hHqDH7J5E7zX384jyeYs 45RbANjZxZwHKYz9cRGVLN+yxLBMDHHM1w+Ag/Y1dxKHJmCnSJ0jijefHFnMW9dNvrO3 ijCQxTAKYqwvNaM6F9ChESA8vNq8bmmEm9c3Asa8gdTrjus0E9gxOagVvxvPZrohz2mC TdcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=l9clJ0pgeneYvyI5dj2CSQ3dNKky8TmVZagXWJh8FRI=; b=L96VR13zGUGoVlhkC3aydI22TWRyJFGHHONAHOQWrzhtBDqVb5m2Xxr/mjnAV0XouP dcWpz+ZPK+OuALbRK80L49syol4PcmvXNzYcm8W470BSXb9s/tjRcql09eMuDk4AjkiX sv6129H8QYjsyfR0QuKqnOVxn7B8906o1lNMEXYCGZMimbsWjvEQtLh3qqDPZSqaPq2k q2PAROECrLbkbtXiI+/UsbhKRv0lLMOQp/vb9Fp1Foczkw5boa0ElfMbHVvNzY0GZCLX WIl21LcS1hbwSbbzWNKPCnc2LzkyDGWEzPX0w2n9QzDzHGJmnhTXYjzexrs909n0v7l8 EDNg== X-Gm-Message-State: APjAAAXfuqluykLAALBZPrjGgBhJgXhcSGa9GNr9daEfrkSRS2xR85RF Iqpb0uIRzvGThhJJfElt5dp93tpZCzjWuK7mVAk= X-Google-Smtp-Source: APXvYqyVxa5AwfjbiuSD7a1cPCgpOkSmAlUfWEXsFU/P6Ku9hlsDUIv9De7zDleDKgq40XGTrkDEiXGJbriom0xRgLo= X-Received: by 2002:a9d:4805:: with SMTP id c5mr5496332otf.292.1578511131281; Wed, 08 Jan 2020 11:18:51 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:174378 Archived-At: On Wed, Jan 8, 2020 at 5:40 PM Robert Pluim wrote: > >> But I found the commit after which error is occurs:> >> b2949d= 39261e82c33572ba8a250298ef0b165b95 > >> > >> Commenting out that 'ok =3D false;' line make Emacs works without = errors. > > I can confirm this. I think we should disassemble the two versions and see where the differences are, unless this is too difficult because of inlining. Can you provide compiler details? > Eli> I cannot explain how that change could cause any harm. Here's t= he > Eli> relevant code fragment: > Eli> So how could the initial value of 'ok' matter here? What am I > Eli> missing? I think it's likely to be the stack thing; the ok =3D false might make the difference between allocating inherited_attrs on the stack once and doing so once per recursion of face_inherited_attr. The latter case might lead to a stack overflow more easily. > Yes. I=CA=BCll note that when this happens there are over 9000 stackframe= s, > so perhaps it=CA=BCs stack exhaustion. macOS has a default stack of 8192 > kB, I=CA=BCll see if increasing it helps. That does sound like infinite recursion, or infinite recursion waiting for something to change asynchronously that breaks the loop. If the "ok =3D false" prevents the compiler from recognizing face_inherited_attr is effectively tail-recursive, that might be it? Changing the line to "ok =3D true" would be an interesting experiment.