From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: Merging bignum to master Date: Sun, 12 Aug 2018 11:48:01 +0000 Message-ID: References: <877ekwu1mn.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1534100504 9793 195.159.176.226 (12 Aug 2018 19:01:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 12 Aug 2018 19:01:44 +0000 (UTC) Cc: emacs-devel@gnu.org To: tom@tromey.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 12 21:01:40 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fovcR-0002Ro-Rd for ged-emacs-devel@m.gmane.org; Sun, 12 Aug 2018 21:01:39 +0200 Original-Received: from localhost ([::1]:36044 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foveY-0008Sy-Hi for ged-emacs-devel@m.gmane.org; Sun, 12 Aug 2018 15:03:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fovdq-0008Sk-W8 for emacs-devel@gnu.org; Sun, 12 Aug 2018 15:03:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fovdq-0006v3-7k for emacs-devel@gnu.org; Sun, 12 Aug 2018 15:03:07 -0400 Original-Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]:42722) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fovdp-0006uc-Uh for emacs-devel@gnu.org; Sun, 12 Aug 2018 15:03:06 -0400 Original-Received: by mail-lf1-x12f.google.com with SMTP id u202-v6so9773576lff.9 for ; Sun, 12 Aug 2018 12:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ScFTL5rn3uj/tfIiDi+6JB3wMXkqjOtddIu0J0h37as=; b=OybZSZxyPeKaOzgBxibxK0qapFz/qBFt+2ESrdbkUknIzy4X2730QeL52TeDN8Kv6/ icph7mXgMGAnqXCP8bXiHved0mhSJBXjLYy6VHc3mWzTgil6KufotwKbYL7OnVWdgcg9 QZ+7dyr42yrronDa/W3YjM8N+Xml4KMiCDVfbjQI3uDR9KIKkOKLHyznqC21szqKj0f4 owUSBjSzVrwMaAfIXjhTHcUSmlFRnMbhlWSahnIkewqURZkF21ufetxNXyKzZ8XHcNKx T3xskerIM4CD3ZleeYP5/N5mPU4YCfl5uYJUyFK63o90tKk04yhMSHIk/F401xL+2F+H o5/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ScFTL5rn3uj/tfIiDi+6JB3wMXkqjOtddIu0J0h37as=; b=edsXjNvZvmpoK2X7OI3qVI7UJbp0WtRkJhlB99a+2XPbK84B+X2BUY4uE9wkEECdPM JjFFv0zLplH7jgrRpWO3crFWkXt5zHztgfUERQnwJa3YQf+LS4cYhFu6WMi0WNkoc3iy gegwWAztw3Keir6XQUSCPBSTdToUFXJtSmv0mwUk2xrteP1MqBoCRSWLAVXYLgVehKp3 DYh+iSwpDGl+49ECZsOeCiIOvir5dxyFpwgRdXcrK7196w9g5uV2+YDvYG2XHIi59t4v 1ZX7xpHuY9svRQS8h5skCMz5oDiGpRvd+X4HPxtirhygGTJ/3GHbphkfIEsTDgCI/cQs RVNw== X-Gm-Message-State: AOUpUlGqJvFXZVE2+F0bMKQ+98hYW4un0zWlpKcTILEy17nCxHeNZzsb Zc0iDbUaHSYrFi+89RumXYZauZOcLbnBEbZMJ6gl6A== X-Google-Smtp-Source: AA+uWPw51iQ7E6e6gErh8F+looQQFvGuUvVFx4gXBXaFNa0C1mqOGNn3p37BWya5Ux22MS+j0Ia0XIrEd7vvXpjHxBw= X-Received: by 2002:a19:ea5c:: with SMTP id i89-v6mr8333122lfh.19.1534074519172; Sun, 12 Aug 2018 04:48:39 -0700 (PDT) In-Reply-To: <877ekwu1mn.fsf@tromey.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::12f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228455 Archived-At: On Sat, Aug 11, 2018 at 7:48 PM Tom Tromey wrote: > I'm merging bignum to master now, then I'm going to delete the > now-obsolete feature branch. Please report any problems you find. Thank you for all your work! I notice that there are a few places where you use XFIXNUMPTR directly, rather than make_mint_ptr. Is that intentional? I think now would be a good time to fix it and make XFIXNUMPTR internal to lisp.h. Also, the doc comments for most_negative_fixnum and most_positive_fixnum in data.c still need updating.