From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#41321: 27.0.91; Emacs aborts due to invalid pseudovector objects Date: Sat, 30 May 2020 19:06:29 +0000 Message-ID: References: <83zha8cgpi.fsf@gnu.org> <4bab5f55-95fe-cf34-e490-1d4319728395@cs.ucla.edu> <837dwyvi74.fsf@gnu.org> <1484f569-c260-9fb0-bfe1-67897de289d3@cs.ucla.edu> <83blm9tn4j.fsf@gnu.org> <4aeb8963-4fd1-fcd4-e6e1-be409ab54775@cs.ucla.edu> <83tuzzrk30.fsf@gnu.org> <749bc7d0-6376-ec2e-7f84-dcd3a3cea465@cs.ucla.edu> <83sgfjqn49.fsf@gnu.org> <83eer2m0b6.fsf@gnu.org> <83367hn624.fsf@gnu.org> <831rn1mzgp.fsf@gnu.org> <8cc638f5-9df2-903f-7fc0-84919c6d872f@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="111684"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41321@debbugs.gnu.org, Stefan Monnier To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 30 21:08:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jf6q3-000SwD-0w for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 May 2020 21:08:11 +0200 Original-Received: from localhost ([::1]:46280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jf6q1-0006Xo-Ol for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 May 2020 15:08:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jf6pu-0006XX-Ar for bug-gnu-emacs@gnu.org; Sat, 30 May 2020 15:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47688) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jf6pu-0002Hv-1k for bug-gnu-emacs@gnu.org; Sat, 30 May 2020 15:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jf6pt-0003u3-SM for bug-gnu-emacs@gnu.org; Sat, 30 May 2020 15:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 May 2020 19:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41321 X-GNU-PR-Package: emacs Original-Received: via spool by 41321-submit@debbugs.gnu.org id=B41321.159086563314946 (code B ref 41321); Sat, 30 May 2020 19:08:01 +0000 Original-Received: (at 41321) by debbugs.gnu.org; 30 May 2020 19:07:13 +0000 Original-Received: from localhost ([127.0.0.1]:59234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf6p6-0003t0-UW for submit@debbugs.gnu.org; Sat, 30 May 2020 15:07:13 -0400 Original-Received: from mail-oi1-f173.google.com ([209.85.167.173]:38398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf6p5-0003sm-Ue for 41321@debbugs.gnu.org; Sat, 30 May 2020 15:07:12 -0400 Original-Received: by mail-oi1-f173.google.com with SMTP id c194so862908oig.5 for <41321@debbugs.gnu.org>; Sat, 30 May 2020 12:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gpfIBgtFnndXmA7qmyWUPFeQQGhVIFjEVWW4WclXTnc=; b=ulYPSfRfT30JeQ9aYlaZUO7fD5zfAAtOQHWorYg3zenp+S9INToCclfUQAeqs4/RrU trc2H5NN8sr0ONONXvSXQcoikGGk0HgESEuBe9flqXbZWz6Qj/gsd906sww21NYV+odF eTN4dMq0em3VqsycZJencItttOLOVICyOHCqkjLrm3l0wZcY6EM+aGP054RQUxU4kP4y 78uA/KgF7ADuUoPHkPzzvQ39/b3wrNowTWqNlyc/kUcw3p1uZlPGhhscuWIQl+mozv3J V/lNqP1renXOPEP+gT3yjiy1Y2ZbivswIpy+82uecHaXZ0Q6UOaV/Rf9UiDrdLaip/xa rJZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gpfIBgtFnndXmA7qmyWUPFeQQGhVIFjEVWW4WclXTnc=; b=iw3IoHKuWW17fQoMgXFSsXKY53AIloQADj3qLbXDzhy0e65z9TZgEU4+6uG9z1wa1D 1ZT8vzTvCN2XqA2PzPomw/nD1lL4Hf9weplELI9zKX6ObRBn3y6p6Lh01SaDMNH+LXcW gzD+5e2evhnpo4c7PA4MpKp7tCPbEiJPum7p3okA9tjdcuHfM0YP6dUjw10AZRTgonAv Kr11ehKBAleZ50TySd4VG5wVWx+2W+BrGsVnmkLWNIq9roz6XlEzC7jW6VdXHCEMIFVZ xoYCm3UmOOAh2OAHEQy+SjD/n+xyNP7YgsQcgrcCOvUqMS1FKONXeP6DgbY29nCFy0WG OXiQ== X-Gm-Message-State: AOAM5318n1+8/Djm0xoG9nRCOHaco7vR/RSv4aIO1DdJLKkTPIXpDSOc 7iIsfZXb78s9WKYp6YqburYfysca84+CU1InvDI= X-Google-Smtp-Source: ABdhPJw32oUcRFAXv7TT30rkiIL3vjDEEaDoqFi2iB1lM+jV/oZw3H6IWEyzvd+8jyIpFq/futV67jzw6md4wsd3bxQ= X-Received: by 2002:a05:6808:1c8:: with SMTP id x8mr9869927oic.30.1590865626264; Sat, 30 May 2020 12:07:06 -0700 (PDT) In-Reply-To: <8cc638f5-9df2-903f-7fc0-84919c6d872f@cs.ucla.edu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181257 Archived-At: On Sat, May 30, 2020 at 6:57 PM Paul Eggert wrote: > On 5/30/20 11:39 AM, Pip Cet wrote: > > I fail to see the problem > > with my patch. mark_maybe_object is unnecessary on x86 > > --with-wide-int, and mark_maybe_pointer (off + lispsym) is unnecessary > > on platforms that don't rip apart our precious Lisp_Objects. The other > > call to mark_maybe_pointer isn't skipped. > > The other alloc.c code is inconsistent with respect to the > live_*_holding versus live_*_p functions. There is no live_float_holding > function, Indeed. There's just live_float_p. > which means we're relying entirely on mark_maybe_object to > find roots that contain Lisp floats. No, we're not. There's code in mark_maybe_pointer to handle the float case, by calling live_float_p. Is it misaligned pointers into floats you're worried about? > So it's dicey that your earlier > (Bug#41321#299) patch skips the call to mark_maybe_object on some platforms. I still fail to see how.