From: Pip Cet <pipcet@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: niwtrx@icloud.com, 38912@debbugs.gnu.org
Subject: bug#38912: 27.0.60; PDumper meets segmentation fault when evil is loaded
Date: Tue, 7 Jan 2020 19:31:10 +0000 [thread overview]
Message-ID: <CAOqdjBcMj92fwV3YcPYr4r7t19ELK6o4JiJXbVwLqoDzu4mNzw@mail.gmail.com> (raw)
In-Reply-To: <jwvimlozck4.fsf-monnier+emacs@gnu.org>
On Mon, Jan 6, 2020 at 6:13 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> The problem is simply that `sxhash` doesn't use the same "rules" about
> which objects are compared by identity and which objects are compared
> by contents.
I agree.
> so the problem doesn't affect only byte-compiled objects but also
> overlays, markers, windowconfigs, chartables, and fonts, AFAICT.
True, but then, those don't make much sense as hash keys in an
equal-based hash table. I don't think bytecode objects make sense as
hash keys in an equal-based hash table, either: two bytecode objects
can be `equal` yet be non-equivalent, even though it's somewhat
unlikely to occur in practice.
> The fix should be to make `sxhash` follow the same rules as `internal_equal`.
I think the two should largely follow the same rules, because all of
those objects should be equal iff they're eq. Hashing a marker based
on its position, for example, makes little sense: when the marker
moves, the hash value would change. Bytecode objects could be compared
based on their string representation, I guess, and maybe should be
hash-consed based on that (deduplicating identical bytecode objects
used as constants in other bytecode objects appears to save quite a
bit of space), once they're made immutable.
next prev parent reply other threads:[~2020-01-07 19:31 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-04 1:49 bug#38912: 27.0.60; PDumper meets segmentation fault when evil is loaded NiwTinray via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-01-04 9:17 ` Eli Zaretskii
[not found] ` <D1473DD8-48F8-4204-80B5-BE6396B8B668@icloud.com>
2020-01-05 18:45 ` Eli Zaretskii
2020-01-06 15:51 ` Pip Cet
2020-01-06 16:34 ` Eli Zaretskii
2020-01-06 16:38 ` Pip Cet
2020-01-06 17:20 ` Eli Zaretskii
2020-01-06 17:01 ` Daniel Colascione
2020-01-06 17:13 ` Pip Cet
2020-01-06 17:13 ` Pip Cet
2020-01-06 17:30 ` Eli Zaretskii
2020-01-06 18:13 ` Stefan Monnier
2020-01-06 18:19 ` Noam Postavsky
2020-01-06 18:29 ` Eli Zaretskii
2020-01-07 19:31 ` Pip Cet [this message]
2020-01-07 20:03 ` Stefan Monnier
2020-01-07 2:38 ` Paul Eggert
2020-01-07 3:34 ` dancol
2020-01-07 14:16 ` Stefan Monnier
2020-01-07 19:32 ` Paul Eggert
2020-01-07 19:32 ` Paul Eggert
2020-01-07 14:16 ` Stefan Monnier
2020-01-07 15:47 ` Eli Zaretskii
2020-01-07 17:37 ` Stefan Monnier
2020-01-07 17:37 ` Stefan Monnier
2020-01-07 17:43 ` Eli Zaretskii
2020-01-07 17:43 ` Eli Zaretskii
2020-01-07 18:01 ` Stefan Monnier
2020-01-07 18:01 ` Stefan Monnier
2020-01-07 18:11 ` Eli Zaretskii
2020-01-07 18:47 ` Stefan Monnier
2020-01-07 18:47 ` Stefan Monnier
2020-01-07 18:29 ` martin rudalics
2020-01-07 18:29 ` martin rudalics
2020-01-07 18:43 ` Stefan Monnier
2020-01-07 18:43 ` Stefan Monnier
2020-01-07 18:58 ` martin rudalics
2020-01-06 17:25 ` Eli Zaretskii
2020-01-07 23:43 ` Richard Stallman
2020-01-06 17:10 ` Daniel Colascione
2020-03-05 7:14 ` Eli Zaretskii
2020-03-09 2:15 ` Daniel Colascione
2020-03-09 3:26 ` Eli Zaretskii
2021-06-24 16:30 ` bug#32503: 26.1; Byte-compiled functions don't hash consistently Lars Ingebrigtsen
2022-04-28 11:41 ` bug#38912: 27.0.60; PDumper meets segmentation fault when evil is loaded Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOqdjBcMj92fwV3YcPYr4r7t19ELK6o4JiJXbVwLqoDzu4mNzw@mail.gmail.com \
--to=pipcet@gmail.com \
--cc=38912@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=niwtrx@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.