From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#17742: Limitations of enchant Date: Mon, 15 Sep 2014 13:06:55 +0200 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113395bc0026e8050318a214 X-Trace: ger.gmane.org 1410779304 9141 80.91.229.3 (15 Sep 2014 11:08:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 15 Sep 2014 11:08:24 +0000 (UTC) To: 17742@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 15 13:08:18 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XTU8n-0006pa-CN for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Sep 2014 13:08:17 +0200 Original-Received: from localhost ([::1]:58727 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTU8m-0003Fl-Tp for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Sep 2014 07:08:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTU8e-0003FY-MQ for bug-gnu-emacs@gnu.org; Mon, 15 Sep 2014 07:08:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTU8Z-0006Tk-LY for bug-gnu-emacs@gnu.org; Mon, 15 Sep 2014 07:08:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTU8Z-0006TY-Fr for bug-gnu-emacs@gnu.org; Mon, 15 Sep 2014 07:08:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XTU8Y-000800-LB for bug-gnu-emacs@gnu.org; Mon, 15 Sep 2014 07:08:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Sep 2014 11:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17742 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17742-submit@debbugs.gnu.org id=B17742.141077922230679 (code B ref 17742); Mon, 15 Sep 2014 11:08:02 +0000 Original-Received: (at 17742) by debbugs.gnu.org; 15 Sep 2014 11:07:02 +0000 Original-Received: from localhost ([127.0.0.1]:41185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XTU7Z-0007yT-4H for submit@debbugs.gnu.org; Mon, 15 Sep 2014 07:07:01 -0400 Original-Received: from mail-la0-f54.google.com ([209.85.215.54]:64002) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XTU7U-0007yE-RJ for 17742@debbugs.gnu.org; Mon, 15 Sep 2014 07:06:58 -0400 Original-Received: by mail-la0-f54.google.com with SMTP id ge10so4443857lab.13 for <17742@debbugs.gnu.org>; Mon, 15 Sep 2014 04:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:date:message-id:subject:from:to:content-type; bh=qZk9l1GFe9kLa5B5NtiefcUcvCya64ZoCes9YLgyTbA=; b=0WNUDGH7vyVHcEFK5LdztiMBp/RlKEl6aFFWUcSyjthdh72v9hi+cfYSlFav8JufZr oYO6pR35VtSM7haSPmyJBesxuGlj7bIIlGhWsQbYF421VXPRUTXoh9Knrb7VYjVZ3LlA JuFciglkDt9SC0Q/mtlCW6Rsf15ee1/pS2VO8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=qZk9l1GFe9kLa5B5NtiefcUcvCya64ZoCes9YLgyTbA=; b=eyveP/iuVnBDgVloBNWieU/y968KUnycy9dAgCLHSZbzNNl8Yv04oPxvbo4Xyh7lU+ L7Iey7Sit0/3Wvz/0+LqKCatakbEH8HO9W6/UTVKPgtYOtu4go93vgwEoBbiWc6nJeC3 NsLhcThMyl61PlmcXGHn0dN0RoaKZyN30hUp/EBxsT85a5BPN1bakWIMvLxmSWdvEWqg IzqQoarTlHPuL/JXAHZI3NRdOsYxQfHe9yqD2wKfFl7IhU/p2DHzFOxxBWegzzP9M4gn uy9TYcgpzYw8nTAw1t+n+oWoCwUsMevKnFEpOuH+T7U7IQVydhf/oFL1izjnItnvzECy mpFQ== X-Gm-Message-State: ALoCoQmDILBXcp/KmW0752YHwxG/ZWBhCE8y6Yei9zBEPmrQ54DsDzOiJz+lNtKluS7zNYXgJ5Js X-Received: by 10.112.166.139 with SMTP id zg11mr26193584lbb.62.1410779215564; Mon, 15 Sep 2014 04:06:55 -0700 (PDT) Original-Received: by 10.152.36.201 with HTTP; Mon, 15 Sep 2014 04:06:55 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93372 Archived-At: --001a113395bc0026e8050318a214 Content-Type: text/plain; charset=UTF-8 Since I didn't get any replies, I thought it might be worth noting what I'm sure some developer must already know, namely that enchant doesn't currently (v1.6.0) fully support the ispell pipe protocol. In particular, it doesnt seem to understand either adding words to the dictionary, nor saving the personal dictionary. In the former case it simply spell-checks the line, a result which Emacs ignores; in the latter, it gives an empty reply, and Emacs ignores the fact that it didn't get an "OK" result ("*"). There are still Emacs bugs here: I can't see in the code that Emacs ignores these failures on purpose, so it should detect and report them. Enchant can still be used to check spelling on a per-session basis (so maybe it's worth making the failures warnings rather than errors) but the user shouldn't be encouraged to believe that it's all working fine. Obviously, it would be nice if upstream enchant could be made to add this functionality in the pipe mode: since it's already implemented in libenchant, that should be easy. Or, as I previously suggested, Emacs could simply use libenchant and forget about the pipe interface. -- http://rrt.sc3d.org --001a113395bc0026e8050318a214 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Since I didn't get any replies, I thought it= might be worth noting what I'm sure some developer must already know, = namely that enchant doesn't currently (v1.6.0) fully support the ispell= pipe protocol. In particular, it doesnt seem to understand either adding w= ords to the dictionary, nor saving the personal dictionary. In the former c= ase it simply spell-checks the line, a result which Emacs ignores; in the l= atter, it gives an empty reply, and Emacs ignores the fact that it didn'= ;t get an "OK" result ("*").

There are sti= ll Emacs bugs here: I can't see in the code that Emacs ignores these fa= ilures on purpose, so it should detect and report them. Enchant can still b= e used to check spelling on a per-session basis (so maybe it's worth ma= king the failures warnings rather than errors) but the user shouldn't b= e encouraged to believe that it's all working fine.

Obviou= sly, it would be nice if upstream enchant could be made to add this functio= nality in the pipe mode: since it's already implemented in libenchant, = that should be easy. Or, as I previously suggested, Emacs could simply use = libenchant and forget about the pipe interface.
--001a113395bc0026e8050318a214--