From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#24640: Crashes in 25.1 Date: Wed, 12 Oct 2016 11:57:26 +0100 Message-ID: References: <83int3idxl.fsf@gnu.org> <83mviehq0p.fsf@gnu.org> <83eg3qhn29.fsf@gnu.org> <83vax2f1e5.fsf@gnu.org> <83r37pg7zl.fsf@gnu.org> <83y41wenld.fsf@gnu.org> <834m4kduzl.fsf@gnu.org> <831szodsus.fsf@gnu.org> <83zimccbzr.fsf@gnu.org> <83lgxvcd10.fsf@gnu.org> <83k2dfc4ya.fsf@gnu.org> <83bmyqdewf.fsf@gnu.org> <83h98hc106.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11402c06e04686053ea8db05 X-Trace: blaine.gmane.org 1476269920 6445 195.159.176.226 (12 Oct 2016 10:58:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 12 Oct 2016 10:58:40 +0000 (UTC) Cc: "Toby S. Cubitt" , 24640@debbugs.gnu.org, Phillip Lord To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 12 12:58:35 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1buHEn-0007AG-32 for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Oct 2016 12:58:17 +0200 Original-Received: from localhost ([::1]:60717 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buHEl-0007df-RP for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Oct 2016 06:58:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buHEb-0007cB-Bd for bug-gnu-emacs@gnu.org; Wed, 12 Oct 2016 06:58:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buHEY-0005cq-10 for bug-gnu-emacs@gnu.org; Wed, 12 Oct 2016 06:58:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46573) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buHEX-0005cm-UQ for bug-gnu-emacs@gnu.org; Wed, 12 Oct 2016 06:58:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1buHEX-0000LR-N0 for bug-gnu-emacs@gnu.org; Wed, 12 Oct 2016 06:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Oct 2016 10:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24640 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24640-submit@debbugs.gnu.org id=B24640.14762698561269 (code B ref 24640); Wed, 12 Oct 2016 10:58:01 +0000 Original-Received: (at 24640) by debbugs.gnu.org; 12 Oct 2016 10:57:36 +0000 Original-Received: from localhost ([127.0.0.1]:52763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1buHE8-0000KP-4D for submit@debbugs.gnu.org; Wed, 12 Oct 2016 06:57:36 -0400 Original-Received: from mail-lf0-f51.google.com ([209.85.215.51]:34677) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1buHE6-0000KD-7y for 24640@debbugs.gnu.org; Wed, 12 Oct 2016 06:57:34 -0400 Original-Received: by mail-lf0-f51.google.com with SMTP id b81so68830438lfe.1 for <24640@debbugs.gnu.org>; Wed, 12 Oct 2016 03:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=p1HNA7iZVSCdcrzLPIy92+UXnUfrvmZGoaAnKnsS9Kw=; b=RdeGb0S7YgsK0UZ2ul8269jJYWMfNLgZhKODiic9KaIt+VySryqnf535qCxk+RYA9u VinVJzo2OJYuVQiEB7IXcOW4ezbz7jJBRWaGe7iCV8lFNzMaUHUF7XG5Tqn2DxHD2bJE FyFYvy6BDhfQWAG+ogfuhYQ0MCaL8T8P4uBFY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=p1HNA7iZVSCdcrzLPIy92+UXnUfrvmZGoaAnKnsS9Kw=; b=HNXQTSilL5uGevNDWcJ0Rvv5lB2RmSAB2HcRSM6RpSNkzFxx+oEQcVq36qh+CGDZr9 a1uTjZYm4Bqv+uTlJDpqCaGzGt+xrm8DskIRS76cmx6DsjsuVcyk0z7VBoe0PwP4Q4wn qIexNzYNTDNgoNM+QEXb+6jkp2Mrj8iztG430UgENwUKs0XVgqCdrDHHyZkUMbRLN4uV efb3lukjg4QfB0xR7JuLit1Pkrr53WW6IBgPl1ZY2+0y0RdjfMwK72SOt2/DOCbMZOo2 5czETVVqfRgzf06klCjjgYFeWgajOggutKeTQSIs/C+jEx5vjAUqhLSCUgnogBkcKMLi HwQA== X-Gm-Message-State: AA6/9RlQUsV43ye4hTUt7ilF3jeXTvfAlzT54t8duIQz+QDWmpY7P8RU11yhYsR0THxggkzyAMznk54G/XlGAAVe X-Received: by 10.25.169.208 with SMTP id s199mr457303lfe.58.1476269847876; Wed, 12 Oct 2016 03:57:27 -0700 (PDT) Original-Received: by 10.25.66.211 with HTTP; Wed, 12 Oct 2016 03:57:26 -0700 (PDT) In-Reply-To: <83h98hc106.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124382 Archived-At: --001a11402c06e04686053ea8db05 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12 October 2016 at 11:31, Eli Zaretskii wrote: > > Date: Tue, 11 Oct 2016 19:33:20 +0300 > > From: Eli Zaretskii > > Cc: 24640@debbugs.gnu.org > > > > > =E2=80=8BYes, the crashes appear to stop when I comment out > (global-undo-tree-mode) in vars.el. > > > > OK, so we have our prime suspect. Can you tell where I can find the > > exact version of undo-tree-mode you are using? > > > > Phillip, could you please look into that package and see if you can > > spot any potential problems with the Emacs 25 undo internals? TIA. > > Some functions in undo-tree refer to or manipulate Emacs undo > internals: > > undo-list-pop-changeset > undo-list-transfer-to-tree > undo-list-rebuild-from-tree > undo-tree-pull-undo-in-region-branch > undo-tree-pull-redo-in-region-branch > undo-tree-adjust-elements-to-elt > undo-tree-apply-deltas > undo-tree-undo-1 > undo-tree-redo-1 > > Do they perhaps need some adjustments to Emacs 25's undo? > =E2=80=8BAnd regardless of that, should it in principle be possible to cras= h Emacs (other than by exhausting memory or CPU) from Lisp, except by calling external code improperly?=E2=80=8B Another potential issue is the new undo timer we have in Emacs 25 (see > undo-auto--boundary-ensure-timer in simple.el). One way of checking > whether this is related to the crashes is to modify that function to > use a much larger value for the 1st argument of run-at-time, say > 10000, so that the undo timer never fires during the startup. Reuben, > could you try that? > =E2=80=8BSure. I made that change in the sources and rebuilt, and it crashe= d "as usual". --=20 http://rrt.sc3d.org --001a11402c06e04686053ea8db05 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On = 12 October 2016 at 11:31, Eli Zaretskii <eliz@gnu.org> wrote:
=
> Date: Tue, 11 Oct 2016 19:33:20 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 24640@d= ebbugs.gnu.org
>
> > =E2=80=8BYes, the crashes appear to stop when I comm= ent out (global-undo-tree-mode) in vars.el.
>
> OK, so we have our prime suspect.=C2=A0 Can you tell where I can find = the
> exact version of undo-tree-mode you are using?
>
> Phillip, could you please look into that package and see if you can > spot any potential problems with the Emacs 25 undo internals?=C2=A0 TI= A.

Some functions in undo-tree refer to or manipulate Emacs undo
internals:

=C2=A0 undo-list-pop-changeset
=C2=A0 undo-list-transfer-to-tree
=C2=A0 undo-list-rebuild-from-tree
=C2=A0 undo-tree-pull-undo-in-region-branch
=C2=A0 undo-tree-pull-redo-in-region-branch
=C2=A0 undo-tree-adjust-elements-to-elt
=C2=A0 undo-tree-apply-deltas
=C2=A0 undo-tree-undo-1
=C2=A0 undo-tree-redo-1

Do they perhaps need some adjustments to Emacs 25's undo?

=E2=80=8BAnd regardless of that, should it in principle be possible to c= rash Emacs (other than by exhausting memory or CPU) from Lisp, except by ca= lling external code improperly?=E2=80=8B

Another potential issue is the new undo timer we hav= e in Emacs 25 (see
undo-auto--boundary-ensure-timer in simple.el).=C2=A0 One way of check= ing
whether this is related to the crashes is to modify that function to
use a much larger value for the 1st argument of run-at-time, say
10000, so that the undo timer never fires during the startup.=C2=A0 Reuben,=
could you try that?

=E2=80=8BSure. I made that change in the sources and rebuilt, and it cra= shed "as usual".

--
http://rrt.sc3= d.org
--001a11402c06e04686053ea8db05--