all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Reuben Thomas <rrt@sc3d.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 25230@debbugs.gnu.org
Subject: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for CASECHARS in built-in dictionaries
Date: Mon, 19 Dec 2016 21:17:17 +0000	[thread overview]
Message-ID: <CAOnWdojkWNhe0Mubq3VPoEsZ2sgLMq+n8H2yqbKvVxsOxs3mPQ@mail.gmail.com> (raw)
In-Reply-To: <831sx36g75.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

On 19 December 2016 at 16:23, Eli Zaretskii <eliz@gnu.org> wrote:

>
> You are assuming that [[:alpha:]] and [A-Za-z] are identical.


​No, because my patch does not change the current behaviour of the code.
The assumption that [:alpha:] is OK to use here instead of A-Za-z is
already in the code.​

IOW, I don't think this patch is in the right direction.
>

​From the conversation on other bugs, I think that the correct thing to do
here is to remove the first part of my patch (so that the hardwired
dictionaries keep their individual casechars and not-casechars settings),
and keep the second part of the patch (so that
ispell-set-spellchecker-params does not change them all to [:alpha:].

Does that sound plausible? If so, I'll prepare a modified patch for your
consideration.

-- 
http://rrt.sc3d.org

[-- Attachment #2: Type: text/html, Size: 1704 bytes --]

  reply	other threads:[~2016-12-19 21:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-19 12:28 bug#25230: Patch to ispell.el to simplify use of [:alpha:] for CASECHARS in built-in dictionaries Reuben Thomas
2016-12-19 16:23 ` Eli Zaretskii
2016-12-19 21:17   ` Reuben Thomas [this message]
2016-12-20 15:37     ` Eli Zaretskii
2016-12-20 18:42       ` Reuben Thomas
2016-12-20 19:37         ` Eli Zaretskii
2016-12-20 21:45           ` Reuben Thomas
2016-12-21  0:20             ` Reuben Thomas
2016-12-21 17:15               ` Eli Zaretskii
2016-12-21 17:31                 ` Reuben Thomas
2016-12-21 18:03                   ` Eli Zaretskii
2016-12-21 22:33                     ` Reuben Thomas
2019-06-24 23:08                       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOnWdojkWNhe0Mubq3VPoEsZ2sgLMq+n8H2yqbKvVxsOxs3mPQ@mail.gmail.com \
    --to=rrt@sc3d.org \
    --cc=25230@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.