From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#27833: 25.2; Add support for manpath command to woman.el Date: Wed, 26 Jul 2017 09:43:22 +0100 Message-ID: References: <871sp4xhq8.fsf@sc3d.org> <87pocot7al.fsf@holos> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="001a113ac7ead594f705553470ec" X-Trace: blaine.gmane.org 1501058691 21387 195.159.176.226 (26 Jul 2017 08:44:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 26 Jul 2017 08:44:51 +0000 (UTC) Cc: 27833@debbugs.gnu.org To: Mark Oteiza Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 26 10:44:45 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daHvu-00054Y-Jp for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jul 2017 10:44:42 +0200 Original-Received: from localhost ([::1]:36831 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daHvy-0003ts-HS for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jul 2017 04:44:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daHvL-0003VT-1V for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2017 04:44:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daHvG-0004GK-PG for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2017 04:44:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54051) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1daHvG-0004GA-Ir for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2017 04:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1daHvG-000717-Cr for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2017 04:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jul 2017 08:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27833 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27833-submit@debbugs.gnu.org id=B27833.150105861226927 (code B ref 27833); Wed, 26 Jul 2017 08:44:02 +0000 Original-Received: (at 27833) by debbugs.gnu.org; 26 Jul 2017 08:43:32 +0000 Original-Received: from localhost ([127.0.0.1]:56728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daHul-00070E-TB for submit@debbugs.gnu.org; Wed, 26 Jul 2017 04:43:32 -0400 Original-Received: from mail-oi0-f54.google.com ([209.85.218.54]:35639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daHuj-0006zz-8o for 27833@debbugs.gnu.org; Wed, 26 Jul 2017 04:43:29 -0400 Original-Received: by mail-oi0-f54.google.com with SMTP id e124so113966532oig.2 for <27833@debbugs.gnu.org>; Wed, 26 Jul 2017 01:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=F5L1QaCc3PS50iSkeblArLIVNeAd326tv5JJaSfCJ44=; b=f12IC5hR3dvjpf2qGCjMS6p7k5nnn4dp9u+Hy1H5IT4vFH8IqujWlC6hb48XyzEbKI 1KaEkhLJXFdc4pjF8Mn9XBaURVstk0yiIyTf1HOl8zR2191iEFCJoBcKZuGrmAfJYR4Y tMf+AoPwfIBOigetVTZAXv7RMD/5SxvuKl1wQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=F5L1QaCc3PS50iSkeblArLIVNeAd326tv5JJaSfCJ44=; b=hcU7fbwUIF6YXC+j+b8rtQhVMLqX4eZhWez+3sZ78PjajZzu9jrbq5gFS9emjTDNdF oX5jAxZ3RmhtJ44+YQcBVCpbOM5Pw3c3CVl1mC2v3ZJVd/S8kVkOcIHmMoFJLklQNZJ8 +F7UGGVzXXEmScEhk3DXXEVucebTFUsvbU18D3yjlonT2SyVl0i3JX6NSa8Oh3AA/3ZY nt2NX/o5K1UrkkmrMx8IP+IQkMnTnQOdtB5ch896cjr+5VLdopcENG+nv8t7re69mZdo hEHl01HKHIY+Ht1r9Hcu2glNV6fNeUCzG3JrpQA6Ut+aqt4XSeJDKl/GVNGKaMhx3L1u UtEw== X-Gm-Message-State: AIVw113UkO7UnGz3F8h2I2dnQ266Or9wO/Q/eb70sDQEx67FgUcPTbxy y6RkoGs7whoU7DMXo/nLOBhkVZVcACaO X-Received: by 10.202.206.202 with SMTP id e193mr140128oig.235.1501058603240; Wed, 26 Jul 2017 01:43:23 -0700 (PDT) Original-Received: by 10.202.183.87 with HTTP; Wed, 26 Jul 2017 01:43:22 -0700 (PDT) In-Reply-To: <87pocot7al.fsf@holos> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135010 Archived-At: --001a113ac7ead594f705553470ec Content-Type: multipart/alternative; boundary="001a113ac7ead594f305553470ea" --001a113ac7ead594f305553470ea Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On 26 July 2017 at 00:40, Mark Oteiza wrote: > > Reuben Thomas writes: > > + (woman-parse-colon-path (condition-case nil > > + (chomp (with-output-to-string > > + (with-current-buffer > > + standard-output > > + (call-process "manpath" > nil t nil)))) > > + (error nil)))) > > + (woman-manpath-add-locales > > I suspect your chomp is analogous to string-trim-right in subr-x.el > =E2=80=8BThanks! I'd had chomp in my Emacs init for so long I had forgotten= it wasn't part of Emacs, and didn't know about string-trim-right. Updated patch attached (and that function purged from my init, and my personal uses of it replaced by string-trim-right). --=20 https://rrt.sc3d.org --001a113ac7ead594f305553470ea Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On = 26 July 2017 at 00:40, Mark Oteiza <mvoteiza@udel.edu> wrote= :

Reuben Thomas <rrt@sc3d.org> writ= es:
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(woman-parse-colon-path (condition-case ni= l
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(chomp (with-output= -to-string
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 (with-current-buffer
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 standard-output
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 (call-process "manpath" nil t nil))))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(error nil))))
> +=C2=A0 =C2=A0 =C2=A0 (woman-manpath-add-locales

I suspect your chomp is analogous to string-trim-right in subr-x.el

=E2=80=8BThanks! I'd had chomp in my Emacs init for so long I had fo= rgotten it wasn't part of Emacs, and didn't know about string-trim-= right. Updated patch attached (and that function purged from my init, and m= y personal uses of it replaced by string-trim-right).

-= -
--001a113ac7ead594f305553470ea-- --001a113ac7ead594f705553470ec Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Try-to-set-woman-manpath-from-output-of-manpath-comm.patch" Content-Disposition: attachment; filename="0001-Try-to-set-woman-manpath-from-output-of-manpath-comm.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j5krj2hb0 RnJvbSAyMGI4YjdiZTIyOTEwNDU0ZTZjMTUxZjM2NTViZGQzOWY2ZTMyYzk0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFR1 ZSwgMjUgSnVsIDIwMTcgMjM6Mzc6MTcgKzAxMDAKU3ViamVjdDogW1BBVENIXSBUcnkgdG8gc2V0 IHdvbWFuLW1hbnBhdGggZnJvbSBvdXRwdXQgb2YgbWFucGF0aCBjb21tYW5kCgoqIGxpc3Avd29t YW4uZWwgKHdvbWFuLW1hbnBhdGgpOiBUcnkgcnVubmluZyBtYW5wYXRoLCBwcm92aWRlZCBieQpy ZWNlbnQgbWFuLWRiLCB0byBnZXQgbWFuIHBhZ2UgcGF0aHMuCi0tLQogbGlzcC93b21hbi5lbCB8 IDcgKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBh L2xpc3Avd29tYW4uZWwgYi9saXNwL3dvbWFuLmVsCmluZGV4IGFhODU2YzMuLjA2ZDAxYmIgMTAw NjQ0Ci0tLSBhL2xpc3Avd29tYW4uZWwKKysrIGIvbGlzcC93b21hbi5lbApAQCAtNjMzLDYgKzYz MywxMyBAQCB3b21hbi1tYW5wYXRoLWFkZC1sb2NhbGVzCiAoZGVmY3VzdG9tIHdvbWFuLW1hbnBh dGgKICAgOzsgTG9jYWxlcyBjb3VsZCBhbHNvIGJlIGFkZGVkIGluIHdvbWFuLWV4cGFuZC1kaXJl Y3RvcnktcGF0aC4KICAgKG9yICh3b21hbi1tYW5wYXRoLWFkZC1sb2NhbGVzCisgICAgICAgKHdv bWFuLXBhcnNlLWNvbG9uLXBhdGggKGNvbmRpdGlvbi1jYXNlIG5pbAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAoc3RyaW5nLXRyaW0tcmlnaHQgKHdpdGgtb3V0cHV0LXRvLXN0 cmluZworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAod2l0aC1jdXJyZW50LWJ1ZmZlcgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhbmRhcmQtb3V0cHV0CisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNhbGwtcHJv Y2VzcyAibWFucGF0aCIgbmlsIHQgbmlsKSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKGVycm9yIG5pbCkpKSkKKyAgICAgICh3b21hbi1tYW5wYXRoLWFkZC1sb2NhbGVzCiAg ICAgICAgKHdvbWFuLXBhcnNlLWNvbG9uLXBhdGggKGdldGVudiAiTUFOUEFUSCIpKSkKICAgICAg ICcoIi91c3IvbWFuIiAiL3Vzci9zaGFyZS9tYW4iICIvdXNyL2xvY2FsL21hbiIpKQogICAiTGlz dCBvZiBESVJFQ1RPUlkgVFJFRVMgdG8gc2VhcmNoIGZvciBVTipYIG1hbnVhbCBmaWxlcy4KLS0g CjIuNy40Cgo= --001a113ac7ead594f705553470ec--