From: Reuben Thomas <rrt@sc3d.org>
To: 18229@debbugs.gnu.org
Subject: bug#18229: LIBS vs LIBOBJS in src/Makefile.in
Date: Sat, 9 Aug 2014 14:18:52 +0100 [thread overview]
Message-ID: <CAOnWdoj3ORm6SBTk4DK2xfJAFahgTwT3rUCaMxveseXX=4yRvw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]
Trying to pass an extra library to configure using LIBS, as configure
--help says I can, I found it did nothing, and traced it to
src/Makefile.in, which deliberately ignores LIBS. This dates back 14 years,
and whatever it was intended to fix no longer seems to be a problem. May I
install the following patch? With the patch applied, supplying LIBS on the
configure command-line worked exactly as it should.
--- src/Makefile.in 2014-07-13 15:50:35 +0000
+++ src/Makefile.in 2014-08-09 11:34:12 +0000
@@ -44,10 +44,7 @@
# BSD doesn't have it as a default.
@SET_MAKE@
MKDIR_P = @MKDIR_P@
-# Don't use LIBS. configure puts stuff in it that either shouldn't be
-# linked with Emacs or is duplicated by the other stuff below.
-# LIBS = @LIBS@
-LIBOBJS = @LIBOBJS@
+LIBS = @LIBS@
lispsource = $(top_srcdir)/lisp
lib = ../lib
@@ -388,7 +385,7 @@
## List of object files that make-docfile should not be told about.
otherobj= $(TERMCAP_OBJ) $(PRE_ALLOC_OBJ) $(GMALLOC_OBJ) $(RALLOC_OBJ) \
- $(POST_ALLOC_OBJ) $(WIDGET_OBJ) $(LIBOBJS)
+ $(POST_ALLOC_OBJ) $(WIDGET_OBJ) $(LIBS)
## All object files linked into temacs. $(VMLIMIT_OBJ) should be first.
## (On MinGW, firstfile.o should be before vm-limit.o.)
--
http://rrt.sc3d.org
[-- Attachment #2: Type: text/html, Size: 1461 bytes --]
next reply other threads:[~2014-08-09 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-09 13:18 Reuben Thomas [this message]
2014-08-09 19:46 ` bug#18229: LIBS vs LIBOBJS in src/Makefile.in Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOnWdoj3ORm6SBTk4DK2xfJAFahgTwT3rUCaMxveseXX=4yRvw@mail.gmail.com' \
--to=rrt@sc3d.org \
--cc=18229@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.